Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571534 > unrolled thread

[PATCH v3 0/4] Fill in lacking parts and Refactor several parts

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/4] Fill in lacking parts and Refactor several parts Taeung Song <treeze.taeung@gmail.com> - 2017-02-01 13:40 +0100
    [PATCH v3 1/4] perf tools: Only increase index if perf_evsel__new_idx() succeeds Taeung Song <treeze.taeung@gmail.com> - 2017-02-01 13:40 +0100
      [tip:perf/core] perf tools: Only increase index if  perf_evsel__new_idx() succeeds tip-bot for Taeung Song <tipbot@zytor.com> - 2017-02-10 09:50 +0100

#1571534 — [PATCH v3 0/4] Fill in lacking parts and Refactor several parts

v3:
 - Split a patch in accordance with "no functional changes"
 or "change logic" (Arnaldo)
 - Change the title of commit message (Arnaldo)

v2:
 - Check the return of perf_config() and
 warn the user with config error message (Arnaldo)
 - Change commit messages (Jiri)
 - Add only one macro instead of two macros (Jiri) 

Taeung Song (4):
  perf tools: Only increase index if perf_evsel__new_idx() succeeds
  perf tools: Fill in a lacking part no checking NULL after zalloc() in
    parse-events.c
  perf tools: Use zfree() instead of free() and assigning NULL to the
    pointer
  perf tools: Use zfree() to be more safe in parse-events.c

 tools/perf/util/parse-events.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1571537 — [PATCH v3 1/4] perf tools: Only increase index if perf_evsel__new_idx() succeeds

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/util/parse-events.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3c876b8..5d90fe7 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -310,10 +310,11 @@ __add_event(struct list_head *list, int *idx,
 
 	event_attr_init(attr);
 
-	evsel = perf_evsel__new_idx(attr, (*idx)++);
+	evsel = perf_evsel__new_idx(attr, *idx);
 	if (!evsel)
 		return NULL;
 
+	(*idx)++;
 	evsel->cpus     = cpu_map__get(cpus);
 	evsel->own_cpus = cpu_map__get(cpus);
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1578288 — [tip:perf/core] perf tools: Only increase index if perf_evsel__new_idx() succeeds

Commit-ID:  75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Gitweb:     http://git.kernel.org/tip/75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Author:     Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Wed, 1 Feb 2017 21:34:04 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 8 Feb 2017 09:41:10 -0300

perf tools: Only increase index if perf_evsel__new_idx() succeeds

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1485952447-7013-2-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/parse-events.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 6dbcba7..2720600 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -310,10 +310,11 @@ __add_event(struct list_head *list, int *idx,
 
 	event_attr_init(attr);
 
-	evsel = perf_evsel__new_idx(attr, (*idx)++);
+	evsel = perf_evsel__new_idx(attr, *idx);
 	if (!evsel)
 		return NULL;
 
+	(*idx)++;
 	evsel->cpus     = cpu_map__get(cpus);
 	evsel->own_cpus = cpu_map__get(cpus);
 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web