Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571522 > unrolled thread

Re: [PATCH v2] initramfs: finish fput() before accessing any binary from initramfs

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] initramfs: finish fput() before accessing any binary  from initramfs Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-01 13:30 +0100
    Re: [PATCH v2] initramfs: finish fput() before accessing any binary  from initramfs Lokesh Vutla <lokeshvutla@ti.com> - 2017-02-01 14:50 +0100

#1571522 — Re: [PATCH v2] initramfs: finish fput() before accessing any binary from initramfs

On Tue, Jan 24, 2017 at 11:06:36AM +0530, Lokesh Vutla wrote:
> commit 4a9d4b024a31 ("switch fput to task_work_add") implements a
> schedule_work() for completing fput(), but did not guarantee calling
> __fput() after unpacking initramfs. Because of this, there is a
> possibility that during boot a driver can see ETXTBSY when it tries
> to load a binary from initramfs as fput() is still pending on that
> binary. This patch makes sure that fput() is completed after unpacking
> initramfs.

Umm...  Do we want it done in kernel_init(), then?  I have no objections
against calling it in populate_rootfs(), and it looks like a sane place
for that, but I wonder if the old callsite would remain needed after that...

[toc] | [next] | [standalone]

#1571574

On Wednesday 01 February 2017 05:58 PM, Al Viro wrote:
> On Tue, Jan 24, 2017 at 11:06:36AM +0530, Lokesh Vutla wrote:
>> commit 4a9d4b024a31 ("switch fput to task_work_add") implements a
>> schedule_work() for completing fput(), but did not guarantee calling
>> __fput() after unpacking initramfs. Because of this, there is a
>> possibility that during boot a driver can see ETXTBSY when it tries
>> to load a binary from initramfs as fput() is still pending on that
>> binary. This patch makes sure that fput() is completed after unpacking
>> initramfs.
> 
> Umm...  Do we want it done in kernel_init(), then?  I have no objections
> against calling it in populate_rootfs(), and it looks like a sane place
> for that, but I wonder if the old callsite would remain needed after that...
> 

Hmm..You are right, the call in kernel_init() is unnecessary. Will post
an updated version.

Thanks and regards,
Lokesh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web