Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571504 > unrolled thread

af_alg broken in 3.12

Back to article view | Back to linux.kernel

Contents

  af_alg broken in 3.12 Torsten Duwe <duwe@lst.de> - 2017-02-01 13:20 +0100
    Re: af_alg broken in 3.12 Torsten Duwe <duwe@lst.de> - 2017-02-03 13:10 +0100

#1571504 — af_alg broken in 3.12

[Multipart message — attachments visible in raw view] — view raw

Hi Herbert,

you sent a backport of 6de62f15b581f920ade22d758f4c338311c2f0d4 to be included
in the 3.12 branch (as b2a0707817d3dec83652bb460a7775613058ae), but this leaves
af_alg broken for unkeyed hash functions:

f382cd5ac26674877143fa7d9c0ea23c6640e706 (3.12 just before your commit) :

socket(PF_ALG, SOCK_SEQPACKET, 0)       = 3
bind(3, {sa_family=AF_ALG, sa_data="hash\0\0\0\0\0\0\0\0\0\0"}, 88) = 0
accept(3, 0, NULL)                      = 4
write(4, "abc", 3)                      = 3
read(4, "\220\1P\230<\322O\260\326\226?}(\341\177r", 16) = 16

and with b2a0707817d3dec83652bb460a7775613058ae applied:

socket(PF_ALG, SOCK_SEQPACKET, 0)       = 3
bind(3, {sa_family=AF_ALG, sa_data="hash\0\0\0\0\0\0\0\0\0\0"}, 88) = 0
accept(3, 0, NULL)                      = 4
write(4, "abc", 3)                      = -1 ENOKEY (Required key not available)
read(4, 0x7ffebeba0e30, 16)             = -1 ENOKEY (Required key not available)

Mainline has meanwhile seen many fixes to this change; can you suggest an elegant
and crisp backport for these as well?

TIA,
	Torsten

[toc] | [next] | [standalone]

#1573049

On Wed, Feb 01, 2017 at 01:13:05PM +0100, Torsten Duwe wrote:
> Hi Herbert,
> 
> you sent a backport of 6de62f15b581f920ade22d758f4c338311c2f0d4 to be included
> in the 3.12 branch (as b2a0707817d3dec83652bb460a7775613058ae), but this leaves
> af_alg broken for unkeyed hash functions:
[...]
> Mainline has meanwhile seen many fixes to this change; can you suggest an elegant
> and crisp backport for these as well?
> 

If Herbert does not have a better idea, I suggest to back out this change and fix
dynamically allocated key structures for the individual algorithms instead, for
the older branches.

Any other suggestions?

	Torsten

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web