Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1570224 > unrolled thread
| Started by | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| First post | 2017-01-31 02:10 +0100 |
| Last post | 2017-01-31 09:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] platform: x86: fix silead_dmi build error and depends Randy Dunlap <rdunlap@infradead.org> - 2017-01-31 02:10 +0100
Re: [PATCH -next] platform: x86: fix silead_dmi build error and depends Hans de Goede <hdegoede@redhat.com> - 2017-01-31 09:50 +0100
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-01-31 02:10 +0100 |
| Subject | [PATCH -next] platform: x86: fix silead_dmi build error and depends |
| Message-ID | <t5v7j-2HW-1@gated-at.bofh.it> |
From: Randy Dunlap <rdunlap@infradead.org> This driver cannot be built as a loadable module, so it should not be built unless I2C=y and INPUT=y. Fixes this build error: drivers/built-in.o: In function `silead_ts_dmi_init': silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I don't see why the "depends on INPUT" was there at all, but I modified its requirement anyway. Maybe it can be removed... --- linux-next-20170130.orig/drivers/platform/x86/Kconfig +++ linux-next-20170130/drivers/platform/x86/Kconfig @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT=y ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle
[toc] | [next] | [standalone]
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2017-01-31 09:50 +0100 |
| Subject | Re: [PATCH -next] platform: x86: fix silead_dmi build error and depends |
| Message-ID | <t5Cit-6WK-1@gated-at.bofh.it> |
| In reply to | #1570224 |
Hi, On 31-01-17 01:44, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > This driver cannot be built as a loadable module, so it should not > be built unless I2C=y and INPUT=y. > > Fixes this build error: > drivers/built-in.o: In function `silead_ts_dmi_init': > silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Hans de Goede <hdegoede@redhat.com> Thank you for catching this. However the depends on INPUT is not necessary at all (likely a copy and paste error during development) can you please do a v2 dropping the input dependency all together ? Regards, Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > I don't see why the "depends on INPUT" was there at all, > but I modified its requirement anyway. Maybe it can be removed... > > --- linux-next-20170130.orig/drivers/platform/x86/Kconfig > +++ linux-next-20170130/drivers/platform/x86/Kconfig > @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 > > config SILEAD_DMI > bool "Tablets with Silead touchscreens" > - depends on ACPI && DMI && I2C && INPUT > + depends on ACPI && DMI && I2C=y && INPUT=y > ---help--- > Certain ACPI based tablets with Silead touchscreens do not have > enough data in ACPI tables for the touchscreen driver to handle >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web