Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569790 > unrolled thread

[PATCH 0/5] gpio: Remove unnecessary driver_data set operations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/5] gpio: Remove unnecessary driver_data set operations William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-01-30 15:50 +0100
    [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-01-30 15:50 +0100
      Re: [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set Linus Walleij <linus.walleij@linaro.org> - 2017-02-01 14:30 +0100
    [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-01-30 15:50 +0100
      Re: [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set Linus Walleij <linus.walleij@linaro.org> - 2017-02-01 14:30 +0100
    [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-01-30 15:50 +0100
      Re: [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set Linus Walleij <linus.walleij@linaro.org> - 2017-02-01 14:50 +0100

#1569790 — [PATCH 0/5] gpio: Remove unnecessary driver_data set operations

In a previous patchset ("gpio: Utilize devm_ functions in driver probe
callbacks") the device remove functions for several drivers were removed
as no longer necessary due to the patchset changes within. Setting
driver_data had been necessary in these drivers in order to access
private data in the respective device remove function. Now that the
device remove functions are gone, setting driver_data is no longer
necessary for these drivers. This patchset removes the relevant code.

William Breathitt Gray (5):
  gpio: 104-dio-48e: Remove unnecessary driver_data set
  gpio: 104-idi-48: Remove unnecessary driver_data set
  gpio: 104-idio-16: Remove unnecessary driver_data set
  gpio: gpio-mm: Remove unnecessary driver_data set
  gpio: ws16c48: Remove unnecessary driver_data set

 drivers/gpio/gpio-104-dio-48e.c | 2 --
 drivers/gpio/gpio-104-idi-48.c  | 2 --
 drivers/gpio/gpio-104-idio-16.c | 2 --
 drivers/gpio/gpio-gpio-mm.c     | 2 --
 drivers/gpio/gpio-ws16c48.c     | 2 --
 5 files changed, 10 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1569793 — [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set

Setting driver_data was necessary to access private data in the
dio48e_remove function. Now that the dio48e_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/gpio/gpio-104-dio-48e.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
index 221243f17d4e..b6b0378166c4 100644
--- a/drivers/gpio/gpio-104-dio-48e.c
+++ b/drivers/gpio/gpio-104-dio-48e.c
@@ -369,8 +369,6 @@ static int dio48e_probe(struct device *dev, unsigned int id)
 
 	spin_lock_init(&dio48egpio->lock);
 
-	dev_set_drvdata(dev, dio48egpio);
-
 	err = devm_gpiochip_add_data(dev, &dio48egpio->chip, dio48egpio);
 	if (err) {
 		dev_err(dev, "GPIO registering failed (%d)\n", err);
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1571557 — Re: [PATCH 1/5] gpio: 104-dio-48e: Remove unnecessary driver_data set

On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:

> Setting driver_data was necessary to access private data in the
> dio48e_remove function. Now that the dio48e_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1569794 — [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set

Setting driver_data was necessary to access private data in the
idi_48_remove function. Now that the idi_48_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/gpio/gpio-104-idi-48.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-104-idi-48.c b/drivers/gpio/gpio-104-idi-48.c
index eafbf053f3e8..dc100dff6e13 100644
--- a/drivers/gpio/gpio-104-idi-48.c
+++ b/drivers/gpio/gpio-104-idi-48.c
@@ -246,8 +246,6 @@ static int idi_48_probe(struct device *dev, unsigned int id)
 	spin_lock_init(&idi48gpio->lock);
 	spin_lock_init(&idi48gpio->ack_lock);
 
-	dev_set_drvdata(dev, idi48gpio);
-
 	err = devm_gpiochip_add_data(dev, &idi48gpio->chip, idi48gpio);
 	if (err) {
 		dev_err(dev, "GPIO registering failed (%d)\n", err);
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1571555 — Re: [PATCH 2/5] gpio: 104-idi-48: Remove unnecessary driver_data set

On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:

> Setting driver_data was necessary to access private data in the
> idi_48_remove function. Now that the idi_48_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1569798 — [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set

Setting driver_data was necessary to access private data in the
gpiomm_remove function. Now that the gpiomm_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/gpio/gpio-gpio-mm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-gpio-mm.c b/drivers/gpio/gpio-gpio-mm.c
index 393c8f9cf30d..60017425b49f 100644
--- a/drivers/gpio/gpio-gpio-mm.c
+++ b/drivers/gpio/gpio-gpio-mm.c
@@ -261,8 +261,6 @@ static int gpiomm_probe(struct device *dev, unsigned int id)
 
 	spin_lock_init(&gpiommgpio->lock);
 
-	dev_set_drvdata(dev, gpiommgpio);
-
 	err = devm_gpiochip_add_data(dev, &gpiommgpio->chip, gpiommgpio);
 	if (err) {
 		dev_err(dev, "GPIO registering failed (%d)\n", err);
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1571569 — Re: [PATCH 4/5] gpio: gpio-mm: Remove unnecessary driver_data set

On Mon, Jan 30, 2017 at 3:40 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:

> Setting driver_data was necessary to access private data in the
> gpiomm_remove function. Now that the gpiomm_remove function is gone,
> driver_data is no longer used. This patch removes the relevant code.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web