Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1569788 > unrolled thread
| Started by | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| First post | 2017-01-30 15:50 +0100 |
| Last post | 2017-02-01 14:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/5] gpio: 104-idio-16: Remove unnecessary driver_data set William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-01-30 15:50 +0100
Re: [PATCH 3/5] gpio: 104-idio-16: Remove unnecessary driver_data set Linus Walleij <linus.walleij@linaro.org> - 2017-02-01 14:30 +0100
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Date | 2017-01-30 15:50 +0100 |
| Subject | [PATCH 3/5] gpio: 104-idio-16: Remove unnecessary driver_data set |
| Message-ID | <t5lrj-595-7@gated-at.bofh.it> |
Setting driver_data was necessary to access private data in the
idio_16_remove function. Now that the idio_16_remove function is gone,
driver_data is no longer used. This patch removes the relevant code.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-104-idio-16.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c
index 01a091e17614..67068b61b90b 100644
--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -242,8 +242,6 @@ static int idio_16_probe(struct device *dev, unsigned int id)
spin_lock_init(&idio16gpio->lock);
- dev_set_drvdata(dev, idio16gpio);
-
err = devm_gpiochip_add_data(dev, &idio16gpio->chip, idio16gpio);
if (err) {
dev_err(dev, "GPIO registering failed (%d)\n", err);
--
2.11.0
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-02-01 14:30 +0100 |
| Message-ID | <t6391-6uR-25@gated-at.bofh.it> |
| In reply to | #1569788 |
On Mon, Jan 30, 2017 at 3:39 PM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > Setting driver_data was necessary to access private data in the > idio_16_remove function. Now that the idio_16_remove function is gone, > driver_data is no longer used. This patch removes the relevant code. > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Patch applied. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web