Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569736 > unrolled thread

Re: irq domain hierarchy vs. chaining w/ PCI MSI-X...

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: irq domain hierarchy vs. chaining w/ PCI MSI-X... Thomas Gleixner <tglx@linutronix.de> - 2017-01-30 14:40 +0100

#1569736 — Re: irq domain hierarchy vs. chaining w/ PCI MSI-X...

On Fri, 13 Jan 2017, David Daney wrote:
> At the point where the handle_*_irq() functions call handle_irq_event(), we
> need to 9optionally) do something both immediately before and after the call
> to handle_irq_event().
> 
> In irq_chip add a function:
> 
>     void (*irq_handle)(struct irq_data *data, struct irq_desc *desc);
> 
> Really this is the per irq_chip flow handler.
> 
> Then in handle_fasteoi_irq() and probably the other flow handlers as well:
> 
>    .
>    .
>    .
>    if (chip->irq_handle)
>       chip->irq_handle(&desc->irq_data, desc);
>    else
>       handle_irq_event(desc);
>    .
>    .
>    .
> 
> Those 4 lines of code could be factored out into a helper function in chip.c


And why don't you just write a flow handler function which does exactly
what you need instead of adding more conditionals into all hotpath
functions?

Thanks,

	tglx

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web