Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566306 > unrolled thread

[PATCH v2 0/2] addr nor flash node for mt2701

Started byGuochun Mao <guochun.mao@mediatek.com>
First post2017-01-25 04:40 +0100
Last post2017-02-12 00:40 +0100
Articles 11 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/2] addr nor flash node for mt2701 Guochun Mao <guochun.mao@mediatek.com> - 2017-01-25 04:40 +0100
    [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao <guochun.mao@mediatek.com> - 2017-01-25 04:40 +0100
      Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings John Crispin <john@phrozen.org> - 2017-01-25 06:50 +0100
      Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:50 +0100
      Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings Rob Herring <robh@kernel.org> - 2017-01-27 23:40 +0100
        Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-30 14:00 +0100
          Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao <guochun.mao@mediatek.com> - 2017-02-02 04:30 +0100
    [PATCH v2 2/2] arm: dts: mt2701: add nor flash node Guochun Mao <guochun.mao@mediatek.com> - 2017-01-25 04:40 +0100
      Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node Guochun Mao <guochun.mao@mediatek.com> - 2017-02-05 05:20 +0100
        Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-06 08:50 +0100
          Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node Matthias Brugger <matthias.bgg@gmail.com> - 2017-02-12 00:40 +0100

#1566306 — [PATCH v2 0/2] addr nor flash node for mt2701

FromGuochun Mao <guochun.mao@mediatek.com>
Date2017-01-25 04:40 +0100
Subject[PATCH v2 0/2] addr nor flash node for mt2701
Message-ID<t3mBb-4RB-3@gated-at.bofh.it>
Update DT bindings, clarify compatible strings that mt2701-nor node should contain. 
This patch series based on v4.10-rc2, include MT2701 spi nor node.
Dependent on "Add clock and power domain DT nodes for Mediatek MT2701"
[1] http://lists.infradead.org/pipermail/linux-mediatek/2016-December/007637.html

Guochun Mao (2):
  Documentation: mtk-quadspi: update DT bindings
  arm: dts: mt2701: add nor flash node

 .../devicetree/bindings/mtd/mtk-quadspi.txt        |  8 ++++++-
 arch/arm/boot/dts/mt2701-evb.dts                   | 25 ++++++++++++++++++++++
 arch/arm/boot/dts/mt2701.dtsi                      | 12 +++++++++++
 3 files changed, 44 insertions(+), 1 deletion(-)

-- 
1.8.1.1.dirty

[toc] | [next] | [standalone]

#1566307 — [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromGuochun Mao <guochun.mao@mediatek.com>
Date2017-01-25 04:40 +0100
Subject[PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t3mBb-4RB-1@gated-at.bofh.it>
In reply to#1566306
Add "mediatek,mt2701-nor" for nor flash node's compatible.

Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
---
 .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
index fb314f0..5ded66a 100644
--- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
@@ -1,7 +1,13 @@
 * Serial NOR flash controller for MTK MT81xx (and similar)
 
 Required properties:
-- compatible: 	  should be "mediatek,mt8173-nor";
+- compatible: 	  The possible values are:
+		  "mediatek,mt2701-nor"
+		  "mediatek,mt7623-nor"
+		  "mediatek,mt8173-nor"
+		  For mt8173, compatible should be "mediatek,mt8173-nor".
+		  For every other SoC, should contain both the SoC-specific compatible string
+		  and "mediatek,mt8173-nor".
 - reg: 		  physical base address and length of the controller's register
 - clocks: 	  the phandle of the clocks needed by the nor controller
 - clock-names: 	  the names of the clocks
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1566335 — Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromJohn Crispin <john@phrozen.org>
Date2017-01-25 06:50 +0100
SubjectRe: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t3oD0-6ae-13@gated-at.bofh.it>
In reply to#1566307

On 25/01/2017 04:38, Guochun Mao wrote:
> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index fb314f0..5ded66a 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -1,7 +1,13 @@
>  * Serial NOR flash controller for MTK MT81xx (and similar)
>  
>  Required properties:
> -- compatible: 	  should be "mediatek,mt8173-nor";
> +- compatible: 	  The possible values are:
> +		  "mediatek,mt2701-nor"
> +		  "mediatek,mt7623-nor"

Thanks !

Acked-by: John Crispin <john@phrozen.org>


> +		  "mediatek,mt8173-nor"
> +		  For mt8173, compatible should be "mediatek,mt8173-nor".
> +		  For every other SoC, should contain both the SoC-specific compatible string
> +		  and "mediatek,mt8173-nor".
>  - reg: 		  physical base address and length of the controller's register
>  - clocks: 	  the phandle of the clocks needed by the nor controller
>  - clock-names: 	  the names of the clocks
>

[toc] | [prev] | [next] | [standalone]

#1567594 — Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromCyrille Pitchen <cyrille.pitchen@atmel.com>
Date2017-01-26 17:50 +0100
SubjectRe: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t3Vpf-1gJ-9@gated-at.bofh.it>
In reply to#1566307
Le 25/01/2017 à 04:38, Guochun Mao a écrit :
> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index fb314f0..5ded66a 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -1,7 +1,13 @@
>  * Serial NOR flash controller for MTK MT81xx (and similar)
>  
>  Required properties:
> -- compatible: 	  should be "mediatek,mt8173-nor";
> +- compatible: 	  The possible values are:
> +		  "mediatek,mt2701-nor"
> +		  "mediatek,mt7623-nor"
> +		  "mediatek,mt8173-nor"
> +		  For mt8173, compatible should be "mediatek,mt8173-nor".
> +		  For every other SoC, should contain both the SoC-specific compatible string
> +		  and "mediatek,mt8173-nor".
>  - reg: 		  physical base address and length of the controller's register
>  - clocks: 	  the phandle of the clocks needed by the nor controller
>  - clock-names: 	  the names of the clocks
> 

Rob, is it ok for you if I take this patch in the spi-nor tree?

Best regards,

Cyrille

[toc] | [prev] | [next] | [standalone]

#1568766 — Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromRob Herring <robh@kernel.org>
Date2017-01-27 23:40 +0100
SubjectRe: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t4nlv-1yl-1@gated-at.bofh.it>
In reply to#1566307
On Wed, Jan 25, 2017 at 11:38:34AM +0800, Guochun Mao wrote:
> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1569715 — Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromCyrille Pitchen <cyrille.pitchen@atmel.com>
Date2017-01-30 14:00 +0100
SubjectRe: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t5jIT-45O-39@gated-at.bofh.it>
In reply to#1568766
Le 27/01/2017 à 23:29, Rob Herring a écrit :
> On Wed, Jan 25, 2017 at 11:38:34AM +0800, Guochun Mao wrote:
>> Add "mediatek,mt2701-nor" for nor flash node's compatible.
>>
>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>> ---
>>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
Applied to the github spi-nor tree.

Thanks!

[toc] | [prev] | [next] | [standalone]

#1572130 — Re: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings

FromGuochun Mao <guochun.mao@mediatek.com>
Date2017-02-02 04:30 +0100
SubjectRe: [PATCH v2 1/2] Documentation: mtk-quadspi: update DT bindings
Message-ID<t6gfT-6Gw-5@gated-at.bofh.it>
In reply to#1569715
On Mon, 2017-01-30 at 13:49 +0100, Cyrille Pitchen wrote:
> Le 27/01/2017 à 23:29, Rob Herring a écrit :
> > On Wed, Jan 25, 2017 at 11:38:34AM +0800, Guochun Mao wrote:
> >> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> >>
> >> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> >> ---
> >>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    8 +++++++-
> >>  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> Applied to the github spi-nor tree.
> 
> Thanks!

Thank you very much!

[toc] | [prev] | [next] | [standalone]

#1566309 — [PATCH v2 2/2] arm: dts: mt2701: add nor flash node

FromGuochun Mao <guochun.mao@mediatek.com>
Date2017-01-25 04:40 +0100
Subject[PATCH v2 2/2] arm: dts: mt2701: add nor flash node
Message-ID<t3mBb-4RB-7@gated-at.bofh.it>
In reply to#1566306
Add Mediatek nor flash node.

Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
---
 arch/arm/boot/dts/mt2701-evb.dts |   25 +++++++++++++++++++++++++
 arch/arm/boot/dts/mt2701.dtsi    |   12 ++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
index 082ca88..85e5ae8 100644
--- a/arch/arm/boot/dts/mt2701-evb.dts
+++ b/arch/arm/boot/dts/mt2701-evb.dts
@@ -24,6 +24,31 @@
 	};
 };
 
+&nor_flash {
+	pinctrl-names = "default";
+	pinctrl-0 = <&nor_pins_default>;
+	status = "okay";
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+	};
+};
+
+&pio {
+	nor_pins_default: nor {
+		pins1 {
+			pinmux = <MT2701_PIN_240_EXT_XCS__FUNC_EXT_XCS>,
+				 <MT2701_PIN_241_EXT_SCK__FUNC_EXT_SCK>,
+				 <MT2701_PIN_239_EXT_SDIO0__FUNC_EXT_SDIO0>,
+				 <MT2701_PIN_238_EXT_SDIO1__FUNC_EXT_SDIO1>,
+				 <MT2701_PIN_237_EXT_SDIO2__FUNC_EXT_SDIO2>,
+				 <MT2701_PIN_236_EXT_SDIO3__FUNC_EXT_SDIO3>;
+			drive-strength = <MTK_DRIVE_4mA>;
+			bias-pull-up;
+		};
+	};
+};
+
 &uart0 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index bdf8954..1eefce4 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
+++ b/arch/arm/boot/dts/mt2701.dtsi
@@ -227,6 +227,18 @@
 		status = "disabled";
 	};
 
+	nor_flash: spi@11014000 {
+		compatible = "mediatek,mt2701-nor",
+			     "mediatek,mt8173-nor";
+		reg = <0 0x11014000 0 0xe0>;
+		clocks = <&pericfg CLK_PERI_FLASH>,
+			 <&topckgen CLK_TOP_FLASH_SEL>;
+		clock-names = "spi", "sf";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
 	mmsys: syscon@14000000 {
 		compatible = "mediatek,mt2701-mmsys", "syscon";
 		reg = <0 0x14000000 0 0x1000>;
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1573811 — Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node

FromGuochun Mao <guochun.mao@mediatek.com>
Date2017-02-05 05:20 +0100
SubjectRe: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node
Message-ID<t7msV-2iU-1@gated-at.bofh.it>
In reply to#1566309
On Wed, 2017-01-25 at 11:38 +0800, Guochun Mao wrote:
> Add Mediatek nor flash node.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  arch/arm/boot/dts/mt2701-evb.dts |   25 +++++++++++++++++++++++++
>  arch/arm/boot/dts/mt2701.dtsi    |   12 ++++++++++++
>  2 files changed, 37 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index 082ca88..85e5ae8 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -24,6 +24,31 @@
>  	};
>  };
>  
> +&nor_flash {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nor_pins_default>;
> +	status = "okay";
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0>;
> +	};
> +};
> +
> +&pio {
> +	nor_pins_default: nor {
> +		pins1 {
> +			pinmux = <MT2701_PIN_240_EXT_XCS__FUNC_EXT_XCS>,
> +				 <MT2701_PIN_241_EXT_SCK__FUNC_EXT_SCK>,
> +				 <MT2701_PIN_239_EXT_SDIO0__FUNC_EXT_SDIO0>,
> +				 <MT2701_PIN_238_EXT_SDIO1__FUNC_EXT_SDIO1>,
> +				 <MT2701_PIN_237_EXT_SDIO2__FUNC_EXT_SDIO2>,
> +				 <MT2701_PIN_236_EXT_SDIO3__FUNC_EXT_SDIO3>;
> +			drive-strength = <MTK_DRIVE_4mA>;
> +			bias-pull-up;
> +		};
> +	};
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index bdf8954..1eefce4 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -227,6 +227,18 @@
>  		status = "disabled";
>  	};
>  
> +	nor_flash: spi@11014000 {
> +		compatible = "mediatek,mt2701-nor",
> +			     "mediatek,mt8173-nor";
> +		reg = <0 0x11014000 0 0xe0>;
> +		clocks = <&pericfg CLK_PERI_FLASH>,
> +			 <&topckgen CLK_TOP_FLASH_SEL>;
> +		clock-names = "spi", "sf";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		status = "disabled";
> +	};
> +
>  	mmsys: syscon@14000000 {
>  		compatible = "mediatek,mt2701-mmsys", "syscon";
>  		reg = <0 0x14000000 0 0x1000>;

Hi,
mtk-quadspi.txt had been updated as suggested.
Is there suggestion about this patch?
Thanks.

BR,
Guochun

[toc] | [prev] | [next] | [standalone]

#1574425 — Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2017-02-06 08:50 +0100
SubjectRe: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node
Message-ID<t7MdH-1Vy-11@gated-at.bofh.it>
In reply to#1573811
Hi Guochun,

On Sun, 5 Feb 2017 12:00:49 +0800
Guochun Mao <guochun.mao@mediatek.com> wrote:


> >  
> > +	nor_flash: spi@11014000 {
> > +		compatible = "mediatek,mt2701-nor",
> > +			     "mediatek,mt8173-nor";
> > +		reg = <0 0x11014000 0 0xe0>;
> > +		clocks = <&pericfg CLK_PERI_FLASH>,
> > +			 <&topckgen CLK_TOP_FLASH_SEL>;
> > +		clock-names = "spi", "sf";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> > +
> >  	mmsys: syscon@14000000 {
> >  		compatible = "mediatek,mt2701-mmsys", "syscon";
> >  		reg = <0 0x14000000 0 0x1000>;  
> 
> Hi,
> mtk-quadspi.txt had been updated as suggested.
> Is there suggestion about this patch?

It should probably go through the Mediatek tree. Matthias, any opinion?

Regards,

Boris

[toc] | [prev] | [next] | [standalone]

#1579134 — Re: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node

FromMatthias Brugger <matthias.bgg@gmail.com>
Date2017-02-12 00:40 +0100
SubjectRe: [PATCH v2 2/2] arm: dts: mt2701: add nor flash node
Message-ID<t9PqO-75l-21@gated-at.bofh.it>
In reply to#1574425

On 02/06/2017 08:45 AM, Boris Brezillon wrote:
> Hi Guochun,
>
> On Sun, 5 Feb 2017 12:00:49 +0800
> Guochun Mao <guochun.mao@mediatek.com> wrote:
>
>
>>>
>>> +	nor_flash: spi@11014000 {
>>> +		compatible = "mediatek,mt2701-nor",
>>> +			     "mediatek,mt8173-nor";
>>> +		reg = <0 0x11014000 0 0xe0>;
>>> +		clocks = <&pericfg CLK_PERI_FLASH>,
>>> +			 <&topckgen CLK_TOP_FLASH_SEL>;
>>> +		clock-names = "spi", "sf";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +		status = "disabled";
>>> +	};
>>> +
>>>  	mmsys: syscon@14000000 {
>>>  		compatible = "mediatek,mt2701-mmsys", "syscon";
>>>  		reg = <0 0x14000000 0 0x1000>;
>>
>> Hi,
>> mtk-quadspi.txt had been updated as suggested.
>> Is there suggestion about this patch?
>
> It should probably go through the Mediatek tree. Matthias, any opinion?
>

Yes, I will take this one through mine tree.

Thanks,
Matthias

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web