Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569546 > unrolled thread

[PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes Ravikumar Kattekola <rk@ti.com> - 2017-01-30 11:20 +0100
    [PATCH 1/3] mmc: host: omap_hsmmc: reset cmd line on ceb error Ravikumar Kattekola <rk@ti.com> - 2017-01-30 11:20 +0100
    Re: [PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-31 11:20 +0100
      Re: [PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes Ravikumar <rk@ti.com> - 2017-01-31 11:40 +0100
        Re: [PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes Ulf Hansson <ulf.hansson@linaro.org> - 2017-01-31 12:00 +0100

#1569546 — [PATCH 0/3] mmc: host: omap_hsmmc: miscellaneous fixes

A few issues have been identified during mmc testing and following
set of patches fixes a couple of them related to
*timeout handling and ceb error handling*

Tested on DRA75X PG 2.0 Rev H EVM

Kishon Vijay Abraham I (1):
  mmc: host: omap_hsmmc: use generic_cmd6_time to program timeout value
    for CMD6

Ravikumar Kattekola (2):
  mmc: host: omap_hsmmc: reset cmd line on ceb error
  mmc: host: omap_hsmmc: avoid possible overflow of timeout value

 drivers/mmc/host/omap_hsmmc.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1569549 — [PATCH 1/3] mmc: host: omap_hsmmc: reset cmd line on ceb error

When CEB (command end bit error) occurs
reset CMD line to avoid system ending up in
erroneous state.
While command line is reset for CTO and CCRC errors,
it's not done for CEB error. Fix it here.

Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Ravikumar Kattekola <rk@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/mmc/host/omap_hsmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index ad11c4c..0ee5650 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1162,7 +1162,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host *host, int status)
 	if (status & ERR_EN) {
 		omap_hsmmc_dbg_report_irq(host, status);
 
-		if (status & (CTO_EN | CCRC_EN))
+		if (status & (CTO_EN | CCRC_EN | CEB_EN))
 			end_cmd = 1;
 		if (host->data || host->response_busy) {
 			end_trans = !end_cmd;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1570571

On 30 January 2017 at 11:11, Ravikumar Kattekola <rk@ti.com> wrote:
> A few issues have been identified during mmc testing and following
> set of patches fixes a couple of them related to
> *timeout handling and ceb error handling*
>
> Tested on DRA75X PG 2.0 Rev H EVM
>
> Kishon Vijay Abraham I (1):
>   mmc: host: omap_hsmmc: use generic_cmd6_time to program timeout value
>     for CMD6
>
> Ravikumar Kattekola (2):
>   mmc: host: omap_hsmmc: reset cmd line on ceb error
>   mmc: host: omap_hsmmc: avoid possible overflow of timeout value
>
>  drivers/mmc/host/omap_hsmmc.c | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
>
> --
> 1.9.1
>


Assuming that you target 4.10 rcs for this and you want me to add a stable tag?

Kind regards
Uffe

[toc] | [prev] | [next] | [standalone]

#1570582

On Tuesday 31 January 2017 03:45 PM, Ulf Hansson wrote:
> On 30 January 2017 at 11:11, Ravikumar Kattekola <rk@ti.com> wrote:
>> A few issues have been identified during mmc testing and following
>> set of patches fixes a couple of them related to
>> *timeout handling and ceb error handling*
>>
>> Tested on DRA75X PG 2.0 Rev H EVM
>>
>> Kishon Vijay Abraham I (1):
>>    mmc: host: omap_hsmmc: use generic_cmd6_time to program timeout value
>>      for CMD6
>>
>> Ravikumar Kattekola (2):
>>    mmc: host: omap_hsmmc: reset cmd line on ceb error
>>    mmc: host: omap_hsmmc: avoid possible overflow of timeout value
>>
>>   drivers/mmc/host/omap_hsmmc.c | 29 +++++++++++++++++++----------
>>   1 file changed, 19 insertions(+), 10 deletions(-)
>>
>> --
>> 1.9.1
>>
>
> Assuming that you target 4.10 rcs for this and you want me to add a stable tag?
These are not critical fixes so can be queued for next , go to 4.11.
> Kind regards
> Uffe
Thanks and Regards,
RK

[toc] | [prev] | [next] | [standalone]

#1570603

On 31 January 2017 at 11:34, Ravikumar <rk@ti.com> wrote:
>
>
> On Tuesday 31 January 2017 03:45 PM, Ulf Hansson wrote:
>>
>> On 30 January 2017 at 11:11, Ravikumar Kattekola <rk@ti.com> wrote:
>>>
>>> A few issues have been identified during mmc testing and following
>>> set of patches fixes a couple of them related to
>>> *timeout handling and ceb error handling*
>>>
>>> Tested on DRA75X PG 2.0 Rev H EVM
>>>
>>> Kishon Vijay Abraham I (1):
>>>    mmc: host: omap_hsmmc: use generic_cmd6_time to program timeout value
>>>      for CMD6
>>>
>>> Ravikumar Kattekola (2):
>>>    mmc: host: omap_hsmmc: reset cmd line on ceb error
>>>    mmc: host: omap_hsmmc: avoid possible overflow of timeout value
>>>
>>>   drivers/mmc/host/omap_hsmmc.c | 29 +++++++++++++++++++----------
>>>   1 file changed, 19 insertions(+), 10 deletions(-)
>>>
>>> --
>>> 1.9.1
>>>
>>
>> Assuming that you target 4.10 rcs for this and you want me to add a stable
>> tag?
>
> These are not critical fixes so can be queued for next , go to 4.11.

Thanks, applied for next!

Kind regards
Uffe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web