Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1569335 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2017-01-30 02:50 +0100 |
| Last post | 2017-01-30 07:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
linux-next: build failure after merge of the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-01-30 02:50 +0100
Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2017-01-30 03:00 +0100
Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2017-01-30 04:10 +0100
Re: linux-next: build failure after merge of the block tree Christoph Hellwig <hch@lst.de> - 2017-01-30 07:50 +0100
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2017-01-30 02:50 +0100 |
| Subject | linux-next: build failure after merge of the block tree |
| Message-ID | <t59gt-6em-1@gated-at.bofh.it> |
Hi Jens,
After merging the block tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/nvme/host/scsi.c: In function 'nvme_scsi_translate':
drivers/nvme/host/scsi.c:2350:9: error: 'BLK_MAX_CDB' undeclared (first use in this function)
u8 cmd[BLK_MAX_CDB];
^
drivers/nvme/host/scsi.c:2350:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/nvme/host/scsi.c:2350:5: warning: unused variable 'cmd' [-Wunused-variable]
u8 cmd[BLK_MAX_CDB];
^
drivers/nvme/host/scsi.c: In function 'nvme_sg_io':
drivers/nvme/host/scsi.c:2454:20: error: 'BLK_MAX_CDB' undeclared (first use in this function)
if (hdr.cmd_len > BLK_MAX_CDB)
^
Caused by commit
82ed4db499b8 ("block: split scsi_request out of struct request")
I have used the block tree from next-20170125 for today.
--
Cheers,
Stephen Rothwell
[toc] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2017-01-30 03:00 +0100 |
| Message-ID | <t59q9-6hP-1@gated-at.bofh.it> |
| In reply to | #1569335 |
On 01/29/2017 06:43 PM, Stephen Rothwell wrote:
> Hi Jens,
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/nvme/host/scsi.c: In function 'nvme_scsi_translate':
> drivers/nvme/host/scsi.c:2350:9: error: 'BLK_MAX_CDB' undeclared (first use in this function)
> u8 cmd[BLK_MAX_CDB];
> ^
> drivers/nvme/host/scsi.c:2350:9: note: each undeclared identifier is reported only once for each function it appears in
> drivers/nvme/host/scsi.c:2350:5: warning: unused variable 'cmd' [-Wunused-variable]
> u8 cmd[BLK_MAX_CDB];
> ^
> drivers/nvme/host/scsi.c: In function 'nvme_sg_io':
> drivers/nvme/host/scsi.c:2454:20: error: 'BLK_MAX_CDB' undeclared (first use in this function)
> if (hdr.cmd_len > BLK_MAX_CDB)
> ^
>
> Caused by commit
>
> 82ed4db499b8 ("block: split scsi_request out of struct request")
>
> I have used the block tree from next-20170125 for today.
Huh, I wonder how that snuck past my allmodconfig builds, that looks
like a clear failure.
--
Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Jens Axboe <axboe@kernel.dk> |
|---|---|
| Date | 2017-01-30 04:10 +0100 |
| Message-ID | <t5avU-77b-5@gated-at.bofh.it> |
| In reply to | #1569341 |
On 01/29/2017 06:53 PM, Jens Axboe wrote:
> On 01/29/2017 06:43 PM, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/nvme/host/scsi.c: In function 'nvme_scsi_translate':
>> drivers/nvme/host/scsi.c:2350:9: error: 'BLK_MAX_CDB' undeclared (first use in this function)
>> u8 cmd[BLK_MAX_CDB];
>> ^
>> drivers/nvme/host/scsi.c:2350:9: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/nvme/host/scsi.c:2350:5: warning: unused variable 'cmd' [-Wunused-variable]
>> u8 cmd[BLK_MAX_CDB];
>> ^
>> drivers/nvme/host/scsi.c: In function 'nvme_sg_io':
>> drivers/nvme/host/scsi.c:2454:20: error: 'BLK_MAX_CDB' undeclared (first use in this function)
>> if (hdr.cmd_len > BLK_MAX_CDB)
>> ^
>>
>> Caused by commit
>>
>> 82ed4db499b8 ("block: split scsi_request out of struct request")
>>
>> I have used the block tree from next-20170125 for today.
>
> Huh, I wonder how that snuck past my allmodconfig builds, that looks
> like a clear failure.
Fixed, sorry about that.
--
Jens Axboe
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-01-30 07:50 +0100 |
| Message-ID | <t5dWO-EH-3@gated-at.bofh.it> |
| In reply to | #1569341 |
On Sun, Jan 29, 2017 at 06:53:42PM -0700, Jens Axboe wrote: > Huh, I wonder how that snuck past my allmodconfig builds, that looks > like a clear failure. I also did tons of test builds and never saw it, not sure why the NVMe-SCSI code still someone how an implicit include of scsi_cmnd.h. But in the end it should not be using the defintion anyway, and I sent a patch on Saturday so that it doesn't: [PATCH 1/5] nvme/scsi: don't rely on BLK_MAX_CDB might make sense to expedite that.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web