Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570800 > unrolled thread

[PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-01-31 15:50 +0100
    Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in  hex Lee Jones <lee.jones@linaro.org> - 2017-02-08 11:30 +0100
      Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in  hex Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-08 13:10 +0100
        Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in  hex Lee Jones <lee.jones@linaro.org> - 2017-02-08 14:00 +0100

#1570800 — [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex

Register addresses are normally displayed in hex throughout the Arizona
driver. Update the arizona_poll_reg function to follow this convention.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index e00f577..4cb34c3 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
 	for (i = 0; i < timeout; i++) {
 		ret = regmap_read(arizona->regmap, reg, &val);
 		if (ret != 0) {
-			dev_err(arizona->dev, "Failed to read reg %u: %d\n",
+			dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
 				reg, ret);
 			continue;
 		}
@@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona,
 		usleep_range(1000, 5000);
 	}
 
-	dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
+	dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
 	return -ETIMEDOUT;
 }
 
-- 
2.1.4

[toc] | [next] | [standalone]

#1576419 — Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex

On Tue, 31 Jan 2017, Charles Keepax wrote:

> Register addresses are normally displayed in hex throughout the Arizona
> driver. Update the arizona_poll_reg function to follow this convention.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
  
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index e00f577..4cb34c3 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
>  	for (i = 0; i < timeout; i++) {
>  		ret = regmap_read(arizona->regmap, reg, &val);
>  		if (ret != 0) {
> -			dev_err(arizona->dev, "Failed to read reg %u: %d\n",
> +			dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
>  				reg, ret);
>  			continue;
>  		}
> @@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona,
>  		usleep_range(1000, 5000);
>  	}
>  
> -	dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
> +	dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
>  	return -ETIMEDOUT;
>  }
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1576496 — Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex

On Wed, Feb 08, 2017 at 10:20:56AM +0000, Lee Jones wrote:
> On Tue, 31 Jan 2017, Charles Keepax wrote:
> 
> > Register addresses are normally displayed in hex throughout the Arizona
> > driver. Update the arizona_poll_reg function to follow this convention.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > ---
> >  drivers/mfd/arizona-core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> For my own reference:
>   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>   

Apologies but I am not sure do you want me to add these tags to
new versions of the patches? I would with a regular Acked-by, but
didn't with your last version of these.

Thanks,
Charles

[toc] | [prev] | [next] | [standalone]

#1576532 — Re: [PATCH RESEND 2/4] mfd: arizona: Display register addresses in hex

On Wed, 08 Feb 2017, Charles Keepax wrote:

> On Wed, Feb 08, 2017 at 10:20:56AM +0000, Lee Jones wrote:
> > On Tue, 31 Jan 2017, Charles Keepax wrote:
> > 
> > > Register addresses are normally displayed in hex throughout the Arizona
> > > driver. Update the arizona_poll_reg function to follow this convention.
> > > 
> > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > > ---
> > >  drivers/mfd/arizona-core.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > For my own reference:
> >   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> >   
> 
> Apologies but I am not sure do you want me to add these tags to
> new versions of the patches? I would with a regular Acked-by, but
> didn't with your last version of these.

That tag is to let people (including myself) know that I have reviewed
the patch, it looks fine and I will be taking it in via the MFD tree
once all other Acks have been collected.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web