Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1570778 > unrolled thread

[PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:

Started byMaksymilian Piechota <maksymilianpiechota@gmail.com>
First post2017-01-31 15:30 +0100
Last post2017-02-03 11:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl  warning: Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-01-31 15:30 +0100
    Re: [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl  warning: Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-03 11:00 +0100

#1570778 — [PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-01-31 15:30 +0100
Subject[PATCH v2] staging: wlan-ng: This patch fixes the checkpatch.pl warning:
Message-ID<t5HBv-1Ll-3@gated-at.bofh.it>
Fix checkpatch.pl warning:

WARNING: Statements should start on a tabstop

V2: whole if statement cleared up

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 2d67125..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,10 +1307,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
-		} else
-			if ((msg->wlanheader.status ==
-			 P80211ENUM_msgitem_status_data_ok)
-			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
+		} else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
+			   (msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else {
-- 
2.1.4

[toc] | [next] | [standalone]


#1572986

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-02-03 11:00 +0100
Message-ID<t6IOT-8nh-49@gated-at.bofh.it>
In reply to#1570778
On Tue, Jan 31, 2017 at 09:20:15AM -0500, Maksymilian Piechota wrote:
> Fix checkpatch.pl warning:

Your subject is odd, it leaves something to the imagination :(

> 
> WARNING: Statements should start on a tabstop
> 
> V2: whole if statement cleared up

Put this below the --- line.

v3?

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web