Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570623 > unrolled thread

[PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded Taeung Song <treeze.taeung@gmail.com> - 2017-01-31 12:40 +0100
    Re: [PATCH v2 4/4] perf tools: Increase index if  perf_evsel__new_idx() succeeded Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-31 14:30 +0100
      Re: [PATCH v2 4/4] perf tools: Increase index if  perf_evsel__new_idx() succeeded Taeung Song <treeze.taeung@gmail.com> - 2017-02-01 09:10 +0100

#1570623 — [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/util/parse-events.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 87a3e5a..ac47c12 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -311,10 +311,11 @@ __add_event(struct list_head *list, int *idx,
 
 	event_attr_init(attr);
 
-	evsel = perf_evsel__new_idx(attr, (*idx)++);
+	evsel = perf_evsel__new_idx(attr, *idx);
 	if (!evsel)
 		return NULL;
 
+	(*idx)++;
 	evsel->cpus     = cpu_map__get(cpus);
 	evsel->own_cpus = cpu_map__get(cpus);
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1570742 — Re: [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded

Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu:
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>

The title of this patch is misleading, ambiguous. It leads one to have
doubt if we were not incrementing that index before and now we are,
after successfully calling perf_evsel__new_idx().

It should have been:

  "perf tools: Only increase index if perf_evsel__new_idx() succeeds"

- Arnaldo

> ---
>  tools/perf/util/parse-events.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 87a3e5a..ac47c12 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -311,10 +311,11 @@ __add_event(struct list_head *list, int *idx,
>  
>  	event_attr_init(attr);
>  
> -	evsel = perf_evsel__new_idx(attr, (*idx)++);
> +	evsel = perf_evsel__new_idx(attr, *idx);
>  	if (!evsel)
>  		return NULL;
>  
> +	(*idx)++;
>  	evsel->cpus     = cpu_map__get(cpus);
>  	evsel->own_cpus = cpu_map__get(cpus);
>  
> -- 
> 2.7.4

[toc] | [prev] | [next] | [standalone]

#1571315 — Re: [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded

On 01/31/2017 10:25 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu:
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>
> The title of this patch is misleading, ambiguous. It leads one to have
> doubt if we were not incrementing that index before and now we are,
> after successfully calling perf_evsel__new_idx().
>
> It should have been:
>
>   "perf tools: Only increase index if perf_evsel__new_idx() succeeds"
>

Understood!
I'll change the title!

Thanks,
Taeung

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web