Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1570505 > unrolled thread

[PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2017-01-31 10:30 +0100
Last post2017-01-31 11:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-01-31 10:30 +0100
    Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-01-31 11:10 +0100

#1570505 — [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2017-01-31 10:30 +0100
Subject[PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL
Message-ID<t5CVb-7pw-3@gated-at.bofh.it>
As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
else.
This patch replace ENOSYS by the more appropriate value EINVAL.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index eff6282..485b1cd 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -353,7 +353,7 @@ void stmmac_remove_config_dt(struct platform_device *pdev,
 struct plat_stmmacenet_data *
 stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
 {
-	return ERR_PTR(-ENOSYS);
+	return ERR_PTR(-EINVAL);
 }
 
 void stmmac_remove_config_dt(struct platform_device *pdev,
-- 
2.10.2

[toc] | [next] | [standalone]


#1570545

FromGiuseppe CAVALLARO <peppe.cavallaro@st.com>
Date2017-01-31 11:10 +0100
Message-ID<t5DxU-7RQ-15@gated-at.bofh.it>
In reply to#1570505
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing
> else.
> This patch replace ENOSYS by the more appropriate value EINVAL.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index eff6282..485b1cd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -353,7 +353,7 @@ void stmmac_remove_config_dt(struct platform_device *pdev,
>  struct plat_stmmacenet_data *
>  stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return ERR_PTR(-EINVAL);
>  }
>
>  void stmmac_remove_config_dt(struct platform_device *pdev,
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web