Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568230 > unrolled thread

[PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 12:50 +0100
    Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Stefan Wahren <stefan.wahren@i2se.com> - 2017-01-30 22:40 +0100
      Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Gerd Hoffmann <kraxel@redhat.com> - 2017-01-31 09:20 +0100
      Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Eric Anholt <eric@anholt.net> - 2017-01-31 19:50 +0100
        Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Gerd Hoffmann <kraxel@redhat.com> - 2017-02-01 12:10 +0100
    Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Rob Herring <robh@kernel.org> - 2017-02-01 16:10 +0100
      Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost. Gerd Hoffmann <kraxel@redhat.com> - 2017-02-01 17:00 +0100

#1568230 — [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

From: Eric Anholt <eric@anholt.net>

This is the other SD controller on the platform, which can be swapped
to the role of SD card host using pin muxing.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 .../bindings/mmc/brcm,bcm2835-sdhost.txt           | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt

diff --git a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
new file mode 100644
index 0000000..f9f5982
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
@@ -0,0 +1,24 @@
+Broadcom BCM2835 SDHOST controller
+
+This file documents differences between the core properties described
+by mmc.txt and the properties that represent the BCM2835 controller.
+
+Required properties:
+- compatible: Should be "brcm,bcm2835-sdhost".
+- clocks: The clock feeding the SDHOST controller.
+
+Optional properties:
+- dmas: DMA channels for read and write.
+          See Documentation/devicetree/bindings/dma/dma.txt for details
+
+Example:
+
+sdhost: sdhost@7e202000 {
+	compatible = "brcm,bcm2835-sdhost";
+	reg = <0x7e202000 0x100>;
+	interrupts = <2 24>;
+	clocks = <&clocks BCM2835_CLOCK_VPU>;
+	dmas = <&dma 13>,
+	       <&dma 13>;
+	dma-names = "tx", "rx";
+};
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1570126

> Gerd Hoffmann <kraxel@redhat.com> hat am 27. Januar 2017 um 12:36 geschrieben:
> 
> 
> From: Eric Anholt <eric@anholt.net>
> 
> This is the other SD controller on the platform, which can be swapped
> to the role of SD card host using pin muxing.

AFAIK the SDHOST controller isn't able to handle SDIO. Maybe we should mention this in the binding document.

[toc] | [prev] | [next] | [standalone]

#1570475

On Mo, 2017-01-30 at 22:37 +0100, Stefan Wahren wrote:
> > Gerd Hoffmann <kraxel@redhat.com> hat am 27. Januar 2017 um 12:36 geschrieben:
> > 
> > 
> > From: Eric Anholt <eric@anholt.net>
> > 
> > This is the other SD controller on the platform, which can be swapped
> > to the role of SD card host using pin muxing.
> 
> AFAIK the SDHOST controller isn't able to handle SDIO. Maybe we should
> mention this in the binding document.

Hmm, I think the driver commit message and the Kconfig help text are
better places for that.

cheers,
  Gerd

[toc] | [prev] | [next] | [standalone]

#1570991

[Multipart message — attachments visible in raw view] — view raw

Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Gerd Hoffmann <kraxel@redhat.com> hat am 27. Januar 2017 um 12:36 geschrieben:
>> 
>> 
>> From: Eric Anholt <eric@anholt.net>
>> 
>> This is the other SD controller on the platform, which can be swapped
>> to the role of SD card host using pin muxing.
>
> AFAIK the SDHOST controller isn't able to handle SDIO. Maybe we should mention this in the binding document.

The binding should be documentation of the binding.  I'd love to see
more explanation in the mmc/host/bcm2835.c, though.

[toc] | [prev] | [next] | [standalone]

#1571484

  Hi,

> The binding should be documentation of the binding.  I'd love to see
> more explanation in the mmc/host/bcm2835.c, though.

Updated both mmc/host/bcm2835.c comment and Kconfig entry now.

cheers,
  Gerd

[toc] | [prev] | [next] | [standalone]

#1571639

On Fri, Jan 27, 2017 at 12:36:26PM +0100, Gerd Hoffmann wrote:
> From: Eric Anholt <eric@anholt.net>
> 
> This is the other SD controller on the platform, which can be swapped
> to the role of SD card host using pin muxing.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>  .../bindings/mmc/brcm,bcm2835-sdhost.txt           | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> 
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> new file mode 100644
> index 0000000..f9f5982
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt
> @@ -0,0 +1,24 @@
> +Broadcom BCM2835 SDHOST controller
> +
> +This file documents differences between the core properties described
> +by mmc.txt and the properties that represent the BCM2835 controller.
> +
> +Required properties:
> +- compatible: Should be "brcm,bcm2835-sdhost".
> +- clocks: The clock feeding the SDHOST controller.
> +
> +Optional properties:
> +- dmas: DMA channels for read and write.
> +          See Documentation/devicetree/bindings/dma/dma.txt for details
> +
> +Example:
> +
> +sdhost: sdhost@7e202000 {

Node names should be the generic type of device, so:

mmc@...

With that,

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1571677

> > +++ b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhost.txt

> > +Example:
> > +
> > +sdhost: sdhost@7e202000 {
> 
> Node names should be the generic type of device, so:
> 
> mmc@...

Ok, done.

I guess arch/arm/boot/dts/bcm283x.dtsi should get the same update?

cheers,
  Gerd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web