Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1568854 > unrolled thread

Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

Started byGreg KH <gregkh@linuxfoundation.org>
First post2017-01-28 10:20 +0100
Last post2017-01-29 20:00 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not  necessary braces {} Greg KH <gregkh@linuxfoundation.org> - 2017-01-28 10:20 +0100
    Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {} Bjørn Mork <bjorn@mork.no> - 2017-01-29 17:50 +0100
      Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not  necessary braces {} martinowar <martinowar@gmail.com> - 2017-01-29 20:00 +0100

#1568854 — Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-01-28 10:20 +0100
SubjectRe: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
Message-ID<t4xkR-7W5-1@gated-at.bofh.it>
On Sat, Jan 28, 2017 at 10:49:10AM +0200, Martin Karamihov wrote:
> Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> ---
> checkpatch fixes: remove not necessary braces

{sigh}

Please take some time, and go read Documentation/SubmittingPatches.
Then wait a day, review the patches that other people send out, and then
compose your patch to match the requirements and what you see other
people do.

good luck!

greg k-h

[toc] | [next] | [standalone]


#1569230 — Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}

FromBjørn Mork <bjorn@mork.no>
Date2017-01-29 17:50 +0100
SubjectRe: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
Message-ID<t50PT-Ye-7@gated-at.bofh.it>
In reply to#1568854
Greg KH <gregkh@linuxfoundation.org> writes:

> Please take some time, and go read Documentation/SubmittingPatches.

That's quickly done nowadays:

 bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
 This file has moved to process/submitting-patches.rst


I don't know why it was necessary to move that file, but it looks like
you, and the gazillion links and references to this document, just have
to adopt to a new location.

Or submit a patch to fix it :)



Bjørn

[toc] | [prev] | [next] | [standalone]


#1569263

Frommartinowar <martinowar@gmail.com>
Date2017-01-29 20:00 +0100
Message-ID<t52RI-2cH-13@gated-at.bofh.it>
In reply to#1569230
On 01/29/2017 06:43 PM, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
>> Please take some time, and go read Documentation/SubmittingPatches.
> That's quickly done nowadays:
>
>   bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches
>   This file has moved to process/submitting-patches.rst
>
>
> I don't know why it was necessary to move that file, but it looks like
> you, and the gazillion links and references to this document, just have
> to adopt to a new location.
>
> Or submit a patch to fix it :)
>
>
>
> Bjørn

Hi all,


Sorry for the noise and thank you for the polite dialogue. Another 
eudyptula participant here, you guess :) I will try to figure out my 
mistakes and will send the patch again.


Martin

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web