Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1565820 > unrolled thread
| Started by | Gideon Israel Dsouza <gidisrael@gmail.com> |
|---|---|
| First post | 2017-01-24 13:20 +0100 |
| Last post | 2017-01-27 19:00 +0100 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza <gidisrael@gmail.com> - 2017-01-24 13:20 +0100
Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Joe Perches <joe@perches.com> - 2017-01-25 03:00 +0100
Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute "Gideon D'souza" <gidisrael@gmail.com> - 2017-01-25 06:00 +0100
Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute "Gideon D'souza" <gidisrael@gmail.com> - 2017-01-27 14:40 +0100
Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Joe Perches <joe@perches.com> - 2017-01-27 15:00 +0100
Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute "Gideon D'souza" <gidisrael@gmail.com> - 2017-01-27 19:00 +0100
| From | Gideon Israel Dsouza <gidisrael@gmail.com> |
|---|---|
| Date | 2017-01-24 13:20 +0100 |
| Subject | [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute |
| Message-ID | <t38eR-4bB-13@gated-at.bofh.it> |
Added __mode(x) into compiler-gcc.h as part of a cleanup task I've taken up, to replace gcc specific attributes with macros. Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: crypto: Replaced gcc specific attributes with macros from compiler.h The last commit of this task that went through you: 52f5684c8e1ec kernel: use macros from compiler.h instead of __attribute__((...)) The next patch is for cleaning up the m68k subsystem and it requires a new macro to wrap __attribute__ ((mode (...))) Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com> --- include/linux/compiler-gcc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 0444b13..f1b1cfe 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -121,6 +121,7 @@ #define __attribute_const__ __attribute__((__const__)) #define __maybe_unused __attribute__((unused)) #define __always_unused __attribute__((unused)) +#define __mode __attribute__((mode(x))) /* gcc version specific checks */ -- 2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-01-25 03:00 +0100 |
| Message-ID | <t3l2p-3Hq-5@gated-at.bofh.it> |
| In reply to | #1565820 |
On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've > taken up, to replace gcc specific attributes with macros. > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: > crypto: Replaced gcc specific attributes with macros from compiler.h > > The last commit of this task that went through you: 52f5684c8e1ec > kernel: use macros from compiler.h instead of __attribute__((...)) > > The next patch is for cleaning up the m68k subsystem and it requires > a new macro to wrap __attribute__ ((mode (...))) [] > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h [] > @@ -121,6 +121,7 @@ > #define __attribute_const__ __attribute__((__const__)) > #define __maybe_unused __attribute__((unused)) > #define __always_unused __attribute__((unused)) > +#define __mode __attribute__((mode(x))) Huh? Perhaps you meant #define __mode(x) __attribute__((mode(x))) ?
[toc] | [prev] | [next] | [standalone]
| From | "Gideon D'souza" <gidisrael@gmail.com> |
|---|---|
| Date | 2017-01-25 06:00 +0100 |
| Message-ID | <t3nQB-5Be-7@gated-at.bofh.it> |
| In reply to | #1566272 |
>#define __mode(x) __attribute__((mode(x))) Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this. On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote: > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: >> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've >> taken up, to replace gcc specific attributes with macros. >> >> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: >> crypto: Replaced gcc specific attributes with macros from compiler.h >> >> The last commit of this task that went through you: 52f5684c8e1ec >> kernel: use macros from compiler.h instead of __attribute__((...)) >> >> The next patch is for cleaning up the m68k subsystem and it requires >> a new macro to wrap __attribute__ ((mode (...))) > [] >> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > [] >> @@ -121,6 +121,7 @@ >> #define __attribute_const__ __attribute__((__const__)) >> #define __maybe_unused __attribute__((unused)) >> #define __always_unused __attribute__((unused)) >> +#define __mode __attribute__((mode(x))) > > Huh? > > Perhaps you meant > > #define __mode(x) __attribute__((mode(x))) > > ? >
[toc] | [prev] | [next] | [standalone]
| From | "Gideon D'souza" <gidisrael@gmail.com> |
|---|---|
| Date | 2017-01-27 14:40 +0100 |
| Message-ID | <t4eUW-4Ja-23@gated-at.bofh.it> |
| In reply to | #1566323 |
Ok, I noticed this went into Andrew's tree and is now in linux-next, should I resend it? On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote: >>#define __mode(x) __attribute__((mode(x))) > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this. > > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote: >> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: >>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've >>> taken up, to replace gcc specific attributes with macros. >>> >>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: >>> crypto: Replaced gcc specific attributes with macros from compiler.h >>> >>> The last commit of this task that went through you: 52f5684c8e1ec >>> kernel: use macros from compiler.h instead of __attribute__((...)) >>> >>> The next patch is for cleaning up the m68k subsystem and it requires >>> a new macro to wrap __attribute__ ((mode (...))) >> [] >>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h >> [] >>> @@ -121,6 +121,7 @@ >>> #define __attribute_const__ __attribute__((__const__)) >>> #define __maybe_unused __attribute__((unused)) >>> #define __always_unused __attribute__((unused)) >>> +#define __mode __attribute__((mode(x))) >> >> Huh? >> >> Perhaps you meant >> >> #define __mode(x) __attribute__((mode(x))) >> >> ? >>
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-01-27 15:00 +0100 |
| Message-ID | <t4feh-4Q7-3@gated-at.bofh.it> |
| In reply to | #1568359 |
On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote: > Ok, I noticed this went into Andrew's tree and is now in linux-next, > should I resend it? Please don't top post and perhaps Andrew can fix it up instead. Andrew, you need to change: #define __mode __attribute__((mode(x))) to #define __mode(x) __attribute__((mode(x))) thanks. > On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote: > > > #define __mode(x) __attribute__((mode(x))) > > > > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this. > > > > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote: > > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: > > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've > > > > taken up, to replace gcc specific attributes with macros. > > > > > > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: > > > > crypto: Replaced gcc specific attributes with macros from compiler.h > > > > > > > > The last commit of this task that went through you: 52f5684c8e1ec > > > > kernel: use macros from compiler.h instead of __attribute__((...)) > > > > > > > > The next patch is for cleaning up the m68k subsystem and it requires > > > > a new macro to wrap __attribute__ ((mode (...))) > > > > > > [] > > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > > > > > > [] > > > > @@ -121,6 +121,7 @@ > > > > #define __attribute_const__ __attribute__((__const__)) > > > > #define __maybe_unused __attribute__((unused)) > > > > #define __always_unused __attribute__((unused)) > > > > +#define __mode __attribute__((mode(x))) > > > > > > Huh? > > > > > > Perhaps you meant > > > > > > #define __mode(x) __attribute__((mode(x))) > > > > > > ? > > >
[toc] | [prev] | [next] | [standalone]
| From | "Gideon D'souza" <gidisrael@gmail.com> |
|---|---|
| Date | 2017-01-27 19:00 +0100 |
| Message-ID | <t4iYx-7cf-15@gated-at.bofh.it> |
| In reply to | #1568381 |
>Please don't top post and perhaps Andrew can fix it up instead. What do you mean when you say "top post" I shouldn't re-send it? On Fri, Jan 27, 2017 at 7:15 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote: >> Ok, I noticed this went into Andrew's tree and is now in linux-next, >> should I resend it? > > Please don't top post and perhaps Andrew can fix it up instead. > > Andrew, you need to change: > > #define __mode __attribute__((mode(x))) > > to > > #define __mode(x) __attribute__((mode(x))) > > thanks. > >> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote: >> > > #define __mode(x) __attribute__((mode(x))) >> > >> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this. >> > >> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote: >> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote: >> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've >> > > > taken up, to replace gcc specific attributes with macros. >> > > > >> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c: >> > > > crypto: Replaced gcc specific attributes with macros from compiler.h >> > > > >> > > > The last commit of this task that went through you: 52f5684c8e1ec >> > > > kernel: use macros from compiler.h instead of __attribute__((...)) >> > > > >> > > > The next patch is for cleaning up the m68k subsystem and it requires >> > > > a new macro to wrap __attribute__ ((mode (...))) >> > > >> > > [] >> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h >> > > >> > > [] >> > > > @@ -121,6 +121,7 @@ >> > > > #define __attribute_const__ __attribute__((__const__)) >> > > > #define __maybe_unused __attribute__((unused)) >> > > > #define __always_unused __attribute__((unused)) >> > > > +#define __mode __attribute__((mode(x))) >> > > >> > > Huh? >> > > >> > > Perhaps you meant >> > > >> > > #define __mode(x) __attribute__((mode(x))) >> > > >> > > ? >> > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web