Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568271 > unrolled thread

[PATCH] gpiolib: Fix a WARN_ON that can never trigger

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpiolib: Fix a WARN_ON that can never trigger Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-01-27 13:00 +0100

#1568271 — [PATCH] gpiolib: Fix a WARN_ON that can never trigger

"if (!x) WARN_ON(x)" can never trigger.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpio/gpiolib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 59d3d960ccd4..1e8bda36b73e 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1422,8 +1422,7 @@ void devm_gpiochip_remove(struct device *dev, struct gpio_chip *chip)
 
 	ret = devres_release(dev, devm_gpio_chip_release,
 			     devm_gpio_chip_match, chip);
-	if (!ret)
-		WARN_ON(ret);
+	WARN_ON(ret);
 }
 EXPORT_SYMBOL_GPL(devm_gpiochip_remove);
 
-- 
2.9.3

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web