Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567983 > unrolled thread

Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of pending queue

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of  pending queue Miklos Szeredi <miklos@szeredi.hu> - 2017-01-27 10:40 +0100
    Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of  pending queue Borislav Petkov <bp@alien8.de> - 2017-01-27 11:00 +0100
      Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of  pending queue Miklos Szeredi <miklos@szeredi.hu> - 2017-01-27 11:00 +0100

#1567983 — Re: [PATCH] fuse: clear FR_PENDING flag when moving requests out of pending queue

On Mon, Jan 16, 2017 at 6:57 PM, Borislav Petkov <bp@alien8.de> wrote:
> Hi,
>
> On Fri, Jan 13, 2017 at 12:13:04PM +0100, Miklos Szeredi wrote:
>> On Thu, Jan 12, 2017 at 9:04 PM, Tahsin Erdogan <tahsin@google.com> wrote:
>> > fuse_abort_conn() moves requests from pending list to a temporary list
>> > before canceling them. This operation races with request_wait_answer()
>> > which also tries to remove the request after it gets a fatal signal. It
>> > checks FR_PENDING flag to determine whether the request is still in the
>> > pending list.
>> >
>> > Make fuse_abort_conn() clear FR_PENDING flag so that request_wait_answer()
>> > does not remove the request from temporary list.
>> >
>> > This bug manifests itself as a panic that looks like this:
>>
>> Perfect patch; applied and pushed.
>
> I'm seeing something similar here while the grub OS prober checks the
> other partitions. It is not always reproducible, I saw it only twice so
> far.
>
> Related?
>
> [  568.562174] ntfs: driver 2.1.32 [Flags: R/W MODULE].
> [  568.575436] fuse init (API version 7.26)
> [  568.707737] general protection fault: 0000 [#1] PREEMPT SMP


Doesn't look related.

"general protection fault" doesn't tell much about what happened.
Can't even tell which address was guilty.

Do you still have the vmlinux for this?  Or better yet, fs/fuse/dev.o?

Thanks,
Miklos

[toc] | [next] | [standalone]

#1567995

On Fri, Jan 27, 2017 at 10:35:26AM +0100, Miklos Szeredi wrote:
> Do you still have the vmlinux for this?  Or better yet, fs/fuse/dev.o?

Not really.

But I haven't been able to reproduce since and I was bisecting then. My
current guess is that perhaps there were some stale objects involved in
the build.

I'll ping you if I see it again.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [next] | [standalone]

#1567996

On Fri, Jan 27, 2017 at 10:50 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Jan 27, 2017 at 10:35:26AM +0100, Miklos Szeredi wrote:
>> Do you still have the vmlinux for this?  Or better yet, fs/fuse/dev.o?
>
> Not really.
>
> But I haven't been able to reproduce since and I was bisecting then. My
> current guess is that perhaps there were some stale objects involved in
> the build.
>
> I'll ping you if I see it again.

Ok.  Thanks.

Miklos

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web