Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567888 > unrolled thread
| Started by | William Blough <devel@blough.us> |
|---|---|
| First post | 2017-01-27 05:30 +0100 |
| Last post | 2017-01-27 08:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: octeon-usb: Fix coding style issues William Blough <devel@blough.us> - 2017-01-27 05:30 +0100
Re: [PATCH] staging: octeon-usb: Fix coding style issues Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-27 08:30 +0100
| From | William Blough <devel@blough.us> |
|---|---|
| Date | 2017-01-27 05:30 +0100 |
| Subject | [PATCH] staging: octeon-usb: Fix coding style issues |
| Message-ID | <t46kG-7Y9-3@gated-at.bofh.it> |
Wrap lines that exceed 80 characters.
Signed-off-by: William Blough <devel@blough.us>
---
drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..6b86bfb 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
/* Disable all interrupts except CHHLTD */
hcintmsk.u32 = 0;
hcintmsk.s.chhltdmsk = 1;
- cvmx_usb_write_csr32(usb,
- CVMX_USBCX_HCINTMSKX(channel, usb->index),
- hcintmsk.u32);
+ cvmx_usb_write_csr32(
+ usb,
+ CVMX_USBCX_HCINTMSKX(
+ channel,
+ usb->index),
+ hcintmsk.u32);
usbc_hcchar.s.chdis = 1;
- cvmx_usb_write_csr32(usb,
- CVMX_USBCX_HCCHARX(channel, usb->index),
- usbc_hcchar.u32);
+ cvmx_usb_write_csr32(
+ usb,
+ CVMX_USBCX_HCCHARX(
+ channel,
+ usb->index),
+ usbc_hcchar.u32);
return 0;
} else if (usbc_hcint.s.xfercompl) {
/*
--
2.1.4
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-01-27 08:30 +0100 |
| Message-ID | <t498R-1e6-7@gated-at.bofh.it> |
| In reply to | #1567888 |
On Thu, Jan 26, 2017 at 10:46:02PM -0500, William Blough wrote:
> Wrap lines that exceed 80 characters.
>
> Signed-off-by: William Blough <devel@blough.us>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 9a7858a..6b86bfb 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2635,13 +2635,19 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
> /* Disable all interrupts except CHHLTD */
> hcintmsk.u32 = 0;
> hcintmsk.s.chhltdmsk = 1;
> - cvmx_usb_write_csr32(usb,
> - CVMX_USBCX_HCINTMSKX(channel, usb->index),
> - hcintmsk.u32);
> + cvmx_usb_write_csr32(
> + usb,
> + CVMX_USBCX_HCINTMSKX(
> + channel,
> + usb->index),
> + hcintmsk.u32);
> usbc_hcchar.s.chdis = 1;
> - cvmx_usb_write_csr32(usb,
> - CVMX_USBCX_HCCHARX(channel, usb->index),
> - usbc_hcchar.u32);
> + cvmx_usb_write_csr32(
> + usb,
> + CVMX_USBCX_HCCHARX(
> + channel,
> + usb->index),
> + usbc_hcchar.u32);
> return 0;
> } else if (usbc_hcint.s.xfercompl) {
> /*
That's horrid, the original code looks better, please leave it as-is.
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web