Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564446 > unrolled thread

[PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski <contact@paulk.fr> - 2017-01-22 17:00 +0100
    Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for  bq24735 charger Thierry Reding <thierry.reding@gmail.com> - 2017-01-25 12:10 +0100
      Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for  bq24735 charger Paul Kocialkowski <contact@paulk.fr> - 2017-01-25 12:10 +0100

#1564446 — [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

Nyan boards come with an embedded controller that controls when to
enable and disable the charge. Thus, it should not be left up to the
kernel to handle that.

Using the ti,external-control property allows specifying this use-case.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index ef430aa30152..5cf987b5401e 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -335,6 +335,7 @@
 					ti,ac-detect-gpios = <&gpio
 							TEGRA_GPIO(J, 0)
 							GPIO_ACTIVE_HIGH>;
+					ti,external-control;
 				};
 
 				battery: sbs-battery@b {
-- 
2.11.0

[toc] | [next] | [standalone]

#1566490 — Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

[Multipart message — attachments visible in raw view] — view raw

On Sun, Jan 22, 2017 at 04:47:49PM +0100, Paul Kocialkowski wrote:
> Nyan boards come with an embedded controller that controls when to
> enable and disable the charge. Thus, it should not be left up to the
> kernel to handle that.
> 
> Using the ti,external-control property allows specifying this use-case.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Is the ti,ac-detect-gpios property still useful in that case? I guess it
would still allow to monitor whether or not a charger is connected, even
if the EC determines that it shouldn't charge.

Anyway, I've applied this.

Thanks,
Thierry

[toc] | [prev] | [next] | [standalone]

#1566492 — Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

[Multipart message — attachments visible in raw view] — view raw

Le mercredi 25 janvier 2017 à 11:59 +0100, Thierry Reding a écrit :
> On Sun, Jan 22, 2017 at 04:47:49PM +0100, Paul Kocialkowski wrote:
> > Nyan boards come with an embedded controller that controls when to
> > enable and disable the charge. Thus, it should not be left up to the
> > kernel to handle that.
> > 
> > Using the ti,external-control property allows specifying this use-case.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Is the ti,ac-detect-gpios property still useful in that case? I guess it
> would still allow to monitor whether or not a charger is connected, even
> if the EC determines that it shouldn't charge.

Yes, this is mostly what the bq24735 is used for in nyan devices: reporting
connection and disconnection events.

> Anyway, I've applied this.

Thanks!

-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web