Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564444 > unrolled thread

[PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Paul Kocialkowski <contact@paulk.fr> - 2017-01-22 17:00 +0100
    Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Thierry Reding <thierry.reding@gmail.com> - 2017-01-25 12:10 +0100
      Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Jon Hunter <jonathanh@nvidia.com> - 2017-01-25 12:20 +0100
        Re: [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Thierry Reding <thierry.reding@gmail.com> - 2017-01-25 12:20 +0100

#1564444 — [PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index f12ece9b76a6..03eedf86dc48 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -1103,19 +1103,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

[toc] | [next] | [standalone]

#1566493

[Multipart message — attachments visible in raw view] — view raw

On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
> This corrects the pinmux for accessing the TPM over the i2c line.
> Thus, it allows correctly probing the module, that previously failed with i2c
> errors.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

I've applied an s/i2c/I2C/ in the commit message and applied this. Can
you also make sure that these changes go into the nyan-big configuration
of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
sync with the DTS.

Thanks,
Thierry

[0]: https://github.com/NVIDIA/tegra-pinmux-scripts

[toc] | [prev] | [next] | [standalone]

#1566506

On 25/01/17 11:06, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
>> This corrects the pinmux for accessing the TPM over the i2c line.
>> Thus, it allows correctly probing the module, that previously failed with i2c
>> errors.
>>
>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>> ---
>>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> I've applied an s/i2c/I2C/ in the commit message and applied this. Can
> you also make sure that these changes go into the nyan-big configuration
> of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
> sync with the DTS.
> 
> Thanks,
> Thierry
> 
> [0]: https://github.com/NVIDIA/tegra-pinmux-scripts

Looks like it has already been changed ...

https://github.com/NVIDIA/tegra-pinmux-scripts/commit/5049f75b3099515ffb7f064dcf23568c17aecb01

Jon

-- 
nvpublic

[toc] | [prev] | [next] | [standalone]

#1566507

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jan 25, 2017 at 11:10:56AM +0000, Jon Hunter wrote:
> 
> On 25/01/17 11:06, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> > 
> > On Sun, Jan 22, 2017 at 04:47:52PM +0100, Paul Kocialkowski wrote:
> >> This corrects the pinmux for accessing the TPM over the i2c line.
> >> Thus, it allows correctly probing the module, that previously failed with i2c
> >> errors.
> >>
> >> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >> ---
> >>  arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
> >>  1 file changed, 10 insertions(+), 10 deletions(-)
> > 
> > I've applied an s/i2c/I2C/ in the commit message and applied this. Can
> > you also make sure that these changes go into the nyan-big configuration
> > of the tegra-pinmux-scripts[0]? I know Stephen wants to keep those in
> > sync with the DTS.
> > 
> > Thanks,
> > Thierry
> > 
> > [0]: https://github.com/NVIDIA/tegra-pinmux-scripts
> 
> Looks like it has already been changed ...
> 
> https://github.com/NVIDIA/tegra-pinmux-scripts/commit/5049f75b3099515ffb7f064dcf23568c17aecb01

Excellent, no need for any further action then.

Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web