Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566062 > unrolled thread
| Started by | Paulo Zanoni <paulo.r.zanoni@intel.com> |
|---|---|
| First post | 2017-01-24 19:50 +0100 |
| Last post | 2017-01-25 12:40 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/gpu: GLK uses the same GMS values as SKL Paulo Zanoni <paulo.r.zanoni@intel.com> - 2017-01-24 19:50 +0100
Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL Ingo Molnar <mingo@kernel.org> - 2017-01-25 08:30 +0100
Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL Jani Nikula <jani.nikula@linux.intel.com> - 2017-01-25 12:40 +0100
Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL Ingo Molnar <mingo@kernel.org> - 2017-01-25 12:40 +0100
Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL Jani Nikula <jani.nikula@linux.intel.com> - 2017-01-25 12:40 +0100
| From | Paulo Zanoni <paulo.r.zanoni@intel.com> |
|---|---|
| Date | 2017-01-24 19:50 +0100 |
| Subject | [PATCH] x86/gpu: GLK uses the same GMS values as SKL |
| Message-ID | <t3eki-7Q2-19@gated-at.bofh.it> |
So don't forget to reserve its stolen memory bits.
Cc: Ingo Molnar <mingo@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: x86@kernel.org
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
arch/x86/kernel/early-quirks.c | 1 +
1 file changed, 1 insertion(+)
Found by code inspection. This is completely untested since I don't have
GLK hardware.
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 6a08e25..23c4f1c 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
INTEL_SKL_IDS(&gen9_early_ops),
INTEL_BXT_IDS(&gen9_early_ops),
INTEL_KBL_IDS(&gen9_early_ops),
+ INTEL_GLK_IDS(&gen9_early_ops),
};
static void __init
--
2.7.4
[toc] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-01-25 08:30 +0100 |
| Message-ID | <t3qbL-7cP-11@gated-at.bofh.it> |
| In reply to | #1566062 |
* Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> So don't forget to reserve its stolen memory bits.
>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: x86@kernel.org
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> arch/x86/kernel/early-quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Found by code inspection. This is completely untested since I don't have
> GLK hardware.
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index 6a08e25..23c4f1c 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> INTEL_SKL_IDS(&gen9_early_ops),
> INTEL_BXT_IDS(&gen9_early_ops),
> INTEL_KBL_IDS(&gen9_early_ops),
> + INTEL_GLK_IDS(&gen9_early_ops),
> };
There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
changes to the i915 GPU driver?
Thanks,
Ingo
[toc] | [prev] | [next] | [standalone]
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Date | 2017-01-25 12:40 +0100 |
| Subject | Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL |
| Message-ID | <t3u5H-1aO-5@gated-at.bofh.it> |
| In reply to | #1566358 |
On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>
>> So don't forget to reserve its stolen memory bits.
>>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Cc: x86@kernel.org
>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> ---
>> arch/x86/kernel/early-quirks.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Found by code inspection. This is completely untested since I don't have
>> GLK hardware.
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index 6a08e25..23c4f1c 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>> INTEL_SKL_IDS(&gen9_early_ops),
>> INTEL_BXT_IDS(&gen9_early_ops),
>> INTEL_KBL_IDS(&gen9_early_ops),
>> + INTEL_GLK_IDS(&gen9_early_ops),
>> };
>
> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
> changes to the i915 GPU driver?
It's in our -next. Ack for merging this through drm-intel along with the
deps?
BR,
Jani.
>
> Thanks,
>
> Ingo
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2017-01-25 12:40 +0100 |
| Subject | Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL |
| Message-ID | <t3u5H-1aO-3@gated-at.bofh.it> |
| In reply to | #1566515 |
* Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
> >> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >>
> >>> So don't forget to reserve its stolen memory bits.
> >>>
> >>> Cc: Ingo Molnar <mingo@kernel.org>
> >>> Cc: H. Peter Anvin <hpa@zytor.com>
> >>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Cc: x86@kernel.org
> >>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>> ---
> >>> arch/x86/kernel/early-quirks.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> Found by code inspection. This is completely untested since I don't have
> >>> GLK hardware.
> >>>
> >>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> >>> index 6a08e25..23c4f1c 100644
> >>> --- a/arch/x86/kernel/early-quirks.c
> >>> +++ b/arch/x86/kernel/early-quirks.c
> >>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
> >>> INTEL_SKL_IDS(&gen9_early_ops),
> >>> INTEL_BXT_IDS(&gen9_early_ops),
> >>> INTEL_KBL_IDS(&gen9_early_ops),
> >>> + INTEL_GLK_IDS(&gen9_early_ops),
> >>> };
> >>
> >> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
> >> changes to the i915 GPU driver?
> >
> > It's in our -next. Ack for merging this through drm-intel along with the
> > deps?
Yeah, LGTM:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
[toc] | [prev] | [next] | [standalone]
| From | Jani Nikula <jani.nikula@linux.intel.com> |
|---|---|
| Date | 2017-01-25 12:40 +0100 |
| Subject | Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL |
| Message-ID | <t3u5H-1aO-7@gated-at.bofh.it> |
| In reply to | #1566515 |
(Now without the typo in Daniel's address; apologies for the extra
noise.)
On Wed, 25 Jan 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Wed, 25 Jan 2017, Ingo Molnar <mingo@kernel.org> wrote:
>> * Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
>>
>>> So don't forget to reserve its stolen memory bits.
>>>
>>> Cc: Ingo Molnar <mingo@kernel.org>
>>> Cc: H. Peter Anvin <hpa@zytor.com>
>>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Cc: x86@kernel.org
>>> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>>> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> ---
>>> arch/x86/kernel/early-quirks.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> Found by code inspection. This is completely untested since I don't have
>>> GLK hardware.
>>>
>>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>>> index 6a08e25..23c4f1c 100644
>>> --- a/arch/x86/kernel/early-quirks.c
>>> +++ b/arch/x86/kernel/early-quirks.c
>>> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = {
>>> INTEL_SKL_IDS(&gen9_early_ops),
>>> INTEL_BXT_IDS(&gen9_early_ops),
>>> INTEL_KBL_IDS(&gen9_early_ops),
>>> + INTEL_GLK_IDS(&gen9_early_ops),
>>> };
>>
>> There's no INTEL_GLK_IDS() upstream - is there any dependency here on other
>> changes to the i915 GPU driver?
>
> It's in our -next. Ack for merging this through drm-intel along with the
> deps?
>
> BR,
> Jani.
>
>>
>> Thanks,
>>
>> Ingo
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web