Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564702 > unrolled thread

[PATCH net] r8152: don't execute runtime suspend if the tx is not empty

Back to article view | Back to linux.kernel

Contents

  [PATCH net] r8152: don't execute runtime suspend if the tx is not empty Hayes Wang <hayeswang@realtek.com> - 2017-01-23 07:20 +0100
    Re: [PATCH net] r8152: don't execute runtime suspend if the tx is  not empty David Miller <davem@davemloft.net> - 2017-01-24 19:40 +0100

#1564702 — [PATCH net] r8152: don't execute runtime suspend if the tx is not empty

Runtime suspend shouldn't be executed if the tx queue is not empty,
because the device is not idle.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0e99af0..e1466b4 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -32,7 +32,7 @@
 #define NETNEXT_VERSION		"08"
 
 /* Information for net */
-#define NET_VERSION		"6"
+#define NET_VERSION		"7"
 
 #define DRIVER_VERSION		"v1." NETNEXT_VERSION "." NET_VERSION
 #define DRIVER_AUTHOR "Realtek linux nic maintainers <nic_swsd@realtek.com>"
@@ -3574,6 +3574,8 @@ static bool delay_autosuspend(struct r8152 *tp)
 	 */
 	if (!sw_linking && tp->rtl_ops.in_nway(tp))
 		return true;
+	else if (!skb_queue_empty(&tp->tx_queue))
+		return true;
 	else
 		return false;
 }
-- 
2.7.4

[toc] | [next] | [standalone]

#1566052 — Re: [PATCH net] r8152: don't execute runtime suspend if the tx is not empty

From: Hayes Wang <hayeswang@realtek.com>
Date: Mon, 23 Jan 2017 14:18:43 +0800

> Runtime suspend shouldn't be executed if the tx queue is not empty,
> because the device is not idle.
> 
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>

Applied and queued up for -stable, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web