Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566037 > unrolled thread
| Started by | Augusto Mecking Caringi <augustocaringi@gmail.com> |
|---|---|
| First post | 2017-01-24 19:20 +0100 |
| Last post | 2017-01-24 21:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: storage: sddr09: Remove a set-but-not-used variable Augusto Mecking Caringi <augustocaringi@gmail.com> - 2017-01-24 19:20 +0100
Re: [PATCH] usb: storage: sddr09: Remove a set-but-not-used variable Alan Stern <stern@rowland.harvard.edu> - 2017-01-24 21:20 +0100
| From | Augusto Mecking Caringi <augustocaringi@gmail.com> |
|---|---|
| Date | 2017-01-24 19:20 +0100 |
| Subject | [PATCH] usb: storage: sddr09: Remove a set-but-not-used variable |
| Message-ID | <t3dRf-7Ga-1@gated-at.bofh.it> |
The 'isnew' variable in 'sddr09_write_lba' function is set but never
used.
This has been detected by building the driver with W=1:
drivers/usb/storage/sddr09.c: In function ‘sddr09_write_lba’:
drivers/usb/storage/sddr09.c:873:17: warning: variable ‘isnew’ set but
not used [-Wunused-but-set-variable]
int i, result, isnew;
^
Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
---
drivers/usb/storage/sddr09.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c
index 3aeaa53..44f8ffc 100644
--- a/drivers/usb/storage/sddr09.c
+++ b/drivers/usb/storage/sddr09.c
@@ -870,13 +870,12 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
unsigned int pagelen;
unsigned char *bptr, *cptr, *xptr;
unsigned char ecc[3];
- int i, result, isnew;
+ int i, result;
lbap = ((lba % 1000) << 1) | 0x1000;
if (parity[MSB_of(lbap) ^ LSB_of(lbap)])
lbap ^= 1;
pba = info->lba_to_pba[lba];
- isnew = 0;
if (pba == UNDEF) {
pba = sddr09_find_unused_pba(info, lba);
@@ -887,7 +886,6 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
}
info->pba_to_lba[pba] = lba;
info->lba_to_pba[lba] = pba;
- isnew = 1;
}
if (pba == 1) {
--
2.7.4
[toc] | [next] | [standalone]
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Date | 2017-01-24 21:20 +0100 |
| Message-ID | <t3fJs-po-141@gated-at.bofh.it> |
| In reply to | #1566037 |
On Tue, 24 Jan 2017, Augusto Mecking Caringi wrote:
> The 'isnew' variable in 'sddr09_write_lba' function is set but never
> used.
>
> This has been detected by building the driver with W=1:
>
> drivers/usb/storage/sddr09.c: In function ‘sddr09_write_lba’:
> drivers/usb/storage/sddr09.c:873:17: warning: variable ‘isnew’ set but
> not used [-Wunused-but-set-variable]
> int i, result, isnew;
> ^
>
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
> ---
> drivers/usb/storage/sddr09.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/storage/sddr09.c b/drivers/usb/storage/sddr09.c
> index 3aeaa53..44f8ffc 100644
> --- a/drivers/usb/storage/sddr09.c
> +++ b/drivers/usb/storage/sddr09.c
> @@ -870,13 +870,12 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
> unsigned int pagelen;
> unsigned char *bptr, *cptr, *xptr;
> unsigned char ecc[3];
> - int i, result, isnew;
> + int i, result;
>
> lbap = ((lba % 1000) << 1) | 0x1000;
> if (parity[MSB_of(lbap) ^ LSB_of(lbap)])
> lbap ^= 1;
> pba = info->lba_to_pba[lba];
> - isnew = 0;
>
> if (pba == UNDEF) {
> pba = sddr09_find_unused_pba(info, lba);
> @@ -887,7 +886,6 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
> }
> info->pba_to_lba[pba] = lba;
> info->lba_to_pba[lba] = pba;
> - isnew = 1;
> }
>
> if (pba == 1) {
Acked-by: Alan Stern <stern@rowland.harvard.edu>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web