Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563303 > unrolled thread

Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions Michael Ellerman <mpe@ellerman.id.au> - 2017-01-20 06:50 +0100
    Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note()  functions Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-24 19:10 +0100

#1563303 — Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions

Hari Bathini <hbathini@linux.vnet.ibm.com> writes:

> Get rid of multiple definitions of append_elf_note() & final_note()
> functions. Reuse these functions compiled under CONFIG_CRASH_CORE
> Also, define Elf_Word and use it instead of generic u32 or the more
> specific Elf64_Word.
>
> Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>
> ---
>
> Changes from v3:
> * Dropped hard-coded values and used DIV_ROUND_UP().
>
> Changes from v2:
> * Added a definition for Elf_Word.
> * Used IA64 version of append_elf_note() and final_note() functions.
>
>
>  arch/ia64/kernel/crash.c   |   22 ----------------------
>  include/linux/crash_core.h |    4 ++++
>  include/linux/elf.h        |    2 ++
>  kernel/crash_core.c        |   34 ++++++++++++++--------------------
>  kernel/kexec_core.c        |   28 ----------------------------
>  5 files changed, 20 insertions(+), 70 deletions(-)

Do the powerpc patches later in the series actually depend on this one?
Or is this just an unrelated cleanup?

As it is I can't merge the series until we at least get an ack on this
from the ia64 folks.

If you can just split this out as a separate patch that would make it a
lot easier to get the rest merged.

cheers

[toc] | [next] | [standalone]

#1566036 — Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions

On Friday 20 January 2017 11:17 AM, Michael Ellerman wrote:
> Hari Bathini <hbathini@linux.vnet.ibm.com> writes:
>
>> Get rid of multiple definitions of append_elf_note() & final_note()
>> functions. Reuse these functions compiled under CONFIG_CRASH_CORE
>> Also, define Elf_Word and use it instead of generic u32 or the more
>> specific Elf64_Word.
>>
>> Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>
>> ---
>>
>> Changes from v3:
>> * Dropped hard-coded values and used DIV_ROUND_UP().
>>
>> Changes from v2:
>> * Added a definition for Elf_Word.
>> * Used IA64 version of append_elf_note() and final_note() functions.
>>
>>
>>   arch/ia64/kernel/crash.c   |   22 ----------------------
>>   include/linux/crash_core.h |    4 ++++
>>   include/linux/elf.h        |    2 ++
>>   kernel/crash_core.c        |   34 ++++++++++++++--------------------
>>   kernel/kexec_core.c        |   28 ----------------------------
>>   5 files changed, 20 insertions(+), 70 deletions(-)
> Do the powerpc patches later in the series actually depend on this one?
> Or is this just an unrelated cleanup?
>
> As it is I can't merge the series until we at least get an ack on this
> from the ia64 folks.
>
> If you can just split this out as a separate patch that would make it a
> lot easier to get the rest merged.
>

Hi Michael,

append_elf_note() & final_note() functions were defined statically at 
three different places,
arch/powerpc/kernel/fadump.c being one of them. With my changes, I would 
need to add
a fourth static definition if I ignore this cleanup. So, I preferred to 
clean this up...

Let me ping IA64 folks one last time. Will do a respin without the 
cleanup if I don't get
any response from them by end of this week..

Thanks
Hari

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web