Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566965 > unrolled thread

Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log

Back to article view | Back to linux.kernel

Contents

  Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM  2.0 firmware event log Ken Goldman <kgold@linux.vnet.ibm.com> - 2017-01-25 22:30 +0100
    Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM  2.0 firmware event log Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-26 00:10 +0100
    Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs  support,for TPM 2.0 firmware event log Nayna <nayna@linux.vnet.ibm.com> - 2017-01-30 10:50 +0100

#1566965 — Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log

> You do not need to send a new patch set version as long as this
> one gets peer tested. And it needs to be tested without hacks
> like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to
> be peer tested to be more specific.
>
> For me the code itself looks good but I simply cannot take it in
> in the current situation.
>
> /Jarkko

Tested-by: Kenneth Goldman <kgold@linux.vnet.ibm.com>

I validated a firmware event log taken from a Power 8 against PCR 0-7 
values for the SHA-1 and SHA-256 banks from a Nuvoton TPM 2.0 chip on 
that same platform.

[toc] | [next] | [standalone]

#1567036

On Wed, Jan 25, 2017 at 04:22:45PM -0500, Ken Goldman wrote:
> > You do not need to send a new patch set version as long as this
> > one gets peer tested. And it needs to be tested without hacks
> > like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to
> > be peer tested to be more specific.
> > 
> > For me the code itself looks good but I simply cannot take it in
> > in the current situation.
> > 
> > /Jarkko
> 
> Tested-by: Kenneth Goldman <kgold@linux.vnet.ibm.com>
> 
> I validated a firmware event log taken from a Power 8 against PCR 0-7 values
> for the SHA-1 and SHA-256 banks from a Nuvoton TPM 2.0 chip on that same
> platform.

Thank you! I'll add this to the commit.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1569496 — Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log

> From: "Ken Goldman" <kgold@linux.vnet.ibm.com
> <mailto:kgold@linux.vnet.ibm.com>>
> Date: 26-Jan-2017 2:53 AM
> Subject: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs
> support,for TPM 2.0 firmware event log
> To: <linux-kernel@vger.kernel.org
> <mailto:linux-kernel@vger.kernel.org>>,
> <linux-security-module@vger.kernel.org
> <mailto:linux-security-module@vger.kernel.org>>,
> <tpmdd-devel@lists.sourceforge.net
> <mailto:tpmdd-devel@lists.sourceforge.net>>
> Cc:
>
>     You do not need to send a new patch set version as long as this
>     one gets peer tested. And it needs to be tested without hacks
>     like plumbing TCPA with TPM 2.0 in QEMU. OF code paths needs to
>     be peer tested to be more specific.
>
>     For me the code itself looks good but I simply cannot take it in
>     in the current situation.
>
>     /Jarkko
>
>
> Tested-by: Kenneth Goldman <kgold@linux.vnet.ibm.com
> <mailto:kgold@linux.vnet.ibm.com>>
>
> I validated a firmware event log taken from a Power 8 against PCR 0-7
> values for the SHA-1 and SHA-256 banks from a Nuvoton TPM 2.0 chip on
> that same platform.
>

Thank You Ken.

Jarkko, I hope now these patches can be accepted for 4.11.

Thanks & Regards,
    - Nayna


> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> <mailto:majordomo@vger.kernel.org>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> <http://vger.kernel.org/majordomo-info.html>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web