Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565858 > unrolled thread

[PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

Started byLee Jones <lee.jones@linaro.org>
First post2017-01-24 14:50 +0100
Last post2017-01-27 12:30 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups Lee Jones <lee.jones@linaro.org> - 2017-01-24 14:50 +0100
    Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new  Pinctrl groups Peter Griffin <peter.griffin@linaro.org> - 2017-01-25 13:00 +0100
      Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new  Pinctrl groups Lee Jones <lee.jones@linaro.org> - 2017-01-27 12:10 +0100
        Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new  Pinctrl groups Lee Jones <lee.jones@linaro.org> - 2017-01-27 12:30 +0100

#1565858 — [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

FromLee Jones <lee.jones@linaro.org>
Date2017-01-24 14:50 +0100
Subject[PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups
Message-ID<t39DY-4W7-17@gated-at.bofh.it>
Having just defined some new Pinctrl groups for when when HW flow-
control is {en,dis}abled, let's reference them for use within the
driver.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih407-family.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index c8b2944..9789978 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -222,8 +222,9 @@
 			compatible = "st,asc";
 			reg = <0x9830000 0x2c>;
 			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;
-			pinctrl-names = "default";
-			pinctrl-0 = <&pinctrl_serial0>;
+			pinctrl-names = "default", "manual-rts";
+			pinctrl-0 = <&pinctrl_serial0_flowctrl>;
+			pinctrl-1 = <&pinctrl_serial0>;
 			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
 
 			status = "disabled";
-- 
2.10.2

[toc] | [next] | [standalone]

#1566539 — Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

FromPeter Griffin <peter.griffin@linaro.org>
Date2017-01-25 13:00 +0100
SubjectRe: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups
Message-ID<t3up4-1i3-51@gated-at.bofh.it>
In reply to#1565858
Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Having just defined some new Pinctrl groups for when when HW flow-
> control is {en,dis}abled, let's reference them for use within the
> driver.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Same as previous comment, your enabling hw flow control for all
stih407 family boards. I've not checked the schematics for them
but as hw flow control is dependent on board wiring, IMO this
should be added in board specific file.

regards,

Peter.

> ---
>  arch/arm/boot/dts/stih407-family.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index c8b2944..9789978 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -222,8 +222,9 @@
>  			compatible = "st,asc";
>  			reg = <0x9830000 0x2c>;
>  			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;
> -			pinctrl-names = "default";
> -			pinctrl-0 = <&pinctrl_serial0>;
> +			pinctrl-names = "default", "manual-rts";
> +			pinctrl-0 = <&pinctrl_serial0_flowctrl>;
> +			pinctrl-1 = <&pinctrl_serial0>;
>  			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
>  
>  			status = "disabled";

[toc] | [prev] | [next] | [standalone]

#1568071 — Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

FromLee Jones <lee.jones@linaro.org>
Date2017-01-27 12:10 +0100
SubjectRe: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups
Message-ID<t4czM-3lb-19@gated-at.bofh.it>
In reply to#1566539
On Wed, 25 Jan 2017, Peter Griffin wrote:

> Hi Lee,
> 
> On Tue, 24 Jan 2017, Lee Jones wrote:
> 
> > Having just defined some new Pinctrl groups for when when HW flow-
> > control is {en,dis}abled, let's reference them for use within the
> > driver.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Same as previous comment, your enabling hw flow control for all
> stih407 family boards. I've not checked the schematics for them
> but as hw flow control is dependent on board wiring, IMO this
> should be added in board specific file.

Fair shout.

On the B2120 UART0 is hooked up to the Smart Card Reader.

Will fix.

> > ---
> >  arch/arm/boot/dts/stih407-family.dtsi | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> > index c8b2944..9789978 100644
> > --- a/arch/arm/boot/dts/stih407-family.dtsi
> > +++ b/arch/arm/boot/dts/stih407-family.dtsi
> > @@ -222,8 +222,9 @@
> >  			compatible = "st,asc";
> >  			reg = <0x9830000 0x2c>;
> >  			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;
> > -			pinctrl-names = "default";
> > -			pinctrl-0 = <&pinctrl_serial0>;
> > +			pinctrl-names = "default", "manual-rts";
> > +			pinctrl-0 = <&pinctrl_serial0_flowctrl>;
> > +			pinctrl-1 = <&pinctrl_serial0>;
> >  			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> >  
> >  			status = "disabled";

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1568161 — Re: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups

FromLee Jones <lee.jones@linaro.org>
Date2017-01-27 12:30 +0100
SubjectRe: [STLinux Kernel] [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups
Message-ID<t4cT9-3sv-35@gated-at.bofh.it>
In reply to#1568071
On Fri, 27 Jan 2017, Lee Jones wrote:

> On Wed, 25 Jan 2017, Peter Griffin wrote:
> 
> > Hi Lee,
> > 
> > On Tue, 24 Jan 2017, Lee Jones wrote:
> > 
> > > Having just defined some new Pinctrl groups for when when HW flow-
> > > control is {en,dis}abled, let's reference them for use within the
> > > driver.
> > > 
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > 
> > Same as previous comment, your enabling hw flow control for all
> > stih407 family boards. I've not checked the schematics for them
> > but as hw flow control is dependent on board wiring, IMO this
> > should be added in board specific file.
> 
> Fair shout.
> 
> On the B2120 UART0 is hooked up to the Smart Card Reader.
> 
> Will fix.

Actually, the comment above is in regards to the st,hw-flow-control
property [8/8].  The UART0 Pinctrl settings here are correct for all
supported STiH407-family boards.

Will not fix.

> > > ---
> > >  arch/arm/boot/dts/stih407-family.dtsi | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> > > index c8b2944..9789978 100644
> > > --- a/arch/arm/boot/dts/stih407-family.dtsi
> > > +++ b/arch/arm/boot/dts/stih407-family.dtsi
> > > @@ -222,8 +222,9 @@
> > >  			compatible = "st,asc";
> > >  			reg = <0x9830000 0x2c>;
> > >  			interrupts = <GIC_SPI 122 IRQ_TYPE_NONE>;
> > > -			pinctrl-names = "default";
> > > -			pinctrl-0 = <&pinctrl_serial0>;
> > > +			pinctrl-names = "default", "manual-rts";
> > > +			pinctrl-0 = <&pinctrl_serial0_flowctrl>;
> > > +			pinctrl-1 = <&pinctrl_serial0>;
> > >  			clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> > >  
> > >  			status = "disabled";
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web