Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564475 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2017-01-22 17:50 +0100 |
| Last post | 2017-01-22 19:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-01-22 17:50 +0100
Re: [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-22 19:20 +0100
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2017-01-22 17:50 +0100 |
| Subject | [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() |
| Message-ID | <t2tv3-36H-7@gated-at.bofh.it> |
From: Wei Yongjun <weiyongjun1@huawei.com> Fix to return error code -ENODEV from the of_find_compatible_node() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- arch/arm/mach-hisi/platmcpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c index a6c1176..f0fff21 100644 --- a/arch/arm/mach-hisi/platmcpm.c +++ b/arch/arm/mach-hisi/platmcpm.c @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void) &hip04_boot_method[0], 4); if (ret) goto err; + + ret = -ENODEV; np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl"); if (!np_sctl) goto err;
[toc] | [next] | [standalone]
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2017-01-22 19:20 +0100 |
| Subject | Re: [PATCH -next] ARM: 8641/1: treewide: fix error return code in hip04_smp_init() |
| Message-ID | <t2uUb-46y-45@gated-at.bofh.it> |
| In reply to | #1564475 |
What does this have to do with patch 8641/1
("ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol") ?
Your patch also isn't "treewide" either. Confused.
On Sun, Jan 22, 2017 at 04:41:28PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/arm/mach-hisi/platmcpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
> &hip04_boot_method[0], 4);
> if (ret)
> goto err;
> +
> + ret = -ENODEV;
> np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
> if (!np_sctl)
> goto err;
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web