Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564445 > unrolled thread

[PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c Paul Kocialkowski <contact@paulk.fr> - 2017-01-22 17:00 +0100
    Re: [PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c Thierry Reding <thierry.reding@gmail.com> - 2017-01-25 12:10 +0100

#1564445 — [PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

From: Jerome Coste <jerome.coste@etu.utc.fr>

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.
---
 arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
index aca0828115eb..9df25ca5ab83 100644
--- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
@@ -1100,19 +1100,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

[toc] | [next] | [standalone]

#1566491

[Multipart message — attachments visible in raw view] — view raw

On Sun, Jan 22, 2017 at 04:47:53PM +0100, Paul Kocialkowski wrote:
> From: Jerome Coste <jerome.coste@etu.utc.fr>
> 
> This corrects the pinmux for accessing the TPM over the i2c line.
> Thus, it allows correctly probing the module, that previously failed with i2c
> errors.

This is missing a Signed-off-by: from Jerome and you (since you
forwarded the patch). I've added those since I assume that that was
intended and your both willing to provide it.

Other than that, same substitution for "i2c" -> "I2C" as on 5/6, and
please also make sure this change gets into the pinmux configurations.

Thanks,
Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web