Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564317 > unrolled thread
| Started by | Zhou Chengming <zhouchengming1@huawei.com> |
|---|---|
| First post | 2017-01-22 08:30 +0100 |
| Last post | 2017-01-22 11:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] sched: Documentation: sched-rt-group: fix example error Zhou Chengming <zhouchengming1@huawei.com> - 2017-01-22 08:30 +0100
[tip:sched/core] sched/Documentation/sched-rt-group: Fix incorrect example tip-bot for Zhou Chengming <tipbot@zytor.com> - 2017-01-22 11:20 +0100
| From | Zhou Chengming <zhouchengming1@huawei.com> |
|---|---|
| Date | 2017-01-22 08:30 +0100 |
| Subject | [PATCH] sched: Documentation: sched-rt-group: fix example error |
| Message-ID | <t2kL7-6fw-9@gated-at.bofh.it> |
I feel that the example given in the document to show the possibility of task starvation of configurable period is wrong. The example says group A and B both have 50% bandwidth, and a while (1) loop in A will run for the full period of B and can starve B's tasks. So I think the runtime of group A should be 50000us, then the period and runtime of group B should be 50000us and 25000us. Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com> --- Documentation/scheduler/sched-rt-group.txt | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/scheduler/sched-rt-group.txt b/Documentation/scheduler/sched-rt-group.txt index a03f0d9..d8fce3e 100644 --- a/Documentation/scheduler/sched-rt-group.txt +++ b/Documentation/scheduler/sched-rt-group.txt @@ -158,11 +158,11 @@ as its prone to starvation without deadline scheduling. Consider two sibling groups A and B; both have 50% bandwidth, but A's period is twice the length of B's. -* group A: period=100000us, runtime=10000us - - this runs for 0.01s once every 0.1s +* group A: period=100000us, runtime=50000us + - this runs for 0.05s once every 0.1s -* group B: period= 50000us, runtime=10000us - - this runs for 0.01s twice every 0.1s (or once every 0.05 sec). +* group B: period= 50000us, runtime=25000us + - this runs for 0.025s twice every 0.1s (or once every 0.05 sec). This means that currently a while (1) loop in A will run for the full period of B and can starve B's tasks (assuming they are of lower priority) for a whole -- 1.7.7
[toc] | [next] | [standalone]
| From | tip-bot for Zhou Chengming <tipbot@zytor.com> |
|---|---|
| Date | 2017-01-22 11:20 +0100 |
| Subject | [tip:sched/core] sched/Documentation/sched-rt-group: Fix incorrect example |
| Message-ID | <t2npD-7Yy-5@gated-at.bofh.it> |
| In reply to | #1564317 |
Commit-ID: 3a09b8d45b3c05d49e581831de626927c37599f8 Gitweb: http://git.kernel.org/tip/3a09b8d45b3c05d49e581831de626927c37599f8 Author: Zhou Chengming <zhouchengming1@huawei.com> AuthorDate: Sun, 22 Jan 2017 15:22:35 +0800 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Sun, 22 Jan 2017 10:34:17 +0100 sched/Documentation/sched-rt-group: Fix incorrect example I feel that the example given in the document to show the possibility of task starvation of configurable period is wrong. The example says group A and B both have 50% bandwidth, and a while (1) loop in A will run for the full period of B and can starve B's tasks. So I think the runtime of group A should be 50000us, then the period and runtime of group B should be 50000us and 25000us. Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: corbet@lwn.net Cc: iamyooon@gmail.com Cc: linux-doc@vger.kernel.org Cc: lizefan@huawei.com Link: http://lkml.kernel.org/r/1485069755-44287-1-git-send-email-zhouchengming1@huawei.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- Documentation/scheduler/sched-rt-group.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/scheduler/sched-rt-group.txt b/Documentation/scheduler/sched-rt-group.txt index a03f0d9..d8fce3e 100644 --- a/Documentation/scheduler/sched-rt-group.txt +++ b/Documentation/scheduler/sched-rt-group.txt @@ -158,11 +158,11 @@ as its prone to starvation without deadline scheduling. Consider two sibling groups A and B; both have 50% bandwidth, but A's period is twice the length of B's. -* group A: period=100000us, runtime=10000us - - this runs for 0.01s once every 0.1s +* group A: period=100000us, runtime=50000us + - this runs for 0.05s once every 0.1s -* group B: period= 50000us, runtime=10000us - - this runs for 0.01s twice every 0.1s (or once every 0.05 sec). +* group B: period= 50000us, runtime=25000us + - this runs for 0.025s twice every 0.1s (or once every 0.05 sec). This means that currently a while (1) loop in A will run for the full period of B and can starve B's tasks (assuming they are of lower priority) for a whole
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web