Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1565014 > unrolled thread
| Started by | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| First post | 2017-01-23 15:50 +0100 |
| Last post | 2017-01-26 14:30 +0100 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-23 15:50 +0100
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Heiko Stübner <heiko@sntech.de> - 2017-01-23 18:20 +0100
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-23 18:30 +0100
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-23 19:00 +0100
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-26 12:10 +0100
Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-26 14:30 +0100
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2017-01-23 15:50 +0100 |
| Subject | Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer |
| Message-ID | <t2O6u-7EI-21@gated-at.bofh.it> |
On Wed, Dec 21, 2016 at 05:21:05PM +0300, Alexander Kochetkov wrote: > Hello Heiko, Daniel! > > Are there any reasons why the patches [1][2] are not applied yet into kernel? > How can I help in applying patches? Hi Alexander, sorry for the delay. Let me review them before taking the patchset. Heiko, can you have a look to them also ? Thanks. -- Daniel
[toc] | [next] | [standalone]
| From | Heiko Stübner <heiko@sntech.de> |
|---|---|
| Date | 2017-01-23 18:20 +0100 |
| Subject | Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer |
| Message-ID | <t2QrF-Nm-45@gated-at.bofh.it> |
| In reply to | #1565014 |
Am Montag, 23. Januar 2017, 15:47:44 CET schrieb Daniel Lezcano: > On Wed, Dec 21, 2016 at 05:21:05PM +0300, Alexander Kochetkov wrote: > > Hello Heiko, Daniel! > > > > Are there any reasons why the patches [1][2] are not applied yet into > > kernel? How can I help in applying patches? > > Hi Alexander, > > sorry for the delay. Let me review them before taking the patchset. > > Heiko, can you have a look to them also ? somehow this series moved down to much in my inbox, sorry. Devicetree changes look good, except where I commented. I guess it would be best (least intrusive) if I queue up the (then fixed) devicetree changes after you are satisfied with the code parts. I've also looked over the code changes again, test-build them and found the build error mentioned separately. Overall they look good though. Heiko
[toc] | [prev] | [next] | [standalone]
| From | Alexander Kochetkov <al.kochet@gmail.com> |
|---|---|
| Date | 2017-01-23 18:30 +0100 |
| Subject | Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer |
| Message-ID | <t2QBk-Qy-25@gated-at.bofh.it> |
| In reply to | #1565169 |
Heiko, Daniel, thanks a lot for review! I’ll send v5 series this week. Heiko, Daniel, may I add 'Reviewed-by:’ to patch series? Reviewed-by: Heiko Stübner <heiko@sntech.de> ? Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> ? Regards, Alexander. > 23 янв. 2017 г., в 20:12, Heiko Stübner <heiko@sntech.de> написал(а): > > Am Montag, 23. Januar 2017, 15:47:44 CET schrieb Daniel Lezcano: >> On Wed, Dec 21, 2016 at 05:21:05PM +0300, Alexander Kochetkov wrote: >>> Hello Heiko, Daniel! >>> >>> Are there any reasons why the patches [1][2] are not applied yet into >>> kernel? How can I help in applying patches? >> >> Hi Alexander, >> >> sorry for the delay. Let me review them before taking the patchset. >> >> Heiko, can you have a look to them also ? > > somehow this series moved down to much in my inbox, sorry. > > Devicetree changes look good, except where I commented. > I guess it would be best (least intrusive) if I queue up the (then fixed) > devicetree changes after you are satisfied with the code parts. > > I've also looked over the code changes again, test-build them and found the > build error mentioned separately. Overall they look good though. > > > Heiko
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2017-01-23 19:00 +0100 |
| Message-ID | <t2R4l-11t-9@gated-at.bofh.it> |
| In reply to | #1565179 |
On Mon, Jan 23, 2017 at 08:24:47PM +0300, Alexander Kochetkov wrote: > Heiko, Daniel, thanks a lot for review! > I’ll send v5 series this week. > > Heiko, Daniel, may I add 'Reviewed-by:’ to patch series? > > Reviewed-by: Heiko Stübner <heiko@sntech.de> ? > Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> ? > I will answer with the corresponding tag myself when you send the v5. Thanks. -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[toc] | [prev] | [next] | [standalone]
| From | Alexander Kochetkov <al.kochet@gmail.com> |
|---|---|
| Date | 2017-01-26 12:10 +0100 |
| Subject | Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer |
| Message-ID | <t3Q6d-6AJ-3@gated-at.bofh.it> |
| In reply to | #1565195 |
Hello Daniel! Sorry for bothering you. Just let you know that I sent v5 here: http://lists.infradead.org/pipermail/linux-rockchip/2017-January/thread.html#13812 Because previous series was somehow missed in your inbox. Heiko don’t want to add "Reviewed-by» to my patches. Could you please apply the patches without the tag. Let me know is all ok with series now? Or may be I have to do something else? Regards, Alexander. > 23 янв. 2017 г., в 20:57, Daniel Lezcano <daniel.lezcano@linaro.org> написал(а): > > On Mon, Jan 23, 2017 at 08:24:47PM +0300, Alexander Kochetkov wrote: >> Heiko, Daniel, thanks a lot for review! >> I’ll send v5 series this week. >> >> Heiko, Daniel, may I add 'Reviewed-by:’ to patch series? >> >> Reviewed-by: Heiko Stübner <heiko@sntech.de> ? >> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> ? >> > > I will answer with the corresponding tag myself when you send the v5. > > Thanks. > > -- Daniel > > -- > > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2017-01-26 14:30 +0100 |
| Message-ID | <t3ShH-7Vm-9@gated-at.bofh.it> |
| In reply to | #1567326 |
On Thu, Jan 26, 2017 at 02:08:45PM +0300, Alexander Kochetkov wrote: > Hello Daniel! > > Sorry for bothering you. Just let you know that I sent v5 here: > http://lists.infradead.org/pipermail/linux-rockchip/2017-January/thread.html#13812 > > Because previous series was somehow missed in your inbox. > > Heiko don’t want to add "Reviewed-by» to my patches. Could you please > apply the patches without the tag. > > Let me know is all ok with series now? Or may be I have to do something else? Alexander, I think you misinterpreted Heiko's comment. He just want to take the time to review the driver in details and add himself the reviewed-by tag which is usually the procedure. I have to review the driver also. Meanwile you can have a look at https://lkml.org/lkml/2017/1/25/236 -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web