Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1565110 > unrolled thread

Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device

Started byDaniel Lezcano <daniel.lezcano@linaro.org>
First post2017-01-23 17:30 +0100
Last post2017-01-23 17:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split  bc_timer into rk_timer and rk_clock_event_device Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-01-23 17:30 +0100
    Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov <al.kochet@gmail.com> - 2017-01-23 17:50 +0100

#1565110 — Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2017-01-23 17:30 +0100
SubjectRe: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
Message-ID<t2PFg-ge-9@gated-at.bofh.it>
On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote:
> The patch move ce field out of struct bc_timer into struct
> rk_clock_event_device and rename struct bc_timer to struct rk_timer.

Why ?

[toc] | [next] | [standalone]


#1565130 — Re: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device

FromAlexander Kochetkov <al.kochet@gmail.com>
Date2017-01-23 17:50 +0100
SubjectRe: [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
Message-ID<t2PYD-mQ-49@gated-at.bofh.it>
In reply to#1565110
Daniel, thanks for reviewing patches!

> 23 янв. 2017 г., в 19:26, Daniel Lezcano <daniel.lezcano@linaro.org> написал(а):
> 
> On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote:
>> The patch move ce field out of struct bc_timer into struct
>> rk_clock_event_device and rename struct bc_timer to struct rk_timer.
> 
> Why ?

Single rockchip timer can be either broadcast timer/clockevent (current implementation) or
clocksource (the one I’ve implemented in series). Both implementations based on
low level timer routines (rk_timer_disable, rk_timer_enable, rk_timer_update_counter, 
rk_timer_counter_read and so on). Both implementations use timers in different modes
(interrupts vs free running). In order to distinguish this concepts I tried to split
low level timer routines from bc_timer.

Otherwise I can place all needed clocksource filelds into 'struct bc_timer’ and rename 'struct bc_timer’
into 'struct rk_timer’. If this is more clear solution I can rewrite patches.

Alexander.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web