Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563103 > unrolled thread
| Started by | Denys Vlasenko <dvlasenk@redhat.com> |
|---|---|
| First post | 2017-01-19 22:30 +0100 |
| Last post | 2017-01-25 23:50 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko <dvlasenk@redhat.com> - 2017-01-19 22:30 +0100
Re: [PATCH] x86/crypto: fix %progbits -> @progbits Josh Poimboeuf <jpoimboe@redhat.com> - 2017-01-19 22:40 +0100
Re: [PATCH] x86/crypto: fix %progbits -> @progbits Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-23 16:10 +0100
Re: [PATCH] x86/crypto: fix %progbits -> @progbits "H. Peter Anvin" <hpa@zytor.com> - 2017-01-25 23:50 +0100
| From | Denys Vlasenko <dvlasenk@redhat.com> |
|---|---|
| Date | 2017-01-19 22:30 +0100 |
| Subject | [PATCH] x86/crypto: fix %progbits -> @progbits |
| Message-ID | <t1srn-6L9-1@gated-at.bofh.it> |
%progbits form is used on ARM (where @ is a comment char).
x86 consistently uses @progbits everywhere else.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Josh Poimboeuf <jpoimboe@redhat.com>
CC: Xiaodong Liu <xiaodong.liu@intel.com>
CC: Megha Dey <megha.dey@intel.com>
CC: George Spelvin <linux@horizon.com>
CC: linux-crypto@vger.kernel.org
CC: x86@kernel.org
CC: linux-kernel@vger.kernel.org
---
arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
index dc05f01..7a7de27 100644
--- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
+++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
@@ -312,7 +312,7 @@ do_return:
ret
ENDPROC(crc_pcl)
-.section .rodata, "a", %progbits
+.section .rodata, "a", @progbits
################################################################
## jump table Table is 129 entries x 2 bytes each
################################################################
--
2.9.2
[toc] | [next] | [standalone]
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Date | 2017-01-19 22:40 +0100 |
| Message-ID | <t1sB4-6OE-45@gated-at.bofh.it> |
| In reply to | #1563103 |
On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote: > %progbits form is used on ARM (where @ is a comment char). > > x86 consistently uses @progbits everywhere else. > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com> -- Josh
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2017-01-23 16:10 +0100 |
| Message-ID | <t2OpR-812-45@gated-at.bofh.it> |
| In reply to | #1563103 |
On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote: > %progbits form is used on ARM (where @ is a comment char). > > x86 consistently uses @progbits everywhere else. > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [next] | [standalone]
| From | "H. Peter Anvin" <hpa@zytor.com> |
|---|---|
| Date | 2017-01-25 23:50 +0100 |
| Message-ID | <t3Ey6-7NV-33@gated-at.bofh.it> |
| In reply to | #1563103 |
On 01/19/17 13:28, Denys Vlasenko wrote: > %progbits form is used on ARM (where @ is a comment char). > > x86 consistently uses @progbits everywhere else. However, it looks like %progbits works on all architectures (at least include/linux/init.h seems to imply so.) Perhaps a tree-wide replacement the other way would make more sense. Personally I would also like to see these parameters macroized, to keep someone from getting them wrong, just like we have __INIT, __INITRODATA etc already, we should just have plain __TEXT __DATA __BSS... -hpa
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web