Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564815 > unrolled thread
| Started by | Valentin Rothberg <valentinrothberg@gmail.com> |
|---|---|
| First post | 2017-01-23 10:40 +0100 |
| Last post | 2017-01-23 16:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
net: dsa: remaining references on NET_DSA_HWMON Valentin Rothberg <valentinrothberg@gmail.com> - 2017-01-23 10:40 +0100
Re: net: dsa: remaining references on NET_DSA_HWMON Andrew Lunn <andrew@lunn.ch> - 2017-01-23 16:20 +0100
| From | Valentin Rothberg <valentinrothberg@gmail.com> |
|---|---|
| Date | 2017-01-23 10:40 +0100 |
| Subject | net: dsa: remaining references on NET_DSA_HWMON |
| Message-ID | <t2Jgt-4GV-3@gated-at.bofh.it> |
Hi Andrew,
your commit cf1a56a4cf19 ("net: dsa: Remove hwmon support") has popped
up in today's linux-next. The commit removes all references on
NET_DSA_HWMON but the following:
Documentation/networking/dsa/dsa.txt:501:These callbacks are only
available if CONFIG_NET_DSA_HWMON is enabled:
include/net/dsa.h:181:#ifdef CONFIG_NET_DSA_HWMON
Is it on purpose?
Best regards,
Valentin
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2017-01-23 16:20 +0100 |
| Message-ID | <t2Ozx-84K-45@gated-at.bofh.it> |
| In reply to | #1564815 |
On Mon, Jan 23, 2017 at 10:31:12AM +0100, Valentin Rothberg wrote:
> Hi Andrew,
>
> your commit cf1a56a4cf19 ("net: dsa: Remove hwmon support") has popped
> up in today's linux-next. The commit removes all references on
> NET_DSA_HWMON but the following:
>
> Documentation/networking/dsa/dsa.txt:501:These callbacks are only
> available if CONFIG_NET_DSA_HWMON is enabled:
>
> include/net/dsa.h:181:#ifdef CONFIG_NET_DSA_HWMON
>
> Is it on purpose?
Hi Valentin
Nope, those should be cleaned up as well.
Thanks for pointing this out.
Andrew
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web