Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564149 > unrolled thread

[PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

Started byRask Ingemann Lambertsen <rask@formelder.dk>
First post2017-01-21 17:20 +0100
Last post2017-01-24 19:50 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of  dcdce Rask Ingemann Lambertsen <rask@formelder.dk> - 2017-01-21 17:20 +0100
    Re: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce Chen-Yu Tsai <wens@csie.org> - 2017-01-23 09:10 +0100
    Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-01-24 19:50 +0100

#1564149 — [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

FromRask Ingemann Lambertsen <rask@formelder.dk>
Date2017-01-21 17:20 +0100
Subject[PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce
Message-ID<t26yt-65K-3@gated-at.bofh.it>
A typo or copy-paste bug means that the register access intended for
regulator dcdce goes to dcdcb instead. This patch corrects it.

Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)
---

I have a board where dcdcb powers the DRAM, which I found running at 2.05 V
rather than 1.50 V. The bug was introduced nearly five months ago. Thanks
must go to Samsung for making DRAM chips which tolerate that sort of abuse.

 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index e6a512e..a3ade9e 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -272,7 +272,7 @@ static const struct regulator_desc axp806_regulators[] = {
 			64, AXP806_DCDCD_V_CTRL, 0x3f, AXP806_PWR_OUT_CTRL1,
 			BIT(3)),
 	AXP_DESC(AXP806, DCDCE, "dcdce", "vine", 1100, 3400, 100,
-		 AXP806_DCDCB_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
+		 AXP806_DCDCE_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
 	AXP_DESC(AXP806, ALDO1, "aldo1", "aldoin", 700, 3300, 100,
 		 AXP806_ALDO1_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(5)),
 	AXP_DESC(AXP806, ALDO2, "aldo2", "aldoin", 700, 3400, 100,
-- 
2.10.2

-- 
Rask Ingemann Lambertsen

[toc] | [next] | [standalone]


#1564752 — Re: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

FromChen-Yu Tsai <wens@csie.org>
Date2017-01-23 09:10 +0100
SubjectRe: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce
Message-ID<t2HRo-3Xz-35@gated-at.bofh.it>
In reply to#1564149
On Sun, Jan 22, 2017 at 12:11 AM, Rask Ingemann Lambertsen
<rask@formelder.dk> wrote:
> A typo or copy-paste bug means that the register access intended for
> regulator dcdce goes to dcdcb instead. This patch corrects it.
>
> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
> Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)

Acked-by: Chen-Yu Tsai <wens@csie.org>

Can we tag it for 4.9 stable?

Thanks

[toc] | [prev] | [next] | [standalone]


#1566066 — Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree

FromMark Brown <broonie@kernel.org>
Date2017-01-24 19:50 +0100
SubjectApplied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree
Message-ID<t3eki-7Q2-21@gated-at.bofh.it>
In reply to#1564149
The patch

   regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From d0e287a401d9acf67b75180b26e2d62b7d482652 Mon Sep 17 00:00:00 2001
From: Rask Ingemann Lambertsen <rask@formelder.dk>
Date: Sat, 21 Jan 2017 17:11:43 +0100
Subject: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of
 dcdce

A typo or copy-paste bug means that the register access intended for
regulator dcdce goes to dcdcb instead. This patch corrects it.

Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)
Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index e6a512ebeae2..a3ade9e4ef47 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -272,7 +272,7 @@ static const struct regulator_desc axp806_regulators[] = {
 			64, AXP806_DCDCD_V_CTRL, 0x3f, AXP806_PWR_OUT_CTRL1,
 			BIT(3)),
 	AXP_DESC(AXP806, DCDCE, "dcdce", "vine", 1100, 3400, 100,
-		 AXP806_DCDCB_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
+		 AXP806_DCDCE_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
 	AXP_DESC(AXP806, ALDO1, "aldo1", "aldoin", 700, 3300, 100,
 		 AXP806_ALDO1_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(5)),
 	AXP_DESC(AXP806, ALDO2, "aldo2", "aldoin", 700, 3400, 100,
-- 
2.11.0

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web