Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1560099 > unrolled thread

Re: [PATCH -next] drm/atomic: make release_crtc_commit() static

Started byGustavo Padovan <gustavo@padovan.org>
First post2017-01-16 22:40 +0100
Last post2017-01-23 09:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH -next] drm/atomic: make release_crtc_commit() static Gustavo Padovan <gustavo@padovan.org> - 2017-01-16 22:40 +0100
    Re: [PATCH -next] drm/atomic: make release_crtc_commit() static Daniel Vetter <daniel@ffwll.ch> - 2017-01-23 09:10 +0100

#1560099 — Re: [PATCH -next] drm/atomic: make release_crtc_commit() static

FromGustavo Padovan <gustavo@padovan.org>
Date2017-01-16 22:40 +0100
SubjectRe: [PATCH -next] drm/atomic: make release_crtc_commit() static
Message-ID<t0nar-6mU-59@gated-at.bofh.it>
Hi Wei,

2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
>  symbol 'release_crtc_commit' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo

[toc] | [next] | [standalone]


#1564751

FromDaniel Vetter <daniel@ffwll.ch>
Date2017-01-23 09:10 +0100
Message-ID<t2HRo-3Xz-33@gated-at.bofh.it>
In reply to#1560099
On Mon, Jan 16, 2017 at 07:36:27PM -0200, Gustavo Padovan wrote:
> Hi Wei,
> 
> 2017-01-12 Wei Yongjun <weiyj.lk@gmail.com>:
> 
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > Fixes the following sparse warning:
> > 
> > drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning:
> >  symbol 'release_crtc_commit' was not declared. Should it be static?
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> >  drivers/gpu/drm/drm_atomic_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Thanks for the patch, applied to drm-misc.

Gustavo, for next time around please just use your commit rights when
reviewing a simple patch like this :-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web