Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564723 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2017-01-23 08:20 +0100 |
| Last post | 2017-01-23 10:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code Jisheng Zhang <jszhang@marvell.com> - 2017-01-23 08:20 +0100
Re: [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code Peter Chen <hzpeterchen@gmail.com> - 2017-01-23 10:10 +0100
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2017-01-23 08:20 +0100 |
| Subject | [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code |
| Message-ID | <t2H51-3rt-23@gated-at.bofh.it> |
Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
device is also created by device tree, the default DMA mask should be
already set by of_dma_configure when the device are created. So delete
the redundant code at driver.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 4456d2cf80ff..d162cc0bb8ce 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
}
}
- ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
- if (ret)
- goto clk_err;
-
ci_pdata->name = dev_name(dev);
priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
--
2.11.0
[toc] | [next] | [standalone]
| From | Peter Chen <hzpeterchen@gmail.com> |
|---|---|
| Date | 2017-01-23 10:10 +0100 |
| Subject | Re: [RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code |
| Message-ID | <t2INs-4wN-29@gated-at.bofh.it> |
| In reply to | #1564723 |
On Mon, Jan 23, 2017 at 03:09:23PM +0800, Jisheng Zhang wrote:
> Similar as commit 2b2fe36def08 ("usb: chipidea: imx: delete the
> redundant setting default DMA mask code"), the ci_hdrc_usb2 platform
> device is also created by device tree, the default DMA mask should be
> already set by of_dma_configure when the device are created. So delete
> the redundant code at driver.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/chipidea/ci_hdrc_usb2.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
> index 4456d2cf80ff..d162cc0bb8ce 100644
> --- a/drivers/usb/chipidea/ci_hdrc_usb2.c
> +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
> @@ -74,10 +74,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
> }
> }
>
> - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
> - if (ret)
> - goto clk_err;
> -
> ci_pdata->name = dev_name(dev);
>
> priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource,
Applied, thanks.
--
Best Regards,
Peter Chen
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web