Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1564155 > unrolled thread
| Started by | John Keeping <john@metanate.com> |
|---|---|
| First post | 2017-01-21 17:40 +0100 |
| Last post | 2017-01-23 07:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 24/26] drm/rockchip: dw-mipi-dsi: support non-burst modes John Keeping <john@metanate.com> - 2017-01-21 17:40 +0100
Re: [PATCH v2 24/26] drm/rockchip: dw-mipi-dsi: support non-burst modes Chris Zhong <zyw@rock-chips.com> - 2017-01-23 07:20 +0100
| From | John Keeping <john@metanate.com> |
|---|---|
| Date | 2017-01-21 17:40 +0100 |
| Subject | [PATCH v2 24/26] drm/rockchip: dw-mipi-dsi: support non-burst modes |
| Message-ID | <t26RP-6cn-13@gated-at.bofh.it> |
Signed-off-by: John Keeping <john@metanate.com>
---
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index 2dafb17e31d2..881bb0c62ca5 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -82,6 +82,7 @@
#define FRAME_BTA_ACK BIT(14)
#define ENABLE_LOW_POWER (0x3f << 8)
#define ENABLE_LOW_POWER_MASK (0x3f << 8)
+#define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1
#define VID_MODE_TYPE_BURST_SYNC_PULSES 0x2
#define VID_MODE_TYPE_MASK 0x3
@@ -286,6 +287,7 @@ struct dw_mipi_dsi {
u32 format;
u16 input_div;
u16 feedback_div;
+ unsigned long mode_flags;
const struct dw_mipi_dsi_plat_data *pdata;
};
@@ -548,15 +550,10 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host,
return -EINVAL;
}
- if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) ||
- !(device->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) {
- dev_err(dsi->dev, "device mode is unsupported\n");
- return -EINVAL;
- }
-
dsi->lanes = device->lanes;
dsi->channel = device->channel;
dsi->format = device->format;
+ dsi->mode_flags = device->mode_flags;
dsi->panel = of_drm_find_panel(device->dev.of_node);
if (dsi->panel)
return drm_panel_attach(dsi->panel, &dsi->connector);
@@ -713,7 +710,12 @@ static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi)
{
u32 val;
- val = VID_MODE_TYPE_BURST_SYNC_PULSES | ENABLE_LOW_POWER;
+ val = ENABLE_LOW_POWER;
+
+ if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
+ val |= VID_MODE_TYPE_BURST_SYNC_PULSES;
+ else if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE))
+ val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS;
dsi_write(dsi, DSI_VID_MODE_CFG, val);
}
--
2.11.0.197.gb556de5.dirty
[toc] | [next] | [standalone]
| From | Chris Zhong <zyw@rock-chips.com> |
|---|---|
| Date | 2017-01-23 07:20 +0100 |
| Subject | Re: [PATCH v2 24/26] drm/rockchip: dw-mipi-dsi: support non-burst modes |
| Message-ID | <t2G8V-2T1-5@gated-at.bofh.it> |
| In reply to | #1564155 |
Reviewed-by: Chris Zhong <zyw@rock-chips.com>
On 01/22/2017 12:31 AM, John Keeping wrote:
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> Unchanged in v2
> ---
> drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> index 2dafb17e31d2..881bb0c62ca5 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -82,6 +82,7 @@
> #define FRAME_BTA_ACK BIT(14)
> #define ENABLE_LOW_POWER (0x3f << 8)
> #define ENABLE_LOW_POWER_MASK (0x3f << 8)
> +#define VID_MODE_TYPE_NON_BURST_SYNC_EVENTS 0x1
> #define VID_MODE_TYPE_BURST_SYNC_PULSES 0x2
> #define VID_MODE_TYPE_MASK 0x3
>
> @@ -286,6 +287,7 @@ struct dw_mipi_dsi {
> u32 format;
> u16 input_div;
> u16 feedback_div;
> + unsigned long mode_flags;
>
> const struct dw_mipi_dsi_plat_data *pdata;
> };
> @@ -548,15 +550,10 @@ static int dw_mipi_dsi_host_attach(struct mipi_dsi_host *host,
> return -EINVAL;
> }
>
> - if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) ||
> - !(device->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)) {
> - dev_err(dsi->dev, "device mode is unsupported\n");
> - return -EINVAL;
> - }
> -
> dsi->lanes = device->lanes;
> dsi->channel = device->channel;
> dsi->format = device->format;
> + dsi->mode_flags = device->mode_flags;
> dsi->panel = of_drm_find_panel(device->dev.of_node);
> if (dsi->panel)
> return drm_panel_attach(dsi->panel, &dsi->connector);
> @@ -713,7 +710,12 @@ static void dw_mipi_dsi_video_mode_config(struct dw_mipi_dsi *dsi)
> {
> u32 val;
>
> - val = VID_MODE_TYPE_BURST_SYNC_PULSES | ENABLE_LOW_POWER;
> + val = ENABLE_LOW_POWER;
> +
> + if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
> + val |= VID_MODE_TYPE_BURST_SYNC_PULSES;
> + else if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE))
> + val |= VID_MODE_TYPE_NON_BURST_SYNC_EVENTS;
>
> dsi_write(dsi, DSI_VID_MODE_CFG, val);
> }
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web