Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563666 > unrolled thread
| Started by | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| First post | 2017-01-20 15:40 +0100 |
| Last post | 2017-01-22 03:00 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] md/bitmap: use i_blocksize() Geliang Tang <geliangtang@gmail.com> - 2017-01-20 15:40 +0100
Re: [PATCH] md/bitmap: use i_blocksize() Coly Li <colyli@suse.de> - 2017-01-20 16:10 +0100
Re: [PATCH] md/bitmap: use i_blocksize() Shaohua Li <shli@kernel.org> - 2017-01-21 19:20 +0100
Re: [PATCH] md/bitmap: use i_blocksize() Geliang Tang <geliangtang@gmail.com> - 2017-01-22 03:00 +0100
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2017-01-20 15:40 +0100 |
| Subject | [PATCH] md/bitmap: use i_blocksize() |
| Message-ID | <t1Iwb-8q4-41@gated-at.bofh.it> |
Since i_blocksize() helper has been defined in fs.h, use it instead
of open-coding.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/md/bitmap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 9fb2cca..30b1b89 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -367,7 +367,7 @@ static int read_page(struct file *file, unsigned long index,
pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE,
(unsigned long long)index << PAGE_SHIFT);
- bh = alloc_page_buffers(page, 1<<inode->i_blkbits, 0);
+ bh = alloc_page_buffers(page, i_blocksize(inode), 0);
if (!bh) {
ret = -ENOMEM;
goto out;
@@ -385,10 +385,10 @@ static int read_page(struct file *file, unsigned long index,
goto out;
}
bh->b_bdev = inode->i_sb->s_bdev;
- if (count < (1<<inode->i_blkbits))
+ if (count < i_blocksize(inode))
count = 0;
else
- count -= (1<<inode->i_blkbits);
+ count -= i_blocksize(inode);
bh->b_end_io = end_bitmap_write;
bh->b_private = bitmap;
--
2.9.3
[toc] | [next] | [standalone]
| From | Coly Li <colyli@suse.de> |
|---|---|
| Date | 2017-01-20 16:10 +0100 |
| Message-ID | <t1IZd-oG-61@gated-at.bofh.it> |
| In reply to | #1563666 |
On 2017/1/20 下午10:29, Geliang Tang wrote:
> Since i_blocksize() helper has been defined in fs.h, use it instead
> of open-coding.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/md/bitmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 9fb2cca..30b1b89 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -367,7 +367,7 @@ static int read_page(struct file *file, unsigned long index,
> pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE,
> (unsigned long long)index << PAGE_SHIFT);
>
> - bh = alloc_page_buffers(page, 1<<inode->i_blkbits, 0);
> + bh = alloc_page_buffers(page, i_blocksize(inode), 0);
> if (!bh) {
> ret = -ENOMEM;
> goto out;
> @@ -385,10 +385,10 @@ static int read_page(struct file *file, unsigned long index,
> goto out;
> }
> bh->b_bdev = inode->i_sb->s_bdev;
> - if (count < (1<<inode->i_blkbits))
> + if (count < i_blocksize(inode))
> count = 0;
> else
> - count -= (1<<inode->i_blkbits);
> + count -= i_blocksize(inode);
>
> bh->b_end_io = end_bitmap_write;
> bh->b_private = bitmap;
>
Acked-by: Coly Li <colyli@suse.de>
I agree with this. Thanks.
Coly
[toc] | [prev] | [next] | [standalone]
| From | Shaohua Li <shli@kernel.org> |
|---|---|
| Date | 2017-01-21 19:20 +0100 |
| Message-ID | <t28qB-7cs-5@gated-at.bofh.it> |
| In reply to | #1563666 |
On Fri, Jan 20, 2017 at 10:29:52PM +0800, Geliang Tang wrote:
> Since i_blocksize() helper has been defined in fs.h, use it instead
> of open-coding.
which tree is this patch applied to? I can't find it in Linus's tree
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/md/bitmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 9fb2cca..30b1b89 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -367,7 +367,7 @@ static int read_page(struct file *file, unsigned long index,
> pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE,
> (unsigned long long)index << PAGE_SHIFT);
>
> - bh = alloc_page_buffers(page, 1<<inode->i_blkbits, 0);
> + bh = alloc_page_buffers(page, i_blocksize(inode), 0);
> if (!bh) {
> ret = -ENOMEM;
> goto out;
> @@ -385,10 +385,10 @@ static int read_page(struct file *file, unsigned long index,
> goto out;
> }
> bh->b_bdev = inode->i_sb->s_bdev;
> - if (count < (1<<inode->i_blkbits))
> + if (count < i_blocksize(inode))
> count = 0;
> else
> - count -= (1<<inode->i_blkbits);
> + count -= i_blocksize(inode);
>
> bh->b_end_io = end_bitmap_write;
> bh->b_private = bitmap;
> --
> 2.9.3
>
[toc] | [prev] | [next] | [standalone]
| From | Geliang Tang <geliangtang@gmail.com> |
|---|---|
| Date | 2017-01-22 03:00 +0100 |
| Message-ID | <t2fBM-2Nm-5@gated-at.bofh.it> |
| In reply to | #1564198 |
On Sat, Jan 21, 2017 at 10:13:07AM -0800, Shaohua Li wrote: > On Fri, Jan 20, 2017 at 10:29:52PM +0800, Geliang Tang wrote: > > Since i_blocksize() helper has been defined in fs.h, use it instead > > of open-coding. > > which tree is this patch applied to? I can't find it in Linus's tree > This patch is against the last linux-next tree, next-20170120. It depends on the patch '2651ed7 fs: add i_blocksize()' which isn't merged into Linus's tree yet. -Geliang
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web