Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560348 > unrolled thread

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for  SPT and newer Thorsten Leemhuis <linux@leemhuis.info> - 2017-01-17 09:40 +0100
    RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) <Mario.Limonciello@dell.com> - 2017-01-17 18:00 +0100
      Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) Greg KH <gregkh@linuxfoundation.org> - 2017-01-17 19:40 +0100
        RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) <Mario.Limonciello@dell.com> - 2017-01-17 20:00 +0100
          Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) Darren Hart <dvhart@infradead.org> - 2017-01-18 00:40 +0100
            RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) <Mario.Limonciello@dell.com> - 2017-01-21 00:20 +0100
              Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) Greg KH <gregkh@linuxfoundation.org> - 2017-01-21 10:20 +0100
                Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-21 13:00 +0100
                  Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) Greg KH <gregkh@linuxfoundation.org> - 2017-01-22 12:30 +0100
                RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) <Mario.Limonciello@dell.com> - 2017-01-24 21:30 +0100
              Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-22 10:50 +0100
                RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) <Mario.Limonciello@dell.com> - 2017-01-24 21:20 +0100
      Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:  bus: enable OS version only for SPT and newer) "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-18 03:20 +0100
        Re: Regression on Dell XPS13 Paul Menzel <pmenzel@molgen.mpg.de> - 2017-01-18 12:20 +0100
          Re: Regression on Dell XPS13 "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-18 12:40 +0100
    Re: Regression on Dell XPS13 Thorsten Leemhuis <linux@leemhuis.info> - 2017-01-17 18:40 +0100

#1560348 — Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Greg Kroah-Hartman wrote on 16.01.2017 12:05:
> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
>> > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT
>> > > and newer
>> > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote:
>> > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
>> > > > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
>> > > > > > On 01/11/17 15:12, Winkler, Tomas wrote:
>> > > > > > > > > On 01/11/17 10:24, Winkler, Tomas wrote:
>> > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler
>> > > wrote:
>> > > > > > > > > > > > On older platforms the command should be just ignored
>> > > > > > > > > > > > by the firmware but some older platforms misbehave so
>> > > > > > > > > > > > it's safer to send the command only if required.
>> > > > > > > > > > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s).
>> > > > > > > > > > What about Dell XPS13?
>> > > > > > > > > With Linus' master branch from today, and Greg's
>> > > > > > > > > char-misc-linus merged
>> > > > > > > > > (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there.
> […]
>> > > > > > I am currently bisecting to find the culprit. 13 steps will take
>> > > > > > some time though.
>> > > > > I can duplicate this on my laptop here as well :(
>> > > > Which system do you have?
>> > > A Dell XPS13, don't know what cpu type it is, here's the output of one cpu from
>> > > /proc/cpuinfo
> […]
>> > > model name	: Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz
>> > > > > Did you get anywhere with your bisection?
>> > > > Sorry, I replied to a different message with my status.
> > > You are close!  I'll try bisection tomorrow if I have some spare time.

Paul, did you get any closer? I have trouble finding time for a proper
bisection (it's a bit chaotic here right now :-/ )

>> > Greg,  is that same Laptop mode as Paul's, you've experience the issue on?
>> It's the same model name, but as this model has been shipped with many
>> different CPU versions over the years, I'm not sure if it is the exact
>> same one.

Gregs afaics is Skylake generation (XPS 13 (9350)), Paul and I have a
Kaby Lake (XPS 13 (9360)), which is one generation newer (Wifi is also
different; other components likely as well).

> Ok, 4.10-rc4 seems to have fixed this issue with me.  I don't know what
> it was, but I can't duplicate it anymore.

Good to hear.

> Paul, are you still having this issue?

Don't know about Paul, but I did a quick test with rc4 on my machine and
the issue is still there :-/

Ciao, Thorsten

[toc] | [next] | [standalone]

#1560820 — RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Hi Paul,

Thanks for raising this topic and including me.  
Suspend to Idle support in Linux as an alternative S3 on x86 is a new 
topic.  In all, I expected that some problems would arise as a result 
of this patch, and I hope they will spur interesting discussions and 
solutions.

Something that might not be immediately obvious is that by supporting
suspend to idle, new driver bugs are going to be identified for drivers
that don't properly put hardware into low enough power modes for the CPU
to go into the proper state.  Traditionally with S3 the BIOS would be responsible 
for powering devices down before S3 and back up when exiting S3.
This onus is now on the OS.

> -----Original Message-----
> From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
> Sent: Tuesday, January 17, 2017 8:34 AM
> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>; Limonciello, Mario
> <Mario_Limonciello@Dell.com>
> Cc: Thorsten Leemhuis <linux@leemhuis.info>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Tomas Winkler <tomas.winkler@intel.com>;
> Jan Niehusmann <jan@gondor.com>; Usyskin, Alexander
> <alexander.usyskin@intel.com>; linux-kernel@vger.kernel.org; Chen, Yu C
> <yu.c.chen@intel.com>; Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Daniel
> Blueman <daniel@quora.org>; Len Brown <len.brown@intel.com>; linux-
> pm@vger.kernel.org
> Subject: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus:
> enable OS version only for SPT and newer)
> 
> Dear Rafael, dear Mario,
> 
> 
> On 01/17/17 09:14, Thorsten Leemhuis wrote:
> > Greg Kroah-Hartman wrote on 16.01.2017 12:05:
> >> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
> >>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
> >>>>> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS
> >>>>> version only for SPT and newer On Sat, Jan 14, 2017 at 08:27:31PM
> >>>>> +0100, Paul Menzel wrote:
> >>>>>> On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
> >>>>>>> On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
> >>>>>>>> On 01/11/17 15:12, Winkler, Tomas wrote:
> >>>>>>>>>>> On 01/11/17 10:24, Winkler, Tomas wrote:
> >>>>>>>>>>>>> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler
> wrote:
> >>>>>>>>>>>>>> On older platforms the command should be just ignored
> by
> >>>>>>>>>>>>>> the firmware but some older platforms misbehave so it's
> >>>>>>>>>>>>>> safer to send the command only if required.
> >>>>>>>>>>>>> Thanks! This fixes suspend-to-ram for me (on a Thinkpad
> x201s).
> >>>>>>>>>>>> What about Dell XPS13?
> 
> There is a regression with Linux 4.10-rc{1,2,3} on the Intel Kaby Lake device
> Dell XPS13 (9360). Hitting the power button, the light of the power button
> never goes off. Pressing it again, nothing happen. Only pressing it like ten
> seconds the screen comes back for five seconds, and then it seems to try to
> suspend again.


When it's in suspend to idle, the EC will modify some behaviors that align
to vendor specifications.  These include both the power button and 
the power light.  Both are actually expected, but the power button is 
indicative of other problems in the stack that need work.  
Let me explain how it all works:

When in suspend to idle, if the power button is pressed only momentarily (~ <6s),
the EC sends a wakeup event to the firmware which sends it to the OS 
through an ACPI event to the Intel HID event filter driver (intel-hid).

If it's pressed for longer (~6-9 seconds) then an IRQ is triggered to wake up 
the system the traditional way through a power button press.

If the button is pressed for a very long time (~10+ seconds) then 
the system will be force powered off.

So in the <6s scenario, the intel-hid driver is responsible to receive the ACPI
event and process accordingly.  The maintainer has a patch ready for the intel-hid
portion of this work, but it's currently being reviewed by Intel to ensure it
can be legally submitted into the kernel.

After that patch is approved for disclosure, submitted and accepted, the other 
missing part is that the ACPI subsystem itself is frozen when in suspend to idle, 
so this event can't be received by intel-hid.  This part needs discussion on how to fix.

In the 6-9s scenario there are no problems as this is the traditional wakeup
(as you found).

> 
> >>>>>>>>>>> With Linus' master branch from today, and Greg's
> >>>>>>>>>>> char-misc-linus merged
> >>>>>>>>>>> (Merge: 807b93e995d1 546cf3ef9c92), the regression is still
> there.
> >> […]
> >>>>>>>> I am currently bisecting to find the culprit. 13 steps will
> >>>>>>>> take some time though.
> >>>>>>> I can duplicate this on my laptop here as well :(
> >>>>>> Which system do you have?
> >>>>> A Dell XPS13, don't know what cpu type it is, here's the output of
> >>>>> one cpu from /proc/cpuinfo
> >> […]
> >>>>> model name	: Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz
> >>>>>>> Did you get anywhere with your bisection?
> >>>>>> Sorry, I replied to a different message with my status.
> >>>> You are close!  I'll try bisection tomorrow if I have some spare time.
> >
> > Paul, did you get any closer? I have trouble finding time for a proper
> > bisection (it's a bit chaotic here right now :-/ )
> >
> >>>> Greg,  is that same Laptop mode as Paul's, you've experience the issue
> on?
> >>> It's the same model name, but as this model has been shipped with
> >>> many different CPU versions over the years, I'm not sure if it is
> >>> the exact same one.
> >
> > Gregs afaics is Skylake generation (XPS 13 (9350)), Paul and I have a
> > Kaby Lake (XPS 13 (9360)), which is one generation newer (Wifi is also
> > different; other components likely as well).
> >
> >> Ok, 4.10-rc4 seems to have fixed this issue with me.  I don't know
> >> what it was, but I can't duplicate it anymore.
> >
> > Good to hear.
> >
> >> Paul, are you still having this issue?
> >
> > Don't know about Paul, but I did a quick test with rc4 on my machine
> > and the issue is still there :-/
> 
> I didn’t test Linux 4.10-rc4 yet, but I completed the bisection.
> 
> ```
> 406e79385f3223d82272cf2be86bc95cd000a258 is the first bad commit commit
> 406e79385f3223d82272cf2be86bc95cd000a258
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date:   Mon Nov 21 22:45:40 2016 +0100
> 
>      PM / sleep: System sleep state selection interface rework
> 
>      There are systems in which the platform doesn't support any special
>      sleep states, so suspend-to-idle (PM_SUSPEND_FREEZE) is the only
>      available system sleep state.  However, some user space frameworks
>      only use the "mem" and (sometimes) "standby" sleep state labels, so
>      the users of those systems need to modify user space in order to be
>      able to use system suspend at all and that may be a pain in practice.
> 
>      Commit 0399d4db3edf (PM / sleep: Introduce command line argument for
>      sleep state enumeration) attempted to address this problem by adding
>      a command line argument to change the meaning of the "mem" string in
>      /sys/power/state to make it trigger suspend-to-idle (instead of
>      suspend-to-RAM).
> 
>      However, there also are systems in which the platform does support
>      special sleep states, but suspend-to-idle is the preferred one anyway
>      (it even may save more energy than the platform-provided sleep states
>      in some cases) and the above commit doesn't help in those cases.
> 
>      For this reason, rework the system sleep state selection interface
>      again (but preserve backwards compatibiliby).  Namely, add a new
>      sysfs file, /sys/power/mem_sleep, that will control the system
>      suspend mode triggered by writing "mem" to /sys/power/state (in
>      analogy with what /sys/power/disk does for hibernation).  Make it
>      select suspend-to-RAM ("deep" sleep) by default (if supported) and
>      fall back to suspend-to-idle ("s2idle") otherwise and add a new
>      command line argument, mem_sleep_default, allowing that default to
>      be overridden if need be.
> 
>      At the same time, drop the relative_sleep_states command line
>      argument that doesn't make sense any more.
> 
>      Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>      Tested-by: Mario Limonciello <mario.limonciello@dell.com>
> 
> :040000 040000 a5770fe0413cbe7794eab28f72dfe8ede1f090c2
> a2882c77659517aa7137c930e0e7f178bc76bfbd M      Documentation
> :040000 040000 2594b1a87815173e97199ef9d9c5918fec22fcfd
> fe0b69953be653644c5366ac631131fdbbdb9bcc M      kernel
> $ git tag --contains 406e79385f3223d82272cf2be86bc95cd000a258
> v4.10-rc1
> v4.10-rc2
> v4.10-rc3
> ```
> 
> Please find the config and the bisection log attached. Sometimes I had to
> cherry-pick build fix commits for PIE enabled GCC on top.
> 
> Rafael, do you want me to open a bug report for that? Mario, what systems
> did you actually test this on? (Why isn’t that listed in the commit message?)
> Mario, do you have access to Dell XPS13 (9360) devices to help getting this
> fixed?
> 

I tested this on several systems and ensured that the kernel was doing the
right thing in terms of choosing the correct state to go into.

As I mentioned above, those behaviors are currently expected until these
types issues are identified and fixed in the proper subsystems.  If they
end up being troublesome to resolve, it's possible to quirk individual systems,
to disable this behavior and return to traditional S3 but I would prefer to actually 
identify and fix the various problems so that we can push the Linux stack forward.

[toc] | [prev] | [next] | [standalone]

#1560905 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com wrote:
> So in the <6s scenario, the intel-hid driver is responsible to receive the ACPI
> event and process accordingly.  The maintainer has a patch ready for the intel-hid
> portion of this work, but it's currently being reviewed by Intel to ensure it
> can be legally submitted into the kernel.

Who at Intel do I need to go kick to make this mythical legal review
happen faster so we can see the code?

Len and Rafael, what is going on here?

> > 406e79385f3223d82272cf2be86bc95cd000a258 is the first bad commit commit
> > 406e79385f3223d82272cf2be86bc95cd000a258
> > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Date:   Mon Nov 21 22:45:40 2016 +0100
> > 
> >      PM / sleep: System sleep state selection interface rework
> > 
> >      There are systems in which the platform doesn't support any special
> >      sleep states, so suspend-to-idle (PM_SUSPEND_FREEZE) is the only
> >      available system sleep state.  However, some user space frameworks
> >      only use the "mem" and (sometimes) "standby" sleep state labels, so
> >      the users of those systems need to modify user space in order to be
> >      able to use system suspend at all and that may be a pain in practice.
> > 
> >      Commit 0399d4db3edf (PM / sleep: Introduce command line argument for
> >      sleep state enumeration) attempted to address this problem by adding
> >      a command line argument to change the meaning of the "mem" string in
> >      /sys/power/state to make it trigger suspend-to-idle (instead of
> >      suspend-to-RAM).
> > 
> >      However, there also are systems in which the platform does support
> >      special sleep states, but suspend-to-idle is the preferred one anyway
> >      (it even may save more energy than the platform-provided sleep states
> >      in some cases) and the above commit doesn't help in those cases.
> > 
> >      For this reason, rework the system sleep state selection interface
> >      again (but preserve backwards compatibiliby).  Namely, add a new
> >      sysfs file, /sys/power/mem_sleep, that will control the system
> >      suspend mode triggered by writing "mem" to /sys/power/state (in
> >      analogy with what /sys/power/disk does for hibernation).  Make it
> >      select suspend-to-RAM ("deep" sleep) by default (if supported) and
> >      fall back to suspend-to-idle ("s2idle") otherwise and add a new
> >      command line argument, mem_sleep_default, allowing that default to
> >      be overridden if need be.
> > 
> >      At the same time, drop the relative_sleep_states command line
> >      argument that doesn't make sense any more.
> > 
> >      Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >      Tested-by: Mario Limonciello <mario.limonciello@dell.com>
> > 
> > :040000 040000 a5770fe0413cbe7794eab28f72dfe8ede1f090c2
> > a2882c77659517aa7137c930e0e7f178bc76bfbd M      Documentation
> > :040000 040000 2594b1a87815173e97199ef9d9c5918fec22fcfd
> > fe0b69953be653644c5366ac631131fdbbdb9bcc M      kernel
> > $ git tag --contains 406e79385f3223d82272cf2be86bc95cd000a258
> > v4.10-rc1
> > v4.10-rc2
> > v4.10-rc3
> > ```
> > 
> > Please find the config and the bisection log attached. Sometimes I had to
> > cherry-pick build fix commits for PIE enabled GCC on top.
> > 
> > Rafael, do you want me to open a bug report for that? Mario, what systems
> > did you actually test this on? (Why isn’t that listed in the commit message?)
> > Mario, do you have access to Dell XPS13 (9360) devices to help getting this
> > fixed?
> > 
> 
> I tested this on several systems and ensured that the kernel was doing the
> right thing in terms of choosing the correct state to go into.
> 
> As I mentioned above, those behaviors are currently expected until these
> types issues are identified and fixed in the proper subsystems.  If they
> end up being troublesome to resolve, it's possible to quirk individual systems,
> to disable this behavior and return to traditional S3 but I would prefer to actually 
> identify and fix the various problems so that we can push the Linux stack forward.

If the machine stops working on a newer kernel when it used to work
before, then you need to either revert the change, or provide a fix for
it.

I think I might have access to a newer Dell XPS13 now, I'll try to set
it up tomorrow to test 4.10-rc4 out...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1560935 — RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, January 17, 2017 12:24 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> len.brown@intel.com; linux-pm@vger.kernel.org
> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> bus: enable OS version only for SPT and newer)
> 
> On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
> wrote:
> > So in the <6s scenario, the intel-hid driver is responsible to receive
> > the ACPI event and process accordingly.  The maintainer has a patch
> > ready for the intel-hid portion of this work, but it's currently being
> > reviewed by Intel to ensure it can be legally submitted into the kernel.
> 
> Who at Intel do I need to go kick to make this mythical legal review happen
> faster so we can see the code?
> 
> Len and Rafael, what is going on here?
>

Len and Darren are both in the loop on the discussion around this patch.
I don't know if they'll have any (public) comments they can add on the matter
yet however.

We haven't broached the topic of the ACPI subsystem being frozen with Rafael
as it doesn't affect helping this problem until the intel-hid patch is added.

Rafael, since this is in process now, what are your thoughts?

> > > 406e79385f3223d82272cf2be86bc95cd000a258 is the first bad commit
> > > commit
> > > 406e79385f3223d82272cf2be86bc95cd000a258
> > > Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > Date:   Mon Nov 21 22:45:40 2016 +0100
> > >
> > >      PM / sleep: System sleep state selection interface rework
> > >
> > >      There are systems in which the platform doesn't support any special
> > >      sleep states, so suspend-to-idle (PM_SUSPEND_FREEZE) is the only
> > >      available system sleep state.  However, some user space frameworks
> > >      only use the "mem" and (sometimes) "standby" sleep state labels, so
> > >      the users of those systems need to modify user space in order to be
> > >      able to use system suspend at all and that may be a pain in practice.
> > >
> > >      Commit 0399d4db3edf (PM / sleep: Introduce command line argument
> for
> > >      sleep state enumeration) attempted to address this problem by adding
> > >      a command line argument to change the meaning of the "mem" string
> in
> > >      /sys/power/state to make it trigger suspend-to-idle (instead of
> > >      suspend-to-RAM).
> > >
> > >      However, there also are systems in which the platform does support
> > >      special sleep states, but suspend-to-idle is the preferred one anyway
> > >      (it even may save more energy than the platform-provided sleep
> states
> > >      in some cases) and the above commit doesn't help in those cases.
> > >
> > >      For this reason, rework the system sleep state selection interface
> > >      again (but preserve backwards compatibiliby).  Namely, add a new
> > >      sysfs file, /sys/power/mem_sleep, that will control the system
> > >      suspend mode triggered by writing "mem" to /sys/power/state (in
> > >      analogy with what /sys/power/disk does for hibernation).  Make it
> > >      select suspend-to-RAM ("deep" sleep) by default (if supported) and
> > >      fall back to suspend-to-idle ("s2idle") otherwise and add a new
> > >      command line argument, mem_sleep_default, allowing that default to
> > >      be overridden if need be.
> > >
> > >      At the same time, drop the relative_sleep_states command line
> > >      argument that doesn't make sense any more.
> > >
> > >      Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >      Tested-by: Mario Limonciello <mario.limonciello@dell.com>
> > >
> > > :040000 040000 a5770fe0413cbe7794eab28f72dfe8ede1f090c2
> > > a2882c77659517aa7137c930e0e7f178bc76bfbd M      Documentation
> > > :040000 040000 2594b1a87815173e97199ef9d9c5918fec22fcfd
> > > fe0b69953be653644c5366ac631131fdbbdb9bcc M      kernel
> > > $ git tag --contains 406e79385f3223d82272cf2be86bc95cd000a258
> > > v4.10-rc1
> > > v4.10-rc2
> > > v4.10-rc3
> > > ```
> > >
> > > Please find the config and the bisection log attached. Sometimes I
> > > had to cherry-pick build fix commits for PIE enabled GCC on top.
> > >
> > > Rafael, do you want me to open a bug report for that? Mario, what
> > > systems did you actually test this on? (Why isn’t that listed in the
> > > commit message?) Mario, do you have access to Dell XPS13 (9360)
> > > devices to help getting this fixed?
> > >
> >
> > I tested this on several systems and ensured that the kernel was doing
> > the right thing in terms of choosing the correct state to go into.
> >
> > As I mentioned above, those behaviors are currently expected until
> > these types issues are identified and fixed in the proper subsystems.
> > If they end up being troublesome to resolve, it's possible to quirk
> > individual systems, to disable this behavior and return to traditional
> > S3 but I would prefer to actually identify and fix the various problems so
> that we can push the Linux stack forward.
> 
> If the machine stops working on a newer kernel when it used to work
> before, then you need to either revert the change, or provide a fix for it.
> 

So in my mind there isn't exactly a clear cut definition of "stops working", 
particularly when it's an intentional change in behavior.

If the desire is to go back to S3 on this system, I'm happy to submit a patch
that will quirk this back to S3 on this system until we can get ACPI to not
freeze and Intel-HID to pick up the event it needs.

> I think I might have access to a newer Dell XPS13 now, I'll try to set it up
> tomorrow to test 4.10-rc4 out...
> 

If you don't, please contact me privately and I'm happy to try to help get
you access to one.

[toc] | [prev] | [next] | [standalone]

#1561120 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, January 17, 2017 12:24 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > len.brown@intel.com; linux-pm@vger.kernel.org
> > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> > bus: enable OS version only for SPT and newer)
> > 
> > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
> > wrote:
> > > So in the <6s scenario, the intel-hid driver is responsible to receive
> > > the ACPI event and process accordingly.  The maintainer has a patch
> > > ready for the intel-hid portion of this work, but it's currently being
> > > reviewed by Intel to ensure it can be legally submitted into the kernel.
> > 
> > Who at Intel do I need to go kick to make this mythical legal review happen
> > faster so we can see the code?
> > 
> > Len and Rafael, what is going on here?
> >
> 
> Len and Darren are both in the loop on the discussion around this patch.
> I don't know if they'll have any (public) comments they can add on the matter
> yet however.

Thanks Mario. Yes, there isn't much to say here in public other than to confirm
we are keenly aware of the problem and have been actively working on fixing it,
both for this instance, and the deeper systematic failure that resulted in this
situation. No amount of kicking will expedite the process at this point, but
should we feel the need, we'll reach out.

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1563988 — RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Greg,

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Tuesday, January 17, 2017 5:34 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
> pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
> jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> len.brown@intel.com; linux-pm@vger.kernel.org
> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> bus: enable OS version only for SPT and newer)
> 
> On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
> wrote:
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > Sent: Tuesday, January 17, 2017 12:24 PM
> > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > > len.brown@intel.com; linux-pm@vger.kernel.org
> > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> > > bus: enable OS version only for SPT and newer)
> > >
> > > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
> > > wrote:
> > > > So in the <6s scenario, the intel-hid driver is responsible to
> > > > receive the ACPI event and process accordingly.  The maintainer
> > > > has a patch ready for the intel-hid portion of this work, but it's
> > > > currently being reviewed by Intel to ensure it can be legally submitted
> into the kernel.
> > >
> > > Who at Intel do I need to go kick to make this mythical legal review
> > > happen faster so we can see the code?
> > >
> > > Len and Rafael, what is going on here?
> > >
> >
> > Len and Darren are both in the loop on the discussion around this patch.
> > I don't know if they'll have any (public) comments they can add on the
> > matter yet however.
> 
> Thanks Mario. Yes, there isn't much to say here in public other than to confirm
> we are keenly aware of the problem and have been actively working on fixing
> it, both for this instance, and the deeper systematic failure that resulted in this
> situation. No amount of kicking will expedite the process at this point, but
> should we feel the need, we'll reach out.
> 

The approval has come through and the patch has been submitted.
http://www.spinics.net/lists/platform-driver-x86/msg10286.html

Note: this is only half of the fix, the second half needs the ACPI subsystem to
not be frozen to be able to receive this event.

[toc] | [prev] | [next] | [standalone]

#1564086 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Fri, Jan 20, 2017 at 11:11:45PM +0000, Mario.Limonciello@dell.com wrote:
> Greg,
> 
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@infradead.org]
> > Sent: Tuesday, January 17, 2017 5:34 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
> > pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
> > jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > len.brown@intel.com; linux-pm@vger.kernel.org
> > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> > bus: enable OS version only for SPT and newer)
> > 
> > On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
> > wrote:
> > > > -----Original Message-----
> > > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > > Sent: Tuesday, January 17, 2017 12:24 PM
> > > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> > > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> > > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> > > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > > > len.brown@intel.com; linux-pm@vger.kernel.org
> > > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> > > > bus: enable OS version only for SPT and newer)
> > > >
> > > > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
> > > > wrote:
> > > > > So in the <6s scenario, the intel-hid driver is responsible to
> > > > > receive the ACPI event and process accordingly.  The maintainer
> > > > > has a patch ready for the intel-hid portion of this work, but it's
> > > > > currently being reviewed by Intel to ensure it can be legally submitted
> > into the kernel.
> > > >
> > > > Who at Intel do I need to go kick to make this mythical legal review
> > > > happen faster so we can see the code?
> > > >
> > > > Len and Rafael, what is going on here?
> > > >
> > >
> > > Len and Darren are both in the loop on the discussion around this patch.
> > > I don't know if they'll have any (public) comments they can add on the
> > > matter yet however.
> > 
> > Thanks Mario. Yes, there isn't much to say here in public other than to confirm
> > we are keenly aware of the problem and have been actively working on fixing
> > it, both for this instance, and the deeper systematic failure that resulted in this
> > situation. No amount of kicking will expedite the process at this point, but
> > should we feel the need, we'll reach out.
> > 
> 
> The approval has come through and the patch has been submitted.
> http://www.spinics.net/lists/platform-driver-x86/msg10286.html

Looks like it needs some work :)

And why isn't it tagged to go to the 4.10-stable kernel if it really
does fix some systems?

> Note: this is only half of the fix, the second half needs the ACPI subsystem to
> not be frozen to be able to receive this event.

Where is that change?

I'm still worried about 4.10-final, is that going to be broken for these
types of systems?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1564098 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 10:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Jan 20, 2017 at 11:11:45PM +0000, Mario.Limonciello@dell.com wrote:
>> Greg,
>>
>> > -----Original Message-----
>> > From: Darren Hart [mailto:dvhart@infradead.org]
>> > Sent: Tuesday, January 17, 2017 5:34 PM
>> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> > Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
>> > pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
>> > jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
>> > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
>> > len.brown@intel.com; linux-pm@vger.kernel.org
>> > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
>> > bus: enable OS version only for SPT and newer)
>> >
>> > On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
>> > wrote:
>> > > > -----Original Message-----
>> > > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
>> > > > Sent: Tuesday, January 17, 2017 12:24 PM
>> > > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> > > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
>> > > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
>> > > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
>> > > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
>> > > > len.brown@intel.com; linux-pm@vger.kernel.org
>> > > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
>> > > > bus: enable OS version only for SPT and newer)
>> > > >
>> > > > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
>> > > > wrote:
>> > > > > So in the <6s scenario, the intel-hid driver is responsible to
>> > > > > receive the ACPI event and process accordingly.  The maintainer
>> > > > > has a patch ready for the intel-hid portion of this work, but it's
>> > > > > currently being reviewed by Intel to ensure it can be legally submitted
>> > into the kernel.
>> > > >
>> > > > Who at Intel do I need to go kick to make this mythical legal review
>> > > > happen faster so we can see the code?
>> > > >
>> > > > Len and Rafael, what is going on here?
>> > > >
>> > >
>> > > Len and Darren are both in the loop on the discussion around this patch.
>> > > I don't know if they'll have any (public) comments they can add on the
>> > > matter yet however.
>> >
>> > Thanks Mario. Yes, there isn't much to say here in public other than to confirm
>> > we are keenly aware of the problem and have been actively working on fixing
>> > it, both for this instance, and the deeper systematic failure that resulted in this
>> > situation. No amount of kicking will expedite the process at this point, but
>> > should we feel the need, we'll reach out.
>> >
>>
>> The approval has come through and the patch has been submitted.
>> http://www.spinics.net/lists/platform-driver-x86/msg10286.html
>
> Looks like it needs some work :)
>
> And why isn't it tagged to go to the 4.10-stable kernel if it really
> does fix some systems?
>
>> Note: this is only half of the fix, the second half needs the ACPI subsystem to
>> not be frozen to be able to receive this event.
>
> Where is that change?
>
> I'm still worried about 4.10-final, is that going to be broken for these
> types of systems?

Nope.

I'm going to revert commit 08b98d329165 (PM / sleep / ACPI: Use the
ACPI_FADT_LOW_POWER_S0 flag) which introduced the problem in the first
place (yes, the bisection result it misleading).  In fact, the revert
is in my linux-next branch already, but I'm sort of out in the woods
now and the actual pull request will be sent next week.

BTW, this is a usual process.  We had tried to change the default
behaviour for certain class of systems and it didn't work, so we need
to take a step back, fix the problems that were exposed and try again
later.

It has been confused quite a bit, though, which is kind of worrisome.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1564364 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:49:50PM +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 21, 2017 at 10:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Jan 20, 2017 at 11:11:45PM +0000, Mario.Limonciello@dell.com wrote:
> >> Greg,
> >>
> >> > -----Original Message-----
> >> > From: Darren Hart [mailto:dvhart@infradead.org]
> >> > Sent: Tuesday, January 17, 2017 5:34 PM
> >> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> >> > Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
> >> > pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
> >> > jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> >> > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> >> > len.brown@intel.com; linux-pm@vger.kernel.org
> >> > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> >> > bus: enable OS version only for SPT and newer)
> >> >
> >> > On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
> >> > wrote:
> >> > > > -----Original Message-----
> >> > > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> >> > > > Sent: Tuesday, January 17, 2017 12:24 PM
> >> > > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> >> > > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> >> > > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> >> > > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> >> > > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> >> > > > len.brown@intel.com; linux-pm@vger.kernel.org
> >> > > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> >> > > > bus: enable OS version only for SPT and newer)
> >> > > >
> >> > > > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
> >> > > > wrote:
> >> > > > > So in the <6s scenario, the intel-hid driver is responsible to
> >> > > > > receive the ACPI event and process accordingly.  The maintainer
> >> > > > > has a patch ready for the intel-hid portion of this work, but it's
> >> > > > > currently being reviewed by Intel to ensure it can be legally submitted
> >> > into the kernel.
> >> > > >
> >> > > > Who at Intel do I need to go kick to make this mythical legal review
> >> > > > happen faster so we can see the code?
> >> > > >
> >> > > > Len and Rafael, what is going on here?
> >> > > >
> >> > >
> >> > > Len and Darren are both in the loop on the discussion around this patch.
> >> > > I don't know if they'll have any (public) comments they can add on the
> >> > > matter yet however.
> >> >
> >> > Thanks Mario. Yes, there isn't much to say here in public other than to confirm
> >> > we are keenly aware of the problem and have been actively working on fixing
> >> > it, both for this instance, and the deeper systematic failure that resulted in this
> >> > situation. No amount of kicking will expedite the process at this point, but
> >> > should we feel the need, we'll reach out.
> >> >
> >>
> >> The approval has come through and the patch has been submitted.
> >> http://www.spinics.net/lists/platform-driver-x86/msg10286.html
> >
> > Looks like it needs some work :)
> >
> > And why isn't it tagged to go to the 4.10-stable kernel if it really
> > does fix some systems?
> >
> >> Note: this is only half of the fix, the second half needs the ACPI subsystem to
> >> not be frozen to be able to receive this event.
> >
> > Where is that change?
> >
> > I'm still worried about 4.10-final, is that going to be broken for these
> > types of systems?
> 
> Nope.

Great!

> I'm going to revert commit 08b98d329165 (PM / sleep / ACPI: Use the
> ACPI_FADT_LOW_POWER_S0 flag) which introduced the problem in the first
> place (yes, the bisection result it misleading).  In fact, the revert
> is in my linux-next branch already, but I'm sort of out in the woods
> now and the actual pull request will be sent next week.
> 
> BTW, this is a usual process.  We had tried to change the default
> behaviour for certain class of systems and it didn't work, so we need
> to take a step back, fix the problems that were exposed and try again
> later.
> 
> It has been confused quite a bit, though, which is kind of worrisome.

Not a problem at all, and it's fine that it happened this way, I just
wanted to make sure the regression didn't hit a -final release.

Have a great vacation/trip.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1566129 — RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Saturday, January 21, 2017 3:11 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; rafael.j.wysocki@intel.com;
> pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
> jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> len.brown@intel.com; linux-pm@vger.kernel.org
> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> bus: enable OS version only for SPT and newer)
> 
> On Fri, Jan 20, 2017 at 11:11:45PM +0000, Mario.Limonciello@dell.com wrote:
> > Greg,
> >
> > > -----Original Message-----
> > > From: Darren Hart [mailto:dvhart@infradead.org]
> > > Sent: Tuesday, January 17, 2017 5:34 PM
> > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > > Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
> > > pmenzel@molgen.mpg.de; linux@leemhuis.info;
> tomas.winkler@intel.com;
> > > jan@gondor.com; alexander.usyskin@intel.com; linux-
> kernel@vger.kernel.org;
> > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > > len.brown@intel.com; linux-pm@vger.kernel.org
> > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> > > bus: enable OS version only for SPT and newer)
> > >
> > > On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
> > > wrote:
> > > > > -----Original Message-----
> > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > > > Sent: Tuesday, January 17, 2017 12:24 PM
> > > > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > > > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> > > > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> > > > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> > > > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> > > > > len.brown@intel.com; linux-pm@vger.kernel.org
> > > > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2]
> mei:
> > > > > bus: enable OS version only for SPT and newer)
> > > > >
> > > > > On Tue, Jan 17, 2017 at 04:57:49PM +0000,
> Mario.Limonciello@dell.com
> > > > > wrote:
> > > > > > So in the <6s scenario, the intel-hid driver is responsible to
> > > > > > receive the ACPI event and process accordingly.  The maintainer
> > > > > > has a patch ready for the intel-hid portion of this work, but it's
> > > > > > currently being reviewed by Intel to ensure it can be legally submitted
> > > into the kernel.
> > > > >
> > > > > Who at Intel do I need to go kick to make this mythical legal review
> > > > > happen faster so we can see the code?
> > > > >
> > > > > Len and Rafael, what is going on here?
> > > > >
> > > >
> > > > Len and Darren are both in the loop on the discussion around this patch.
> > > > I don't know if they'll have any (public) comments they can add on the
> > > > matter yet however.
> > >
> > > Thanks Mario. Yes, there isn't much to say here in public other than to
> confirm
> > > we are keenly aware of the problem and have been actively working on
> fixing
> > > it, both for this instance, and the deeper systematic failure that resulted in
> this
> > > situation. No amount of kicking will expedite the process at this point, but
> > > should we feel the need, we'll reach out.
> > >
> >
> > The approval has come through and the patch has been submitted.
> > http://www.spinics.net/lists/platform-driver-x86/msg10286.html
> 
> Looks like it needs some work :)
> 

+Alex @ Canonical

Yeah, hopefully Alex knocks out those and turns it around quickly.

> And why isn't it tagged to go to the 4.10-stable kernel if it really
> does fix some systems?

A matter of timing, none of us had anticipated the legal hold
that had occurred around this particular patch.  When he resubmits
it with the fixes needed from the other review, he should submit it
to 4.10-stable too.

Thanks,

[toc] | [prev] | [next] | [standalone]

#1564352 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:11 AM,  <Mario.Limonciello@dell.com> wrote:
> Greg,
>
>> -----Original Message-----
>> From: Darren Hart [mailto:dvhart@infradead.org]
>> Sent: Tuesday, January 17, 2017 5:34 PM
>> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
>> pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
>> jan@gondor.com; alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
>> yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
>> len.brown@intel.com; linux-pm@vger.kernel.org
>> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
>> bus: enable OS version only for SPT and newer)
>>
>> On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
>> wrote:
>> > > -----Original Message-----
>> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
>> > > Sent: Tuesday, January 17, 2017 12:24 PM
>> > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
>> > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
>> > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
>> > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
>> > > len.brown@intel.com; linux-pm@vger.kernel.org
>> > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
>> > > bus: enable OS version only for SPT and newer)
>> > >
>> > > On Tue, Jan 17, 2017 at 04:57:49PM +0000, Mario.Limonciello@dell.com
>> > > wrote:
>> > > > So in the <6s scenario, the intel-hid driver is responsible to
>> > > > receive the ACPI event and process accordingly.  The maintainer
>> > > > has a patch ready for the intel-hid portion of this work, but it's
>> > > > currently being reviewed by Intel to ensure it can be legally submitted
>> into the kernel.
>> > >
>> > > Who at Intel do I need to go kick to make this mythical legal review
>> > > happen faster so we can see the code?
>> > >
>> > > Len and Rafael, what is going on here?
>> > >
>> >
>> > Len and Darren are both in the loop on the discussion around this patch.
>> > I don't know if they'll have any (public) comments they can add on the
>> > matter yet however.
>>
>> Thanks Mario. Yes, there isn't much to say here in public other than to confirm
>> we are keenly aware of the problem and have been actively working on fixing
>> it, both for this instance, and the deeper systematic failure that resulted in this
>> situation. No amount of kicking will expedite the process at this point, but
>> should we feel the need, we'll reach out.
>>
>
> The approval has come through and the patch has been submitted.
> http://www.spinics.net/lists/platform-driver-x86/msg10286.html
>
> Note: this is only half of the fix, the second half needs the ACPI subsystem to
> not be frozen to be able to receive this event.

Can you please elaborate on what exactly you mean here?

ACPI events wake up the system from suspend-to-idle, because the SCI
is marked as a wakeup interrupt.  Is this not sufficient?  If it
isn't, then why?

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1566118 — RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Sunday, January 22, 2017 3:45 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Darren Hart
> <dvhart@infradead.org>; Rafael Wysocki <rafael.j.wysocki@intel.com>; Paul
> Menzel <pmenzel@molgen.mpg.de>; Thorsten Leemhuis
> <linux@leemhuis.info>; Tomas Winkler <tomas.winkler@intel.com>;
> jan@gondor.com; Alexander Usyskin <alexander.usyskin@intel.com>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>; Chen, Yu C
> <yu.c.chen@intel.com>; Tomi Sarvela <tomi.p.sarvela@intel.com>; Daniel
> Blueman <daniel@quora.org>; Len Brown <len.brown@intel.com>; Linux PM
> <linux-pm@vger.kernel.org>
> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> bus: enable OS version only for SPT and newer)
> 
> On Sat, Jan 21, 2017 at 12:11 AM,  <Mario.Limonciello@dell.com> wrote:
> > Greg,
> >
> >> -----Original Message-----
> >> From: Darren Hart [mailto:dvhart@infradead.org]
> >> Sent: Tuesday, January 17, 2017 5:34 PM
> >> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> >> Cc: gregkh@linuxfoundation.org; rafael.j.wysocki@intel.com;
> >> pmenzel@molgen.mpg.de; linux@leemhuis.info; tomas.winkler@intel.com;
> >> jan@gondor.com; alexander.usyskin@intel.com; linux-
> kernel@vger.kernel.org;
> >> yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> >> len.brown@intel.com; linux-pm@vger.kernel.org
> >> Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
> >> bus: enable OS version only for SPT and newer)
> >>
> >> On Tue, Jan 17, 2017 at 06:38:43PM +0000, Mario.Limonciello@dell.com
> >> wrote:
> >> > > -----Original Message-----
> >> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> >> > > Sent: Tuesday, January 17, 2017 12:24 PM
> >> > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> >> > > Cc: pmenzel@molgen.mpg.de; rafael.j.wysocki@intel.com;
> >> > > linux@leemhuis.info; tomas.winkler@intel.com; jan@gondor.com;
> >> > > alexander.usyskin@intel.com; linux-kernel@vger.kernel.org;
> >> > > yu.c.chen@intel.com; tomi.p.sarvela@intel.com; daniel@quora.org;
> >> > > len.brown@intel.com; linux-pm@vger.kernel.org
> >> > > Subject: Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2]
> mei:
> >> > > bus: enable OS version only for SPT and newer)
> >> > >
> >> > > On Tue, Jan 17, 2017 at 04:57:49PM +0000,
> Mario.Limonciello@dell.com
> >> > > wrote:
> >> > > > So in the <6s scenario, the intel-hid driver is responsible to
> >> > > > receive the ACPI event and process accordingly.  The maintainer
> >> > > > has a patch ready for the intel-hid portion of this work, but it's
> >> > > > currently being reviewed by Intel to ensure it can be legally submitted
> >> into the kernel.
> >> > >
> >> > > Who at Intel do I need to go kick to make this mythical legal review
> >> > > happen faster so we can see the code?
> >> > >
> >> > > Len and Rafael, what is going on here?
> >> > >
> >> >
> >> > Len and Darren are both in the loop on the discussion around this patch.
> >> > I don't know if they'll have any (public) comments they can add on the
> >> > matter yet however.
> >>
> >> Thanks Mario. Yes, there isn't much to say here in public other than to
> confirm
> >> we are keenly aware of the problem and have been actively working on
> fixing
> >> it, both for this instance, and the deeper systematic failure that resulted in
> this
> >> situation. No amount of kicking will expedite the process at this point, but
> >> should we feel the need, we'll reach out.
> >>
> >
> > The approval has come through and the patch has been submitted.
> > http://www.spinics.net/lists/platform-driver-x86/msg10286.html
> >
> > Note: this is only half of the fix, the second half needs the ACPI subsystem to
> > not be frozen to be able to receive this event.
> 
> Can you please elaborate on what exactly you mean here?
> 
> ACPI events wake up the system from suspend-to-idle, because the SCI
> is marked as a wakeup interrupt.  Is this not sufficient?  If it
> isn't, then why?
> 

+ Alex @ Canonical

Hmm.  Alex and I were testing this and finding that the event doesn't
wake from freeze even with the patch that lets intel-hid pick it up.

We've confirmed the event does make it through when not in freeze.
Can you recommend more debugging to introduce
here to better identify what's going on?

Alex, can you comment what you've checked already?

[toc] | [prev] | [next] | [standalone]

#1561221 — Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Mario, thanks for CCing this to linux-pm.

On Tue, Jan 17, 2017 at 5:57 PM,  <Mario.Limonciello@dell.com> wrote:
> Hi Paul,
>
> Thanks for raising this topic and including me.
> Suspend to Idle support in Linux as an alternative S3 on x86 is a new
> topic.  In all, I expected that some problems would arise as a result
> of this patch, and I hope they will spur interesting discussions and
> solutions.
>
> Something that might not be immediately obvious is that by supporting
> suspend to idle, new driver bugs are going to be identified for drivers
> that don't properly put hardware into low enough power modes for the CPU
> to go into the proper state.  Traditionally with S3 the BIOS would be responsible
> for powering devices down before S3 and back up when exiting S3.
> This onus is now on the OS.
>
>> -----Original Message-----
>> From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
>> Sent: Tuesday, January 17, 2017 8:34 AM
>> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>; Limonciello, Mario
>> <Mario_Limonciello@Dell.com>
>> Cc: Thorsten Leemhuis <linux@leemhuis.info>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>; Tomas Winkler <tomas.winkler@intel.com>;
>> Jan Niehusmann <jan@gondor.com>; Usyskin, Alexander
>> <alexander.usyskin@intel.com>; linux-kernel@vger.kernel.org; Chen, Yu C
>> <yu.c.chen@intel.com>; Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Daniel
>> Blueman <daniel@quora.org>; Len Brown <len.brown@intel.com>; linux-
>> pm@vger.kernel.org
>> Subject: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus:
>> enable OS version only for SPT and newer)
>>
>> Dear Rafael, dear Mario,
>>
>>
>> On 01/17/17 09:14, Thorsten Leemhuis wrote:
>> > Greg Kroah-Hartman wrote on 16.01.2017 12:05:
>> >> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
>> >>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
>> >>>>> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS
>> >>>>> version only for SPT and newer On Sat, Jan 14, 2017 at 08:27:31PM
>> >>>>> +0100, Paul Menzel wrote:
>> >>>>>> On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
>> >>>>>>> On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
>> >>>>>>>> On 01/11/17 15:12, Winkler, Tomas wrote:
>> >>>>>>>>>>> On 01/11/17 10:24, Winkler, Tomas wrote:
>> >>>>>>>>>>>>> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler
>> wrote:
>> >>>>>>>>>>>>>> On older platforms the command should be just ignored
>> by
>> >>>>>>>>>>>>>> the firmware but some older platforms misbehave so it's
>> >>>>>>>>>>>>>> safer to send the command only if required.
>> >>>>>>>>>>>>> Thanks! This fixes suspend-to-ram for me (on a Thinkpad
>> x201s).
>> >>>>>>>>>>>> What about Dell XPS13?
>>
>> There is a regression with Linux 4.10-rc{1,2,3} on the Intel Kaby Lake device
>> Dell XPS13 (9360). Hitting the power button, the light of the power button
>> never goes off. Pressing it again, nothing happen. Only pressing it like ten
>> seconds the screen comes back for five seconds, and then it seems to try to
>> suspend again.

Paul,

Can you please check if reverting commit 08b98d329165 (PM / sleep /
ACPI: Use the ACPI_FADT_LOW_POWER_S0 flag) helps?

If not, please send me the output of "cat /sys/power/mem_sleep" from
the affected system.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1561584 — Re: Regression on Dell XPS13

Dear Rafael, dear Mario,


On 01/18/17 03:18, Rafael J. Wysocki wrote:
> Mario, thanks for CCing this to linux-pm.

Rafael, you should have also received the message, Mario answered to.

> On Tue, Jan 17, 2017 at 5:57 PM,  <Mario.Limonciello@dell.com> wrote:

>> Thanks for raising this topic and including me.
>> Suspend to Idle support in Linux as an alternative S3 on x86 is a new
>> topic.  In all, I expected that some problems would arise as a result
>> of this patch, and I hope they will spur interesting discussions and
>> solutions.
>>
>> Something that might not be immediately obvious is that by supporting
>> suspend to idle, new driver bugs are going to be identified for drivers
>> that don't properly put hardware into low enough power modes for the CPU
>> to go into the proper state.  Traditionally with S3 the BIOS would be responsible
>> for powering devices down before S3 and back up when exiting S3.
>> This onus is now on the OS.

That is fine, but then it shouldn’t be the default, until most of these 
bugs are identified and fixed.

Also, the commit message should make that more clear, and in my opinion 
the tested devices be listed.

>>> -----Original Message-----
>>> From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
>>> Sent: Tuesday, January 17, 2017 8:34 AM
>>> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>; Limonciello, Mario
>>> <Mario_Limonciello@Dell.com>
>>> Cc: Thorsten Leemhuis <linux@leemhuis.info>; Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org>; Tomas Winkler <tomas.winkler@intel.com>;
>>> Jan Niehusmann <jan@gondor.com>; Usyskin, Alexander
>>> <alexander.usyskin@intel.com>; linux-kernel@vger.kernel.org; Chen, Yu C
>>> <yu.c.chen@intel.com>; Sarvela, Tomi P <tomi.p.sarvela@intel.com>; Daniel
>>> Blueman <daniel@quora.org>; Len Brown <len.brown@intel.com>; linux-
>>> pm@vger.kernel.org
>>> Subject: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus:
>>> enable OS version only for SPT and newer)
>>>
>>> On 01/17/17 09:14, Thorsten Leemhuis wrote:
>>>> Greg Kroah-Hartman wrote on 16.01.2017 12:05:
>>>>> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
>>>>>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
>>>>>>>> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS
>>>>>>>> version only for SPT and newer On Sat, Jan 14, 2017 at 08:27:31PM
>>>>>>>> +0100, Paul Menzel wrote:
>>>>>>>>> On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
>>>>>>>>>> On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
>>>>>>>>>>> On 01/11/17 15:12, Winkler, Tomas wrote:
>>>>>>>>>>>>>> On 01/11/17 10:24, Winkler, Tomas wrote:
>>>>>>>>>>>>>>>> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote:
>>>>>>>>>>>>>>>>> On older platforms the command should be just ignored by
>>>>>>>>>>>>>>>>> the firmware but some older platforms misbehave so it's
>>>>>>>>>>>>>>>>> safer to send the command only if required.
>>>>>>>>>>>>>>>> Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s).
>>>>>>>>>>>>>>> What about Dell XPS13?
>>>
>>> There is a regression with Linux 4.10-rc{1,2,3} on the Intel Kaby Lake device
>>> Dell XPS13 (9360). Hitting the power button, the light of the power button
>>> never goes off. Pressing it again, nothing happen. Only pressing it like ten
>>> seconds the screen comes back for five seconds, and then it seems to try to
>>> suspend again.

> Can you please check if reverting commit 08b98d329165 (PM / sleep /
> ACPI: Use the ACPI_FADT_LOW_POWER_S0 flag) helps?

Didn’t the `git bisect` run already take care of that? Anyway, I built 
Linus’ master with the commit reverted, and `deep` is now indeed 
selected. No idea, if something else changed, or I messed up during 
bisection.

```
$ git log --oneline -2
b35b50125fec Revert "PM / sleep / ACPI: Use the ACPI_FADT_LOW_POWER_S0 flag"
0aa0313f9d57 Merge tag 'modules-for-v4.10-rc5' of 
git://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux
$ more /sys/power/mem_sleep
s2idle [deep]
```

> If not, please send me the output of "cat /sys/power/mem_sleep" from
> the affected system.

I think it is `[s2idle] deep` when the bug occurred.

It *looks* like the BIOS indeed claims, that S0 saves more energy than S3.

```
$ sudo cat /sys/firmware/acpi/tables/FACP > facp.bin
$ iasl -d facp.bin
$ grep S0 facp.dsl
                       Low Power S0 Idle (V5) : 1
```


Kind regards,

Paul

[toc] | [prev] | [next] | [standalone]

#1561656 — Re: Regression on Dell XPS13

On Wed, Jan 18, 2017 at 12:11 PM, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> Dear Rafael, dear Mario,
>
>
> On 01/18/17 03:18, Rafael J. Wysocki wrote:
>>
>> Mario, thanks for CCing this to linux-pm.
>
>
> Rafael, you should have also received the message, Mario answered to.
>
>> On Tue, Jan 17, 2017 at 5:57 PM,  <Mario.Limonciello@dell.com> wrote:
>
>
>>> Thanks for raising this topic and including me.
>>> Suspend to Idle support in Linux as an alternative S3 on x86 is a new
>>> topic.  In all, I expected that some problems would arise as a result
>>> of this patch, and I hope they will spur interesting discussions and
>>> solutions.
>>>
>>> Something that might not be immediately obvious is that by supporting
>>> suspend to idle, new driver bugs are going to be identified for drivers
>>> that don't properly put hardware into low enough power modes for the CPU
>>> to go into the proper state.  Traditionally with S3 the BIOS would be
>>> responsible
>>> for powering devices down before S3 and back up when exiting S3.
>>> This onus is now on the OS.
>
>
> That is fine, but then it shouldn’t be the default, until most of these bugs
> are identified and fixed.

Right.

> Also, the commit message should make that more clear, and in my opinion the
> tested devices be listed.
>
>>>> -----Original Message-----
>>>> From: Paul Menzel [mailto:pmenzel@molgen.mpg.de]
>>>> Sent: Tuesday, January 17, 2017 8:34 AM
>>>> To: Rafael J. Wysocki <rafael.j.wysocki@intel.com>; Limonciello, Mario
>>>> <Mario_Limonciello@Dell.com>
>>>> Cc: Thorsten Leemhuis <linux@leemhuis.info>; Greg Kroah-Hartman
>>>> <gregkh@linuxfoundation.org>; Tomas Winkler <tomas.winkler@intel.com>;
>>>> Jan Niehusmann <jan@gondor.com>; Usyskin, Alexander
>>>> <alexander.usyskin@intel.com>; linux-kernel@vger.kernel.org; Chen, Yu C
>>>> <yu.c.chen@intel.com>; Sarvela, Tomi P <tomi.p.sarvela@intel.com>;
>>>> Daniel
>>>> Blueman <daniel@quora.org>; Len Brown <len.brown@intel.com>; linux-
>>>> pm@vger.kernel.org
>>>> Subject: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei:
>>>> bus:
>>>> enable OS version only for SPT and newer)
>>>>
>>>> On 01/17/17 09:14, Thorsten Leemhuis wrote:
>>>>>
>>>>> Greg Kroah-Hartman wrote on 16.01.2017 12:05:
>>>>>>
>>>>>> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
>>>>>>>
>>>>>>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
>>>>>>>>>
>>>>>>>>> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS
>>>>>>>>> version only for SPT and newer On Sat, Jan 14, 2017 at 08:27:31PM
>>>>>>>>> +0100, Paul Menzel wrote:
>>>>>>>>>>
>>>>>>>>>> On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> On 01/11/17 15:12, Winkler, Tomas wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On 01/11/17 10:24, Winkler, Tomas wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler
>>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On older platforms the command should be just ignored by
>>>>>>>>>>>>>>>>>> the firmware but some older platforms misbehave so it's
>>>>>>>>>>>>>>>>>> safer to send the command only if required.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Thanks! This fixes suspend-to-ram for me (on a Thinkpad
>>>>>>>>>>>>>>>>> x201s).
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> What about Dell XPS13?
>>>>
>>>>
>>>> There is a regression with Linux 4.10-rc{1,2,3} on the Intel Kaby Lake
>>>> device
>>>> Dell XPS13 (9360). Hitting the power button, the light of the power
>>>> button
>>>> never goes off. Pressing it again, nothing happen. Only pressing it like
>>>> ten
>>>> seconds the screen comes back for five seconds, and then it seems to try
>>>> to
>>>> suspend again.
>
>
>> Can you please check if reverting commit 08b98d329165 (PM / sleep /
>> ACPI: Use the ACPI_FADT_LOW_POWER_S0 flag) helps?
>
>
> Didn’t the `git bisect` run already take care of that? Anyway, I built
> Linus’ master with the commit reverted, and `deep` is now indeed selected.
> No idea, if something else changed, or I messed up during bisection.

The bisection could turn up the other commit depending on how it converged.

Anyway, I'm going to queue up a revert of 08b98d329165 (I may not be
able to push it before the end of the next week, though) and in the
meantime you should be able to work around the issue by adding
mem_sleep_default=deep to the kernel command line.

We can go back to asking the ACPI tables about what the default should
be when the driver issue exposed by that commit is fixed.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1560844 — Re: Regression on Dell XPS13

Lo! On 17.01.2017 15:34, Paul Menzel wrote:
> […]
>>> Paul, are you still having this issue?
>> Don't know about Paul, but I did a quick test with rc4 on my machine and
>> the issue is still there :-/
> I didn’t test Linux 4.10-rc4 yet, but I completed the bisection.
> 
> ```
> 406e79385f3223d82272cf2be86bc95cd000a258 is the first bad commit
> commit 406e79385f3223d82272cf2be86bc95cd000a258
> Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Date:   Mon Nov 21 22:45:40 2016 +0100
> 
>      PM / sleep: System sleep state selection interface rework
> 

@Paul: Many thx for tracking this down. I didn't try to revert the
patch, but my XPS 13 (9360) enters and resumes properly from
suspend-to-ram after running "echo deep | sudo tee /sys/power/mem_sleep"
(#sigh, I should have thought of this myself earlier, as I had seen that
commit :-/ )

@Mario: many thx for the detailed mail you just send to explain things.
Looking forward to give supend-to-idle (which Windows uses on this
laptop) a try. If you need help with testing anything let me know, if I
can spare a minute I'll try to help.

Ciao, Thorsten

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web