Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562741 > unrolled thread

Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-19 14:50 +0100
    Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support Tony Lindgren <tony@atomide.com> - 2017-01-19 16:00 +0100
      Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-19 16:40 +0100
        Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support Vignesh R <vigneshr@ti.com> - 2017-01-20 09:30 +0100

#1562741 — Re: [PATCH 0/3] tty: serial: 8250_omap: Enable DMA support

On Fri, Jan 13, 2017 at 10:20:21AM -0800, Tony Lindgren wrote:
> * Vignesh R <vigneshr@ti.com> [170113 00:03]:
> > This patch series re enables DMA support for UART 8250_omap driver.
> > 
> > Tested on AM335x, AM437x that use EDMA and OMAP5 and DRA74 EVM with
> > SDMA.
> 
> Is 8250_omap serial console working for you on omap5 in general?
> 
> I've noticed that it's really unresponsive for me as if the FIFO
> interrupt was not working. For example logging in might take several
> attempts and a long time with each character showing up much later
> after some timeout.
> 
> TX on the uart on omap5 seems to work OK, I do see all the console
> messages fine. And these patches do not make the issue better or
> worse.

Ok, I'm dropping them from my review queue then.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1562795

* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [170119 05:25]:
> On Fri, Jan 13, 2017 at 10:20:21AM -0800, Tony Lindgren wrote:
> > * Vignesh R <vigneshr@ti.com> [170113 00:03]:
> > > This patch series re enables DMA support for UART 8250_omap driver.
> > > 
> > > Tested on AM335x, AM437x that use EDMA and OMAP5 and DRA74 EVM with
> > > SDMA.
> > 
> > Is 8250_omap serial console working for you on omap5 in general?
> > 
> > I've noticed that it's really unresponsive for me as if the FIFO
> > interrupt was not working. For example logging in might take several
> > attempts and a long time with each character showing up much later
> > after some timeout.
> > 
> > TX on the uart on omap5 seems to work OK, I do see all the console
> > messages fine. And these patches do not make the issue better or
> > worse.
> 
> Ok, I'm dropping them from my review queue then.

It turned out to be not related to this set of patches, Vignesh
posted a fix for it. For this set:

Acked-by: Tony Lindgren <tony@atomide.com>

[toc] | [prev] | [next] | [standalone]

#1562829

On Thu, Jan 19, 2017 at 06:54:23AM -0800, Tony Lindgren wrote:
> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [170119 05:25]:
> > On Fri, Jan 13, 2017 at 10:20:21AM -0800, Tony Lindgren wrote:
> > > * Vignesh R <vigneshr@ti.com> [170113 00:03]:
> > > > This patch series re enables DMA support for UART 8250_omap driver.
> > > > 
> > > > Tested on AM335x, AM437x that use EDMA and OMAP5 and DRA74 EVM with
> > > > SDMA.
> > > 
> > > Is 8250_omap serial console working for you on omap5 in general?
> > > 
> > > I've noticed that it's really unresponsive for me as if the FIFO
> > > interrupt was not working. For example logging in might take several
> > > attempts and a long time with each character showing up much later
> > > after some timeout.
> > > 
> > > TX on the uart on omap5 seems to work OK, I do see all the console
> > > messages fine. And these patches do not make the issue better or
> > > worse.
> > 
> > Ok, I'm dropping them from my review queue then.
> 
> It turned out to be not related to this set of patches, Vignesh
> posted a fix for it. For this set:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Ugh, these are now gone from my queue, can someone resend them with this
acked-by added?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1563372

On Thursday 19 January 2017 09:05 PM, Greg Kroah-Hartman wrote:
> On Thu, Jan 19, 2017 at 06:54:23AM -0800, Tony Lindgren wrote:
>> * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [170119 05:25]:
>>> On Fri, Jan 13, 2017 at 10:20:21AM -0800, Tony Lindgren wrote:
>>>> * Vignesh R <vigneshr@ti.com> [170113 00:03]:
>>>>> This patch series re enables DMA support for UART 8250_omap driver.
>>>>>
>>>>> Tested on AM335x, AM437x that use EDMA and OMAP5 and DRA74 EVM with
>>>>> SDMA.
>>>>
>>>> Is 8250_omap serial console working for you on omap5 in general?
>>>>
>>>> I've noticed that it's really unresponsive for me as if the FIFO
>>>> interrupt was not working. For example logging in might take several
>>>> attempts and a long time with each character showing up much later
>>>> after some timeout.
>>>>
>>>> TX on the uart on omap5 seems to work OK, I do see all the console
>>>> messages fine. And these patches do not make the issue better or
>>>> worse.
>>>
>>> Ok, I'm dropping them from my review queue then.
>>
>> It turned out to be not related to this set of patches, Vignesh
>> posted a fix for it. For this set:
>>
>> Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Ugh, these are now gone from my queue, can someone resend them with this
> acked-by added?
> 

I have resent this series with the Ack:
http://marc.info/?l=linux-serial&m=148490028003788&w=2

-- 
Regards
Vignesh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web