Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561343 > unrolled thread
| Started by | Ritesh Harjani <riteshh@codeaurora.org> |
|---|---|
| First post | 2017-01-18 09:00 +0100 |
| Last post | 2017-01-20 07:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. Ritesh Harjani <riteshh@codeaurora.org> - 2017-01-18 09:00 +0100
Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. Adrian Hunter <adrian.hunter@intel.com> - 2017-01-19 11:50 +0100
Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. Ritesh Harjani <riteshh@codeaurora.org> - 2017-01-20 07:10 +0100
| From | Ritesh Harjani <riteshh@codeaurora.org> |
|---|---|
| Date | 2017-01-18 09:00 +0100 |
| Subject | Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. |
| Message-ID | <t0TjY-1fI-9@gated-at.bofh.it> |
Hi Shawn, On 1/10/2017 2:45 PM, Shawn Lin wrote: > On 2017/1/10 14:41, Ritesh Harjani wrote: >> From: Sahitya Tummala <stummala@codeaurora.org> >> >> Add new host operation ->platform_dumpregs to provide a >> mechanism through which host drivers can dump platform >> specific registers in addition to SDHC registers >> during error conditions. >> > > Although we have been preventing from adding new callback > for sdhci core, this one makes sense as there are more and more > vendor registers outside the scope of SDHCI spec. Sure thanks, shall I add your Reviewed-by on this patch 1/3. Would you be able to review other as well? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2017-01-19 11:50 +0100 |
| Message-ID | <t1is1-qM-5@gated-at.bofh.it> |
| In reply to | #1561343 |
On 18/01/17 09:57, Ritesh Harjani wrote: > Hi Shawn, > > On 1/10/2017 2:45 PM, Shawn Lin wrote: >> On 2017/1/10 14:41, Ritesh Harjani wrote: >>> From: Sahitya Tummala <stummala@codeaurora.org> >>> >>> Add new host operation ->platform_dumpregs to provide a >>> mechanism through which host drivers can dump platform >>> specific registers in addition to SDHC registers >>> during error conditions. >>> >> >> Although we have been preventing from adding new callback >> for sdhci core, this one makes sense as there are more and more >> vendor registers outside the scope of SDHCI spec. We are not prevented from adding new callbacks, but they have to represent logical functions not quirks. This patch seems fine to me except the name "platform_dumpregs" because "platform" doesn't mean "platform" here. Just plain "dumpregs" is better.
[toc] | [prev] | [next] | [standalone]
| From | Ritesh Harjani <riteshh@codeaurora.org> |
|---|---|
| Date | 2017-01-20 07:10 +0100 |
| Message-ID | <t1AyC-3Aa-19@gated-at.bofh.it> |
| In reply to | #1562586 |
On 1/19/2017 4:13 PM, Adrian Hunter wrote: > On 18/01/17 09:57, Ritesh Harjani wrote: >> Hi Shawn, >> >> On 1/10/2017 2:45 PM, Shawn Lin wrote: >>> On 2017/1/10 14:41, Ritesh Harjani wrote: >>>> From: Sahitya Tummala <stummala@codeaurora.org> >>>> >>>> Add new host operation ->platform_dumpregs to provide a >>>> mechanism through which host drivers can dump platform >>>> specific registers in addition to SDHC registers >>>> during error conditions. >>>> >>> >>> Although we have been preventing from adding new callback >>> for sdhci core, this one makes sense as there are more and more >>> vendor registers outside the scope of SDHCI spec. > > We are not prevented from adding new callbacks, but they have to represent > logical functions not quirks. > > This patch seems fine to me except the name "platform_dumpregs" because I took platform prefix similar to platform_execute_tuning. > "platform" doesn't mean "platform" here. Just plain "dumpregs" is better. Sure, I will only keep "dumpregs" in next revision. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web