Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561722 > unrolled thread

[PATCH] clk: uniphier: continue probing even if some clocks fail to register

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: uniphier: continue probing even if some clocks fail to register Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-01-18 13:50 +0100
    Re: [PATCH] clk: uniphier: continue probing even if some clocks fail  to register Stephen Boyd <sboyd@codeaurora.org> - 2017-01-21 01:40 +0100

#1561722 — [PATCH] clk: uniphier: continue probing even if some clocks fail to register

Do not let the entire probe function fail even if some clocks fail
to register.  Let's continue with succeeded clocks.  This will give
the system more chances to boot and allow us to investigate the
cause of the failure.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/clk/uniphier/clk-uniphier-core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/uniphier/clk-uniphier-core.c b/drivers/clk/uniphier/clk-uniphier-core.c
index 0007218..2cf3863 100644
--- a/drivers/clk/uniphier/clk-uniphier-core.c
+++ b/drivers/clk/uniphier/clk-uniphier-core.c
@@ -90,11 +90,8 @@ static int uniphier_clk_probe(struct platform_device *pdev)
 
 		dev_dbg(dev, "register %s (index=%d)\n", p->name, p->idx);
 		hw = uniphier_clk_register(dev, regmap, p);
-		if (IS_ERR(hw)) {
-			dev_err(dev, "failed to register %s (error %ld)\n",
-				p->name, PTR_ERR(hw));
-			return PTR_ERR(hw);
-		}
+		if (WARN(IS_ERR(hw), "failed to register %s", p->name))
+			continue;
 
 		if (p->idx >= 0)
 			hw_data->hws[p->idx] = hw;
-- 
2.7.4

[toc] | [next] | [standalone]

#1564022 — Re: [PATCH] clk: uniphier: continue probing even if some clocks fail to register

On 01/18, Masahiro Yamada wrote:
> Do not let the entire probe function fail even if some clocks fail
> to register.  Let's continue with succeeded clocks.  This will give
> the system more chances to boot and allow us to investigate the
> cause of the failure.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web