Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563313 > unrolled thread
| Started by | Hayes Wang <hayeswang@realtek.com> |
|---|---|
| First post | 2017-01-20 07:10 +0100 |
| Last post | 2017-01-20 17:10 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net] r8152: fix the rx doesn't work Hayes Wang <hayeswang@realtek.com> - 2017-01-20 07:10 +0100
RE: [PATCH net] r8152: fix the rx doesn't work Hayes Wang <hayeswang@realtek.com> - 2017-01-20 07:40 +0100
[PATCH net] r8152: fix rtl8152_post_reset function Hayes Wang <hayeswang@realtek.com> - 2017-01-20 07:50 +0100
Re: [PATCH net] r8152: fix rtl8152_post_reset function David Miller <davem@davemloft.net> - 2017-01-20 17:10 +0100
| From | Hayes Wang <hayeswang@realtek.com> |
|---|---|
| Date | 2017-01-20 07:10 +0100 |
| Subject | [PATCH net] r8152: fix the rx doesn't work |
| Message-ID | <t1AyC-3Aa-17@gated-at.bofh.it> |
The rtl8152_post_reset() doesn't submit the rx urb, so the rx wouldn't work.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index f3b48ad..e8f4f88 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3545,6 +3545,7 @@ static int rtl8152_post_reset(struct usb_interface *intf)
if (netif_carrier_ok(netdev)) {
mutex_lock(&tp->control);
tp->rtl_ops.enable(tp);
+ rtl_start_rx(tp);
rtl8152_set_rx_mode(netdev);
mutex_unlock(&tp->control);
netif_wake_queue(netdev);
--
2.7.4
[toc] | [next] | [standalone]
| From | Hayes Wang <hayeswang@realtek.com> |
|---|---|
| Date | 2017-01-20 07:40 +0100 |
| Message-ID | <t1B1D-3Nl-13@gated-at.bofh.it> |
| In reply to | #1563313 |
> Subject: [PATCH net] r8152: fix the rx doesn't work > > The rtl8152_post_reset() doesn't submit the rx urb, so the rx wouldn't work. > > Signed-off-by: Hayes Wang <hayeswang@realtek.com> Excuse me. Please ignore this patch. I would submit another one.
[toc] | [prev] | [next] | [standalone]
| From | Hayes Wang <hayeswang@realtek.com> |
|---|---|
| Date | 2017-01-20 07:50 +0100 |
| Subject | [PATCH net] r8152: fix rtl8152_post_reset function |
| Message-ID | <t1Bbk-3QV-11@gated-at.bofh.it> |
| In reply to | #1563313 |
The rtl8152_post_reset() should sumbit rx urb and interrupt transfer,
otherwise the rx wouldn't work and the linking change couldn't be
detected.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/usb/r8152.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index f3b48ad..0e99af0 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3545,12 +3545,14 @@ static int rtl8152_post_reset(struct usb_interface *intf)
if (netif_carrier_ok(netdev)) {
mutex_lock(&tp->control);
tp->rtl_ops.enable(tp);
+ rtl_start_rx(tp);
rtl8152_set_rx_mode(netdev);
mutex_unlock(&tp->control);
netif_wake_queue(netdev);
}
napi_enable(&tp->napi);
+ usb_submit_urb(tp->intr_urb, GFP_KERNEL);
return 0;
}
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-01-20 17:10 +0100 |
| Subject | Re: [PATCH net] r8152: fix rtl8152_post_reset function |
| Message-ID | <t1JVg-Ze-25@gated-at.bofh.it> |
| In reply to | #1563323 |
From: Hayes Wang <hayeswang@realtek.com> Date: Fri, 20 Jan 2017 14:33:55 +0800 > The rtl8152_post_reset() should sumbit rx urb and interrupt transfer, > otherwise the rx wouldn't work and the linking change couldn't be > detected. > > Signed-off-by: Hayes Wang <hayeswang@realtek.com> Applied, thank you.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web