Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1560775 > unrolled thread
| Started by | Keerthy <j-keerthy@ti.com> |
|---|---|
| First post | 2017-01-17 17:40 +0100 |
| Last post | 2017-01-19 00:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH V3 5/5] gpio: davinci: Remove custom .xlate Keerthy <j-keerthy@ti.com> - 2017-01-17 17:40 +0100
Re: [PATCH V3 5/5] gpio: davinci: Remove custom .xlate Linus Walleij <linus.walleij@linaro.org> - 2017-01-19 00:40 +0100
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Date | 2017-01-17 17:40 +0100 |
| Subject | [PATCH V3 5/5] gpio: davinci: Remove custom .xlate |
| Message-ID | <t0EXD-VQ-1@gated-at.bofh.it> |
With the current redesign of driver it's not necessary to have
custom .xlate() as the gpiolib will assign default of_gpio_simple_xlate().
Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/gpio/gpio-davinci.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 2a5ae04..86b4950 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -163,27 +163,6 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
return NULL;
}
-#ifdef CONFIG_OF_GPIO
-static int davinci_gpio_of_xlate(struct gpio_chip *gc,
- const struct of_phandle_args *gpiospec,
- u32 *flags)
-{
- struct davinci_gpio_controller *chips = dev_get_drvdata(gc->parent);
- struct davinci_gpio_platform_data *pdata = dev_get_platdata(gc->parent);
-
- if (gpiospec->args[0] > pdata->ngpio)
- return -EINVAL;
-
- if (gc != &chips->chip)
- return -EINVAL;
-
- if (flags)
- *flags = gpiospec->args[1];
-
- return gpiospec->args[0] % 32;
-}
-#endif
-
static int davinci_gpio_probe(struct platform_device *pdev)
{
static int ctrl_num, bank_base;
@@ -244,7 +223,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
#ifdef CONFIG_OF_GPIO
chips->chip.of_gpio_n_cells = 2;
- chips->chip.of_xlate = davinci_gpio_of_xlate;
chips->chip.parent = dev;
chips->chip.of_node = dev->of_node;
#endif
--
1.9.1
[toc] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-01-19 00:40 +0100 |
| Message-ID | <t17ZD-2aa-9@gated-at.bofh.it> |
| In reply to | #1560775 |
On Tue, Jan 17, 2017 at 5:29 PM, Keerthy <j-keerthy@ti.com> wrote: > With the current redesign of driver it's not necessary to have > custom .xlate() as the gpiolib will assign default of_gpio_simple_xlate(). > > Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com> > Signed-off-by: Keerthy <j-keerthy@ti.com> > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> Patch applied. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web