Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562227 > unrolled thread

[PATCH 0/5] UM: Fine-tuning for some function implementations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/5] UM: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-18 23:20 +0100
    Re: [PATCH 0/5] UM: Fine-tuning for some function implementations Richard Weinberger <richard@nod.at> - 2017-01-19 09:30 +0100
      Re: UM: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-19 18:30 +0100
        Re: UM: Fine-tuning for some function implementations Anton Ivanov <anton.ivanov@kot-begemot.co.uk> - 2017-01-19 21:30 +0100
      Re: [PATCH 0/5] UM: Fine-tuning for some function implementations Jeff Dike <jdike@addtoit.com> - 2017-01-20 06:30 +0100

#1562227 — [PATCH 0/5] UM: Fine-tuning for some function implementations

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 18 Jan 2017 22:48:02 +0100

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (5):
  port: Move an assignment for the variable "fd" in port_wait()
  port: Delete three error messages for a failed memory allocation
  port: Improve size determinations in port_data()
  ubd: Move two assignments for the variable "err" in ubd_remove()
  ubd: Improve size determinations in do_ubd_request()

 arch/um/drivers/port_kern.c | 23 ++++++++---------------
 arch/um/drivers/ubd_kern.c  | 18 +++++++++---------
 2 files changed, 17 insertions(+), 24 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1562467

Markus,

Am 18.01.2017 um 22:55 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 18 Jan 2017 22:48:02 +0100
> 
> A few update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (5):
>   port: Move an assignment for the variable "fd" in port_wait()
>   port: Delete three error messages for a failed memory allocation
>   port: Improve size determinations in port_data()
>   ubd: Move two assignments for the variable "err" in ubd_remove()
>   ubd: Improve size determinations in do_ubd_request()

please don't send drive-by patches.
Please see:
marc.info/?i=20170111225640.14e5d962@bbrezillon

Nacked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

[toc] | [prev] | [next] | [standalone]

#1562958 — Re: UM: Fine-tuning for some function implementations

> please don't send drive-by patches.

Would you dare to take another look at the published update steps
in any other software combination?

Regards,
Markus

[toc] | [prev] | [next] | [standalone]

#1563064 — Re: UM: Fine-tuning for some function implementations

How about tackling some real problems and performance issues instead?

There are a few of those in the network, interrupt and memory 
subsystems. Take your pick.

A.


On 19/01/17 17:13, SF Markus Elfring wrote:
>> please don't send drive-by patches.
> Would you dare to take another look at the published update steps
> in any other software combination?
>
> Regards,
> Markus
>

[toc] | [prev] | [next] | [standalone]

#1563297

The kmalloc(sizeof(struct foo), ...) => kmalloc(sizeof(*foo), ...)
ones are OK.

The rest is cargo-cult programming.

				Jeff
-- 
Jeff Dike
AddToIt
978-254-0789 (o)
978-394-8986 (c)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web