Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1561913 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2017-01-18 17:00 +0100 |
| Last post | 2017-01-18 17:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 17:00 +0100
Re: [PATCH v3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-18 17:30 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-01-18 17:00 +0100 |
| Subject | [PATCH v3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes |
| Message-ID | <t10Oz-5VY-21@gated-at.bofh.it> |
The "samsung,exynos5433-mipi-video-phy" and "samsung,exynos5250-dwusb3"
DT bindings don't specify a reg property for these nodes, so having a
unit name leads to the following DTC warnings:
Node /soc/video-phy@105c0710 has a unit name, but no reg property
Node /soc/usb@15400000 has a unit name, but no reg property
Node /soc/usb@15a00000 has a unit name, but no reg property
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v3:
- Use proper device node names, suggested by Krzysztof.
Changes in v2:
- Fix subject line since I forgot the "exynos" prefix.
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 59788d89b686..57c7bbeb65a7 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -706,7 +706,7 @@
interrupts = <GIC_PPI 9 0xf04>;
};
- mipi_phy: video-phy@105c0710 {
+ mipi_phy: video-phy {
compatible = "samsung,exynos5433-mipi-video-phy";
#phy-cells = <1>;
samsung,pmu-syscon = <&pmu_system_controller>;
@@ -1357,7 +1357,7 @@
status = "disabled";
};
- usbdrd30: usb@15400000 {
+ usbdrd30: usbdrd {
compatible = "samsung,exynos5250-dwusb3";
clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
<&cmu_fsys CLK_SCLK_USBDRD30>;
@@ -1404,7 +1404,7 @@
status = "disabled";
};
- usbhost30: usb@15a00000 {
+ usbhost30: usbhost {
compatible = "samsung,exynos5250-dwusb3";
clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
<&cmu_fsys CLK_SCLK_USBHOST30>;
--
2.7.4
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2017-01-18 17:30 +0100 |
| Subject | Re: [PATCH v3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes |
| Message-ID | <t11hv-6lt-3@gated-at.bofh.it> |
| In reply to | #1561913 |
On Wed, Jan 18, 2017 at 12:50:13PM -0300, Javier Martinez Canillas wrote: > The "samsung,exynos5433-mipi-video-phy" and "samsung,exynos5250-dwusb3" > DT bindings don't specify a reg property for these nodes, so having a > unit name leads to the following DTC warnings: > > Node /soc/video-phy@105c0710 has a unit name, but no reg property > Node /soc/usb@15400000 has a unit name, but no reg property > Node /soc/usb@15a00000 has a unit name, but no reg property > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v3: > - Use proper device node names, suggested by Krzysztof. > > Changes in v2: > - Fix subject line since I forgot the "exynos" prefix. > > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, applied. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web