Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561962 > unrolled thread

[PATCH] ARM: pxa: include linux/leds.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: pxa: include linux/leds.h Arnd Bergmann <arnd@arndb.de> - 2017-01-18 18:00 +0100
    Re: [PATCH] ARM: pxa: include linux/leds.h Robert Jarzmik <robert.jarzmik@free.fr> - 2017-01-18 19:30 +0100

#1561962 — [PATCH] ARM: pxa: include linux/leds.h

When the header is not included implicitly, we get a build failure:

arch/arm/mach-pxa/idp.c:205:22: error: field 'cdev' has incomplete type
  struct led_classdev     cdev;

This adds an explicit #include.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-pxa/idp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/idp.c b/arch/arm/mach-pxa/idp.c
index d1db32b1a2c6..88e0068f92a8 100644
--- a/arch/arm/mach-pxa/idp.c
+++ b/arch/arm/mach-pxa/idp.c
@@ -19,6 +19,7 @@
 #include <linux/init.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/leds.h>
 #include <linux/platform_device.h>
 #include <linux/fb.h>
 
-- 
2.9.0

[toc] | [next] | [standalone]

#1562047

Arnd Bergmann <arnd@arndb.de> writes:

> When the header is not included implicitly, we get a build failure:
>
> arch/arm/mach-pxa/idp.c:205:22: error: field 'cdev' has incomplete type
>   struct led_classdev     cdev;
>
> This adds an explicit #include.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sure, pushed into pxa/for-next, I hope it's not troublesome enough to include it
in the 4.10 cycle pxa fixes which is ... empty so far.

Cheers.

--
Robert

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web