Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560407 > unrolled thread

Re: [PATCH] drm/rockchip: vop: make vop register setting take effect

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] drm/rockchip: vop: make vop register setting take effect Tomasz Figa <tfiga@chromium.org> - 2017-01-17 10:50 +0100
    Re: [PATCH] drm/rockchip: vop: make vop register setting take effect Mark yao <mark.yao@rock-chips.com> - 2017-01-17 11:10 +0100

#1560407 — Re: [PATCH] drm/rockchip: vop: make vop register setting take effect

Hi Mark,

On Mon, Aug 29, 2016 at 11:51 AM, Mark yao <mark.yao@rock-chips.com> wrote:
> On 2016年08月27日 11:39, Chris Zhong wrote:
>>
>> The setting of vop registers need a reg_done writing to take effect.
>> In vop_enable the vop return to work by by restoring registers, but the
>> registers do not take effect immediately, it should a vop_cfg_done
>> after it. The same thing is needed by windows_disabled in
>> vop_crtc_disable.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
>>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>
> Thanks for your fix.
>
> applied to my drm-fixes.

This patch seems to have been lost in action. I don't see it in linux-next.

Best regards,
Tomasz

[toc] | [next] | [standalone]

#1560416

Hi Tomasz

I had sent to Dave, but maybe something is wrong, it miss.

the patch is on this pull-request:
https://lists.freedesktop.org/archives/dri-devel/2016-September/118505.html

I forgot to double check it, I will resend to Dave soon.

Thanks.

On 2017年01月17日 17:32, Tomasz Figa wrote:
> Hi Mark,
>
> On Mon, Aug 29, 2016 at 11:51 AM, Mark yao <mark.yao@rock-chips.com> wrote:
>> On 2016年08月27日 11:39, Chris Zhong wrote:
>>> The setting of vop registers need a reg_done writing to take effect.
>>> In vop_enable the vop return to work by by restoring registers, but the
>>> registers do not take effect immediately, it should a vop_cfg_done
>>> after it. The same thing is needed by windows_disabled in
>>> vop_crtc_disable.
>>>
>>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>> ---
>>>    drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++++
>>>    1 file changed, 4 insertions(+)
>> Thanks for your fix.
>>
>> applied to my drm-fixes.
> This patch seems to have been lost in action. I don't see it in linux-next.
>
> Best regards,
> Tomasz
>
>
>


-- 
Ｍark Yao

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web